discourse/spec/system
Alan Guo Xiang Tan e3977f84a3
FIX: Incorrect topic tracking state count when a new category is created (#20506)
What is the problem?

We have a hidden site setting `show_category_definitions_in_topic_lists`
which is set to false by default. What this means is that category
definition topics are not shown in the topic list by default. Only the
category definition topic for the category being viewed will be shown.
However, we have a bug where we would show that a category has new
topics when a new child category along with its category definition
topic is created even though the topic list does not list the child
category's category definition topic.

What is the fix here?

This commit fixes the problem by shipping down an additional
`is_category_topic` attribute in `TopicTrackingStateItemSerializer` when
the `show_category_definitions_in_topic_lists` site setting has been set
to false. With the new attribute, we can then exclude counting child
categories' category definition topics when counting new and unread
counts for a category.
2023-03-06 10:13:10 +08:00
..
page_objects FIX: Incorrect topic tracking state count when a new category is created (#20506) 2023-03-06 10:13:10 +08:00
user_page DEV: Apply syntax_tree formatting to `spec/*` 2023-01-09 11:49:28 +00:00
admin_customize_form_templates_spec.rb DEV: Show active categories in form templates customize table (#20498) 2023-03-01 12:37:14 -08:00
admin_customize_themes_spec.rb DEV: Apply syntax_tree formatting to `spec/*` 2023-01-09 11:49:28 +00:00
bookmarks_spec.rb FIX: Bookmark auto delete preference usage and default value (#19707) 2023-01-05 08:43:58 +10:00
category_edit_spec.rb DEV: Apply form template to categories (#20337) 2023-02-23 11:18:14 -08:00
custom_sidebar_sections_spec.rb DEV: configurable public sidebar sections (#20303) 2023-02-22 08:55:44 +11:00
fast_edit_spec.rb FIX: Fast edit doesn’t work on content with certain characters (#20410) 2023-02-23 11:30:16 +08:00
filtering_topics_spec.rb DEV: Experimental /filter route to filter through topics (#20494) 2023-03-03 09:46:21 +08:00
hashtag_autocomplete_spec.rb SECURITY: Default tags to show count of topics in unrestricted categories (#19916) 2023-01-20 09:50:24 +08:00
search_spec.rb DEV: skip failing spec (#20095) 2023-01-31 10:58:50 +01:00
user_preferences_interface_spec.rb FIX: Remove user_option saving for bookmark auto delete pref (#19476) 2022-12-16 08:50:31 +10:00
user_preferences_navigation_spec.rb UX: Release new user profile navigation for sidebar compatibility (#20134) 2023-02-21 10:16:16 +08:00
user_selector_spec.rb FIX: corrects a regression hiding avatar in user selector (#20107) 2023-02-01 16:42:39 +01:00
viewing_category_spec.rb FIX: Incorrect topic tracking state count when a new category is created (#20506) 2023-03-06 10:13:10 +08:00
viewing_sidebar_mobile_spec.rb DEV: Port sidebar mobile view acceptance tests to system tests (#20421) 2023-02-23 15:01:39 +08:00
viewing_sidebar_preferences_spec.rb DEV: Apply syntax_tree formatting to `spec/*` 2023-01-09 11:49:28 +00:00
viewing_sidebar_spec.rb FIX: Override navigation menu to "legacy" via query param not working (#20402) 2023-02-22 06:43:14 +08:00