Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-11 05:44:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
discourse/spec/models
History
Matt Marjanović aa4ff47208
FEATURE: Allow target attribute in links in user_field descriptions (#19102) 
This change adds `target` to the set of attributes allowed by the
HTML sanitizer which is applied to the description of a user_field.

The rationale for this change:

 * If one puts a link (<a>...</a>) in the description of a user_field
   that is present and/or required at sign-up, the expectation is that
   a prospective new user will click on that link during sign-up.
 * Without an appropriate `target` attribute on the link, the new page
   will be loaded in the same window/tab as the sign-up form, but this
   will obliterate any fields that the user had already filled-out on
   the form.  (E.g., hitting the back-button will return to an
   empty form.)
 * Such UX behavior is incredibly aggravating to new users.

This change allows an admin to add a `target` attribute to links, to
instruct the browser to open them in a different window/tab, leaving
a sign-up form intact.
2023-01-06 10:18:35 -03:00
..
about_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
admin_dashboard_data_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
api_key_scope_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
api_key_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
application_request_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
associated_group_spec.rb
Use service account credentials for fetching google hd groups (#18329)
2022-10-13 16:04:42 +01:00
badge_spec.rb
FEATURE: Allow setting default_enabled for badges (#19178)
2022-11-24 13:44:26 +01:00
badge_type_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
bookmark_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
category_featured_topic_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
category_group_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
category_list_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
category_spec.rb
FIX: Reset related site settings on general category delete (#18548)
2022-10-12 11:09:45 -06:00
category_user_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
child_theme_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
color_scheme_color_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
color_scheme_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
developer_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
digest_email_site_setting_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
directory_item_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
discourse_connect_spec.rb
FIX: Don't attempt to add user again to a group when syncing groups via SSO (#18772)
2022-10-28 13:27:12 +03:00
do_not_disturb_timing_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
draft_sequence_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
draft_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
email_change_request_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
email_log_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
email_token_spec.rb
FIX: do not redeem expired invites on new user signup (#17798)
2022-08-05 07:50:48 +05:30
embeddable_host_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
emoji_spec.rb
FIX: do not include group less emojis in standard list (#18659)
2022-10-19 09:53:56 +02:00
given_daily_like_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
global_setting_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
group_archived_message_spec.rb
DEV: Remove usages of enable_personal_messages (#18437)
2022-10-05 10:50:20 +10:00
group_associated_group_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
group_history_spec.rb
DEV: Automatically require 'rails_helper' in all specs (#16077)
2022-03-01 17:50:50 +00:00
group_spec.rb
FIX: Don't assume a clean slate in tests (#19499)
2022-12-19 12:12:03 -06:00
group_user_spec.rb
PERF: Update Group#user_count counter cache outside DB transaction (#19256)
2022-11-30 11:52:08 -03:00
incoming_link_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
incoming_links_report_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
invite_redeemer_spec.rb
SECURITY: Prevent email from being nil in InviteRedeemer (#19004)
2022-11-14 12:02:06 +10:00
invite_spec.rb
FIX: Existing users were mistakenly unable to redeem invite (#19191)
2022-11-25 11:57:04 +10:00
javascript_cache_spec.rb
DEV: Automatically require 'rails_helper' in all specs (#16077)
2022-03-01 17:50:50 +00:00
locale_site_setting_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
mailing_list_mode_site_setting_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
notification_spec.rb
FEATURE: deprioritize like notifications on all list (#19029)
2022-11-16 13:32:05 +11:00
optimized_image_spec.rb
DEV: Rename secure_media to secure_uploads (#18376)
2022-09-29 09:24:33 +10:00
permalink_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
plugin_store_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
post_action_spec.rb
DEV: Remove enable_whispers site setting (#19196)
2022-12-16 18:42:51 +02:00
post_action_type_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
post_analyzer_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
post_detail_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
post_mover_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
post_reply_key_spec.rb
DEV: Automatically require 'rails_helper' in all specs (#16077)
2022-03-01 17:50:50 +00:00
post_reply_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
post_revision_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
post_spec.rb
DEV: Remove enable_whispers site setting (#19196)
2022-12-16 18:42:51 +02:00
post_timing_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
private_message_topic_tracking_state_spec.rb
DEV: Remove enable_whispers site setting (#19196)
2022-12-16 18:42:51 +02:00
published_page_spec.rb
DEV: Automatically require 'rails_helper' in all specs (#16077)
2022-03-01 17:50:50 +00:00
quoted_post_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
remote_theme_spec.rb
SECURITY: Expand and improve SSRF Protections (#18815)
2022-11-01 16:33:17 +00:00
report_spec.rb
FEATURE: Track API and user API requests (#19186)
2022-11-29 13:07:42 +02:00
reviewable_claimed_topic_spec.rb
DEV: Automatically require 'rails_helper' in all specs (#16077)
2022-03-01 17:50:50 +00:00
reviewable_flagged_post_spec.rb
FIX: Don't notify of post deletion when agreeing with automatic flags. (#19241)
2022-11-29 14:18:07 -03:00
reviewable_history_spec.rb
DEV: Use AR enums in reviewables related code
2022-09-22 14:44:27 +02:00
reviewable_post_spec.rb
DEV: Use AR enums in reviewables related code
2022-09-22 14:44:27 +02:00
reviewable_queued_post_spec.rb
FIX: use reviewer's guardian permissions to create post/topic while approve. (#19710)
2023-01-05 19:31:37 +05:30
reviewable_score_spec.rb
DEV: Compatibility with Ruby 3.2 (#19303)
2022-12-13 16:03:53 -03:00
reviewable_spec.rb
FIX: Exclude claimed reviewables from user menu (#19179)
2022-12-01 07:09:57 +08:00
reviewable_user_spec.rb
DEV: Fix mocha deprecations (#18828)
2022-11-02 10:47:59 +01:00
s3_region_site_setting_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
screened_email_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
screened_ip_address_spec.rb
FIX: Update match_count of screened IP address (#19321)
2022-12-06 13:09:38 +02:00
screened_url_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
search_log_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
sidebar_section_link_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
site_setting_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
site_spec.rb
FIX: do not show welcome CTA banner if the welcome topic is deleted (#18528)
2022-10-10 16:53:19 +05:30
sitemap_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
skipped_email_log_spec.rb
DEV: Automatically require 'rails_helper' in all specs (#16077)
2022-03-01 17:50:50 +00:00
stylesheet_cache_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
tag_group_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
tag_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
tag_user_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
theme_field_spec.rb
DEV: Introduce minification and source maps for Theme JS (#18646)
2022-10-18 18:20:10 +01:00
theme_modifier_set_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
theme_spec.rb
DEV: Introduce minification and source maps for Theme JS (#18646)
2022-10-18 18:20:10 +01:00
top_menu_item_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
top_topic_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
topic_allowed_user_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
topic_converter_spec.rb
FEATURE: Make General the default category (#18383)
2022-09-30 12:20:21 -06:00
topic_embed_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
topic_featured_users_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
topic_group_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
topic_invite_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
topic_link_click_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
topic_link_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
topic_list_spec.rb
FIX: Avoid duplicate topic-list requests (#18073)
2022-08-24 11:54:01 +01:00
topic_participants_summary_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
topic_posters_summary_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
topic_spec.rb
DEV: Remove enable_whispers site setting (#19196)
2022-12-16 18:42:51 +02:00
topic_tag_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
topic_thumbnail_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
topic_timer_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
topic_tracking_state_spec.rb
DEV: Remove enable_whispers site setting (#19196)
2022-12-16 18:42:51 +02:00
topic_user_spec.rb
DEV: Remove usages of enable_personal_messages (#18437)
2022-10-05 10:50:20 +10:00
topic_view_item_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
translation_override_spec.rb
FEATURE: update bootstrap mode notice to add invite and wizard links (#17822)
2022-08-10 00:13:42 +05:30
trust_level3_requirements_spec.rb
DEV: Remove usages of enable_personal_messages (#18437)
2022-10-05 10:50:20 +10:00
trust_level_and_staff_setting_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
trust_level_setting_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
unsubscribe_key_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
upload_reference_spec.rb
FEATURE: Add dark mode option for category logos (#18460)
2022-10-07 11:00:44 -04:00
upload_spec.rb
FIX: Correctly handle HTTP errors during dominant color calculation (#18565)
2022-10-12 15:50:44 +01:00
user_action_spec.rb
FIX: action_code_path not being loaded for user-stream-item (#18577)
2022-10-13 19:10:18 +10:00
user_api_key_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
user_archived_message_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
user_associated_group_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
user_auth_token_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
user_avatar_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
user_badge_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
user_bookmark_list_spec.rb
FIX: Return next bookmarks page only if it exists (#18139)
2022-09-01 13:04:00 +03:00
user_email_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
user_export_spec.rb
DEV: Automatically require 'rails_helper' in all specs (#16077)
2022-03-01 17:50:50 +00:00
user_field_spec.rb
FEATURE: Allow target attribute in links in user_field descriptions (#19102)
2023-01-06 10:18:35 -03:00
user_history_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
user_notification_schedule_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
user_option_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
user_profile_spec.rb
SECURITY: Limit user profile field length (#18302)
2022-09-21 12:07:06 +10:00
user_profile_view_spec.rb
DEV: Automatically require 'rails_helper' in all specs (#16077)
2022-03-01 17:50:50 +00:00
user_search_spec.rb
DEV: Remove usages of enable_personal_messages (#18437)
2022-10-05 10:50:20 +10:00
user_second_factor_spec.rb
DEV: Automatically require 'rails_helper' in all specs (#16077)
2022-03-01 17:50:50 +00:00
user_spec.rb
PERF: Use user-specific channel for message-bus logout (#19719)
2023-01-04 19:55:52 +00:00
user_stat_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
user_status_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
user_summary_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
user_visit_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
username_validator_spec.rb
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
watched_word_spec.rb
FIX: Allow to add the same watched word with a different case (#17799)
2022-08-05 12:18:17 +02:00
web_crawler_request_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
web_hook_event_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
web_hook_spec.rb
SECURITY: Expand and improve SSRF Protections (#18815)
2022-11-01 16:33:17 +00:00