discourse/app
zogstrip aaec80413d FIX: fast edit with a typographic character
When a post containing an apostrophe (') is being cooked, the apostrophe is being converted to the "typographic" version (’) (because we enable markdown-it's **typographer** mode by default in Discourse)

When you select text that contains such apostrophe and then try to save your fast edit, it fails miserably without any error.

That's because when you select text from the DOM, it uses the cooked version which has the typographic apostrophe.

When you save your fast edit, we fetch the raw version of the post, which has the "regular" apostrophe. Thus doing `raw.replace(selectedText, editedText)` doesn't work because `raw` has the regular apostrophe but `selectedText` has the typographic apostrophe.

Since it's somewhat complicated to handle all typographic characters, we would basically have to reverse the process done in `custom-typographer-replacements.js`, we instead bail out and show the composer when we detect such character in the selection.

Internal ref - t/143836
2024-12-10 12:13:10 +01:00
..
assets FIX: fast edit with a typographic character 2024-12-10 12:13:10 +01:00
controllers FEATURE: add support for "Flagged By" filter in reviewable (#30197) 2024-12-10 18:26:38 +11:00
helpers DEV: Drop `WithServiceHelper` 2024-09-05 09:58:20 +02:00
jobs DEV: Fix broken sidekiq logging due to eeb01ea0de (#30199) 2024-12-10 17:01:25 +08:00
mailers UX: Use a dropdown for SSL mode for group SMTP (#27932) 2024-07-18 10:33:14 +10:00
models FEATURE: add support for "Flagged By" filter in reviewable (#30197) 2024-12-10 18:26:38 +11:00
serializers FEATURE: Show when a badge has been granted for a post (#29696) 2024-12-03 13:43:27 +11:00
services FEATURE: Add an option to block IPs and emails to bulk user delete (#29993) 2024-12-09 14:25:31 +03:00
views DEV: admin-login submit should be a button, not an input (#30156) 2024-12-06 11:48:15 -05:00