discourse/app
Martin Brennan 64b0b50ac0
FIX: Pass user to Email::Sender to avoid broken reply key for group_smtp email (#10978)
Our Email::Sender class accepts an optional user argument, which is used to create a PostReplyKey record when present. This record is used to sub out the %{reply_key} placeholder in the Reply-To mail header, so if we do not pass in the user we get a broken Reply-To header.

This is especially problematic in the IMAP group SMTP situation, because these emails go to customers that we are replying to, and when they reply to us the email bounces! This fixes the issue by passing user to the Email::Sender when sending a group_smtp email but there is still more to do in another PR.

This Email::Sender optional user is a bit of a footgun IMO, especially because most of the time we use it there is a user we can source. I would like to do another PR for this after this one to make the parameter not optional, so we don't end up with these reply issues down the line again.
2020-10-22 10:49:08 +10:00
..
assets UX: Fix mobile padding-top on mobile, follow up to da5841d (#10982) 2020-10-21 17:52:35 +11:00
controllers DEV: Add optional ENV variables for MiniProfiler snapshots transporter (#10985) 2020-10-21 19:37:28 +03:00
helpers Replace `base_uri` with `base_path` (#10879) 2020-10-09 12:51:24 +01:00
jobs FIX: Pass user to Email::Sender to avoid broken reply key for group_smtp email (#10978) 2020-10-22 10:49:08 +10:00
mailers FIX: When admin changes an email for the user the user must confirm the change (#10830) 2020-10-07 13:02:24 +10:00
models FIX: Restore users#topic_tracking_state route to api session_info scope (#10992) 2020-10-21 19:44:34 +01:00
serializers FEATURE: Topic slow mode. (#10904) 2020-10-16 16:24:38 -03:00
services REFACTOR: Removes double check of site setting in badge granter 2020-10-05 19:59:57 +02:00
views Revert "FEATURE: Upgrade analytics.js to gtag.js (#10893)" (#10910) 2020-10-13 12:20:41 -05:00