Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-06 11:28:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
discourse/spec/lib
History
Ted Johansson b50b63808c
DEV: Make Guardian#can_see? default to false for unwatched objects (#20412) 
When invoking e.g. `can_see?(Foo.new)`, the guardian checks if there's a method `#can_see_foo?` defined and if so uses that to determine whether the user can see it or not.

When such a method is not defined, the guardian currently returns `true`, but it is probably a better call (pun intended) to make it "safe by default" and return `false` instead. I.e. if you can't explicitly see it, you can't see it at all.

This change makes the change to `Guardian#can_see?` to fall back to `false` if no visibility check method is defined.

For `#can_see_user?` and `#can_see_tag?` we don't have any particular logic that prevents viewing. We previously relied on the implicit `true` value, but since that's now change to `false`, I have explicitly implemented these two methods in `UserGuardian` and `TagGuardian` modules. If in the future we want to add some logic for it, this would be the place.

To be clear, **the behaviour remains the same**, but the `true` value is now explicit rather than implicit.
2023-02-24 15:57:01 +08:00
..
auth
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
backup_restore
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
common_passwords
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
compression
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
concern
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
content_security_policy
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
email
Revert "DEV: Delete dead Topic#incoming_email_addresses code (#19970)" (#20037)
2023-01-27 11:27:15 +10:00
file_store
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
final_destination
FIX: allow changing default DNS query timeout of 2s via GlobalSetting (#20383)
2023-02-21 09:54:29 +11:00
freedom_patches
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
guardian
DEV: Make Guardian#can_see? default to false for unwatched objects (#20412)
2023-02-24 15:57:01 +08:00
highlight_js
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
i18n
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
imap
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
import
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
middleware
FIX: Ensure anon-cached values are never returned for API requests (#20021)
2023-01-26 13:26:29 +00:00
migration
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
onebox
FEATURE: Show more context in Discourse topic oneboxes
2023-01-11 14:22:53 +01:00
plugin
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
pretty_text
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
rate_limiter
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
scheduler
DEV: Prevent defer stats exception when thread aborted (#19863)
2023-01-16 09:08:44 +11:00
second_factor
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
seed_data
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
site_settings
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
stylesheet
DEV: Move to Sass compilation to dart-sass (#19910)
2023-02-07 12:24:57 -03:00
svg_sprite
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
theme_store
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
topic_query
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
validators
DEV: Correct syntax_tree violations
2023-02-02 13:03:11 +00:00
webauthn
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
wizard
DEV: Replace #pluck_first freedom patch with AR #pick in core (#19893)
2023-02-13 12:39:45 +08:00
admin_confirmation_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
admin_user_index_query_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
archetype_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
bookmark_manager_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
bookmark_query_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
bookmark_reminder_notification_handler_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
browser_detection_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
cache_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
category_badge_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
category_guardian_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
color_math_spec.rb
UX: Calculate missing hover/selected colors from existing colors (#20105)
2023-02-01 09:55:21 +00:00
composer_messages_finder_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
content_buffer_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
content_security_policy_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
cooked_post_processor_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
crawler_detection_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
current_user_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
db_helper_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
directory_helper_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
discourse_diff_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
discourse_event_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
discourse_hub_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
discourse_js_processor_spec.rb
FIX: Restore class-property babel transform for themes (#19883)
2023-01-16 18:06:46 +00:00
discourse_plugin_registry_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
discourse_redis_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
discourse_sourcemapping_url_processor_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
discourse_spec.rb
FEATURE: Introduce pg_force_readonly_mode GlobalSetting (#19612)
2023-01-19 13:59:11 +00:00
discourse_tagging_spec.rb
SECURITY: Default tags to show count of topics in unrestricted categories (#19916)
2023-01-20 09:50:24 +08:00
discourse_updates_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
distributed_cache_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
distributed_memoizer_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
distributed_mutex_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
email_cook_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
email_updater_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
ember_cli_spec.rb
DEV: Add test for EmberCli#ember_version (#18140)
2022-08-30 20:33:08 +01:00
encodings_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
enum_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
excerpt_parser_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
feed_element_installer_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
feed_item_accessor_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
file_helper_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
filter_best_posts_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
final_destination_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
flag_settings_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
gaps_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
git_url_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
global_path_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
group_email_credentials_check_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
guardian_spec.rb
DEV: Make Guardian#can_see? default to false for unwatched objects (#20412)
2023-02-24 15:57:01 +08:00
has_errors_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
hijack_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
html_prettify_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
html_to_markdown_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
image_sizer_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
inline_oneboxer_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
js_locale_helper_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
json_error_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
letter_avatar_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
message_id_service_spec.rb
DEV: Address TODOs for email Message-ID generation (#19842)
2023-01-12 13:54:15 +10:00
method_profiler_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
mini_sql_multisite_connection_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
mobile_detection_spec.rb
Drop support for iOS < 15.7 (#19847)
2023-01-16 17:28:59 +00:00
new_post_manager_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
new_post_result_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
onebox_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
oneboxer_spec.rb
SECURITY: Prevent XSS in local oneboxes (#20008)
2023-01-25 19:17:21 +02:00
onpdiff_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
pbkdf2_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
pinned_check_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
plain_text_to_markdown_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
post_action_creator_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
post_action_destroyer_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
post_creator_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
post_destroyer_spec.rb
FIX: Ensure soft-deleted topics can be deleted (#19802)
2023-01-27 16:15:33 +02:00
post_jobs_enqueuer_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
post_locker_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
post_merger_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
post_revisor_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
presence_channel_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
pretty_text_spec.rb
DEV: Update javascript:update_constants rake task following template colocation (#20365)
2023-02-20 06:20:47 +03:00
promotion_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
quote_comparer_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
rate_limiter_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
retrieve_title_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
rtl_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
s3_cors_rulesets_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
s3_helper_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
s3_inventory_multisite_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
s3_inventory_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
score_calculator_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
scss_checker_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
search_spec.rb
FEATURE: Roll out new search optimisations (#20364)
2023-02-20 11:53:35 +11:00
secure_session_spec.rb
Add RSpec 4 compatibility (#17652)
2022-07-28 10:27:38 +08:00
shrink_uploaded_image_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
sidebar_section_links_updater_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
site_icon_manager_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
site_setting_extension_multisite_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
site_setting_extension_spec.rb
DEV: Change default bootstrap min users for private sites (#19810)
2023-01-31 09:09:03 -07:00
slug_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
spam_handler_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
suggested_topics_builder_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
system_message_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
text_cleaner_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
text_sentinel_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
theme_flag_modifier_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
theme_javascript_compiler_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
theme_settings_manager_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
theme_settings_parser_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
timeline_lookup_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
tiny_japanese_segmenter_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
topic_creator_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
topic_publisher_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
topic_query_spec.rb
DEV: Add backend support for unread and new topics list (#20293)
2023-02-16 16:02:09 +03:00
topic_retriever_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
topic_upload_security_manager_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
topic_view_spec.rb
SECURITY: Show only visible tags in metadata
2023-02-23 17:22:20 +01:00
topics_bulk_action_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
trashable_spec.rb
DEV: Added .only_deleted scope in the Trashable module (#20196)
2023-02-07 15:28:59 -03:00
trust_level_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
twitter_api_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
unread_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
upload_creator_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
upload_markdown_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
upload_recovery_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
upload_security_spec.rb
FIX: Do not count deleted post for upload ref security (#19949)
2023-01-24 10:01:48 +10:00
url_helper_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
user_comm_screener_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
user_lookup_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
user_name_suggester_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
version_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00