e7bad9f05d
User directory items are sorted by some activity metric. If those metrics have the same value, postgres does not guarantee the order in which they will be returned. This can cause issues in pagination - some users may appear twice, and some may be missed. To illustrate ``` pry(main)> query = DirectoryItem.where(period_type: DirectoryItem.period_types[:weekly]).order(:likes_received).limit(50); pry(main)> page1 = query.offset(0).pluck(:id); pry(main)> page2 = query.offset(50).pluck(:id); pry(main)> (page1 & page2).count # users on both pages => 29 ``` If we use the primary key to tie-break matching metrics, things are much more reliable ``` pry(main)> query = DirectoryItem.where(period_type: DirectoryItem.period_types[:weekly]).order(:likes_received, :id).limit(50); pry(main)> page1 = query.offset(0).pluck(:id); pry(main)> page2 = query.offset(50).pluck(:id); pry(main)> (page1 & page2).count # users on both pages => 0 ``` This most commonly effects new sites where all the directory metrics are zero. The fact that the ordering is indeterminate makes it difficult to write a reliable test case for this. |
||
|---|---|---|
| .. | ||
| assets | ||
| controllers | ||
| helpers | ||
| jobs | ||
| mailers | ||
| models | ||
| serializers | ||
| services | ||
| views | ||