mirror of
https://github.com/discourse/discourse.git
synced 2025-02-06 03:18:23 +00:00
1f94ac154b
The spec contained an order dependency which would cause the default bool test to fail. You can confirm this by running the spec with the option "--order rand" a couple times. This dependency was caused by surprising behavior in SiteSetting::setting as shown below: SiteSetting.setting(:bool_setting?, false) SiteSetting.refresh! SiteSetting.bool_setting? #=> false SiteSetting.random_setting = true SiteSetting.bool_setting? #=> true SiteSetting.setting(:bool_setting?, false) SiteSetting.refresh! SiteSetting.bool_setting? #=> true! The spec is merely desriptive, and I have labeled what I think could be possible bugs.