discourse/spec/fixtures
Osama Sayegh 3f908c047d
FIX: Use the default value correctly for theme settings of type uploads (#20541)
When a theme setting of type `upload` has a default upload, it should return the URL of the specified default upload until a custom upload is used for the setting. However, currently this isn't the case and we get null instead of the default upload URL.

The reason for this is because the `super` method of `#value` already returns the default upload URL (if there's one), so we can't pass that to `cdn_url` which expects an upload ID:

c961dcc757/lib/theme_settings_manager.rb (L212)

This commit fixes the bug by skipping the call to `cdn_url` when we fallback to the default upload for the setting value.
2023-03-06 11:41:47 +03:00
..
backups FIX: Backups should use relative paths for local uploads 2020-08-21 15:22:28 +02:00
csv FEATURE: Add support for case-sensitive Watched Words (#17445) 2022-08-02 10:06:03 +02:00
db DEV: Apply syntax_tree formatting to `spec/*` 2023-01-09 11:49:28 +00:00
emails FIX: Parse address lists in embedded emails (#14514) 2021-10-06 15:07:29 +03:00
encodings FIX: Try detecting encoding of RSS feed 2018-08-01 10:41:20 +02:00
feed FIX: Select best link from Atom feed (#15663) 2022-01-21 17:54:18 +02:00
i18n FIX: Missing translation when translation override contained a `%{key}` (#16625) 2022-05-04 17:35:22 +02:00
images DEV: Fix png optimization test flakyness (#19535) 2022-12-20 16:05:14 -03:00
json DEV: Add a rake task to export/import translation overrides (#18487) 2022-10-05 15:22:16 -04:00
md A11Y: Set role=presentation if alt attr is missing (#18546) 2022-10-12 14:07:37 +03:00
media FIX: Add attachment content-disposition for all non-image files (#10058) 2020-06-17 11:16:37 +10:00
mmdb UX: Use user locale for locations. (#6527) 2018-10-25 10:54:01 +00:00
multisite Introduce multisite tests for better coverage. 2017-08-08 12:58:22 +09:00
onebox DEV: Remove old secure_media setting (#20259) 2023-02-14 09:41:18 +10:00
pdf FEATURE: Add attachments to outgoing emails 2019-07-25 15:57:45 +02:00
plugins DEV: Apply syntax_tree formatting to `spec/*` 2023-01-09 11:49:28 +00:00
scss DEV: Run prettier. (#6420) 2018-09-21 11:02:23 +00:00
site_settings FIX: fails loud if default setting is not set 2017-08-15 12:07:25 +02:00
theme_settings FIX: Use the default value correctly for theme settings of type uploads (#20541) 2023-03-06 11:41:47 +03:00
themes FIX: Allow themes to upload and serve js files (#8188) 2019-10-14 15:40:33 +11:00
woff2 FEATURE: support uploads for themes 2017-05-10 15:47:11 -04:00