Osama Sayegh d745568633
DEV: Stop polluting Class with deprecated settings methods (#10736)
`self.class` here evaluates to `Class` and then we're calling `define_method` on it which means all classes will have those methods defined in them. For example:

```
~/discourse(master*) » rails c
Loading development environment (Rails 6.0.3.3)
[1] pry(main)> Integer.methods
=> [:sqrt,
 :yaml_tag,
 :email_domains_blacklist=,
 :email_domains_whitelist=,
 :unicode_username_character_whitelist=,
 :user_website_domains_whitelist=,
 :whitelisted_link_domains=,
 :email_domains_blacklist,
 :email_domains_whitelist,
 :unicode_username_character_whitelist,
...
...
```

Fix here is to use `self.define_singleton_method`.
2020-09-24 01:58:53 +03:00
..
2020-09-01 13:41:04 +05:30
2020-04-28 15:59:39 +05:30
2019-11-29 15:49:08 +00:00
2020-07-22 16:02:31 +05:30
2020-08-21 11:36:53 +08:00
2020-09-10 13:41:46 +10:00
2019-10-21 12:08:20 +01:00
2019-05-13 15:24:24 +01:00
2020-05-05 13:46:57 +10:00
2020-09-01 13:41:04 +05:30
2020-09-01 13:41:04 +05:30
2020-09-01 13:41:04 +05:30
2020-09-01 13:41:04 +05:30
2020-05-27 19:05:24 +05:30
2020-09-01 10:22:32 +05:30
2020-04-28 15:59:39 +05:30
2019-10-17 16:58:22 +11:00