discourse/plugins/chat/spec/requests
Martin Brennan 3c5fb871c0 SECURITY: Filter unread bookmark reminders the user cannot see
There is an edge case where the following occurs:

1. The user sets a bookmark reminder on a post/topic
2. The post/topic is changed to a PM before or after the reminder
   fires, and the notification remains unread by the user
3. The user opens their bookmark reminder notification list
   and they can still see the notification even though they cannot
   access the topic anymore

There is a very low chance for information leaking here, since
the only thing that could be exposed is the topic title if it
changes to something sensitive.

This commit filters the bookmark unread notifications by using
the bookmarkable can_see? methods and also prevents sending
reminder notifications for bookmarks the user can no longer see.
2023-11-09 13:39:16 +11:00
..
admin FEATURE: Export chat messages to CSV file (#22113) 2023-06-21 16:13:36 +04:00
chat DEV: improves reliability of delete/restore/update specs (#24265) 2023-11-07 11:34:35 +01:00
core_ext SECURITY: Filter unread bookmark reminders the user cannot see 2023-11-09 13:39:16 +11:00
chat_controller_spec.rb PERF: cook message in background (#24227) 2023-11-06 15:45:30 +01:00
direct_messages_controller_spec.rb DEV: Refactor DM channel creation into new service pattern (#22144) 2023-07-03 10:18:37 +10:00
emojis_controller_spec.rb