mirror of
https://github.com/discourse/discourse.git
synced 2025-02-05 19:11:13 +00:00
fa8cd629f1
This commit adds token_hash and scopes columns to email_tokens table. token_hash is a replacement for the token column to avoid storing email tokens in plaintext as it can pose a security risk. The new scope column ensures that email tokens cannot be used to perform a different action than the one intended. To sum up, this commit: * Adds token_hash and scope to email_tokens * Reuses code that schedules critical_user_email * Refactors EmailToken.confirm and EmailToken.atomic_confirm methods * Periodically cleans old, unconfirmed or expired email tokens
30 lines
818 B
Ruby
30 lines
818 B
Ruby
# frozen_string_literal: true
|
|
|
|
class AddTokenHashToEmailToken < ActiveRecord::Migration[6.1]
|
|
def up
|
|
add_column :email_tokens, :token_hash, :string
|
|
|
|
loop do
|
|
rows = DB
|
|
.query("SELECT id, token FROM email_tokens WHERE token_hash IS NULL LIMIT 500")
|
|
.map { |row| { id: row.id, token_hash: Digest::SHA256.hexdigest(row.token) } }
|
|
|
|
break if rows.size == 0
|
|
|
|
data_string = rows.map { |r| "(#{r[:id]}, '#{r[:token_hash]}')" }.join(",")
|
|
execute <<~SQL
|
|
UPDATE email_tokens
|
|
SET token_hash = data.token_hash
|
|
FROM (VALUES #{data_string}) AS data(id, token_hash)
|
|
WHERE email_tokens.id = data.id
|
|
SQL
|
|
end
|
|
|
|
change_column_null :email_tokens, :token_hash, false
|
|
end
|
|
|
|
def down
|
|
drop_column :email_tokens, :token_hash, :string
|
|
end
|
|
end
|