Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
discourse/spec/requests
History
David Taylor d0243f741e
UX: Use dominant color as image loading placeholder (#18248) 
We previously had a system which would generate a 10x10px preview of images and add their URLs in a data-small-upload attribute. The client would then use that as the background-image of the `<img>` element. This works reasonably well on fast connections, but on slower connections it can take a few seconds for the placeholders to appear. The act of loading the placeholders can also break or delay the loading of the 'real' images.

This commit replaces the placeholder logic with a new approach. Instead of a 10x10px preview, we use imagemagick to calculate the average color of an image and store it in the database. The hex color value then added as a `data-dominant-color` attribute on the `<img>` element, and the client can use this as a `background-color` on the element while the real image is loading. That means no extra HTTP request is required, and so the placeholder color can appear instantly.

Dominant color will be calculated:
1. When a new upload is created
2. During a post rebake, if the dominant color is missing from an upload, it will be calculated and stored
3. Every 15 minutes, 25 old upload records are fetched and their dominant color calculated and stored. (part of the existing PeriodicalUpdates job)

Existing posts will continue to use the old 10x10px placeholder system until they are next rebaked
 		2022-09-20 10:28:17 +01:00
..
admin FIX: Keep private theme key secret from user (#18106) 2022-09-01 13:15:23 +03:00
api UX: Use dominant color as image loading placeholder (#18248) 2022-09-20 10:28:17 +01:00
about_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
application_controller_spec.rb DEV: Compile splash screen JS with ember-cli before inlining (#18150) 2022-09-01 09:58:48 +01:00
associate_accounts_controller_spec.rb DEV: Automatically require 'rails_helper' in all specs (#16077) 2022-03-01 17:50:50 +00:00
badges_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
bookmarks_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
bootstrap_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
categories_controller_spec.rb FIX: Avoid duplicate topic-list requests (#18073) 2022-08-24 11:54:01 +01:00
clicks_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
composer_messages_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
csp_reports_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
directory_columns_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
directory_items_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
do_not_disturb_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
drafts_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
email_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
embed_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
exceptions_controller_spec.rb FEATURE: Add page title to 404 pages (#16846) 2022-05-17 18:37:43 +03:00
export_csv_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
extra_locales_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
finish_installation_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
forums_controller_spec.rb DEV: New readonly mode. Only applies to non-staff (#16243) 2022-05-17 13:06:08 -05:00
groups_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
hashtags_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
inline_onebox_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
invites_controller_spec.rb FIX: Correctly pass `invite_to_topic` param to invites (#18229) 2022-09-12 13:16:53 -04:00
list_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
metadata_controller_spec.rb DEV: Automatically require 'rails_helper' in all specs (#16077) 2022-03-01 17:50:50 +00:00
notifications_controller_spec.rb DEV: Prioritize unread notifications in the experimental user menu (#18216) 2022-09-12 21:19:25 +03:00
offline_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
omniauth_callbacks_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
onebox_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
permalinks_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
post_action_users_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
post_actions_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
post_readers_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
posts_controller_spec.rb FIX: Do not attempt to serialize Tag objects when tagging disabled (#18264) 2022-09-15 16:17:48 +01:00
presence_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
published_pages_controller_spec.rb FEATURE: Count views on published pages (#17878) 2022-08-19 00:11:19 +08:00
push_notification_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
qunit_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
reviewable_claimed_topics_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
reviewables_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
robots_txt_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
safe_mode_controller_spec.rb DEV: Automatically require 'rails_helper' in all specs (#16077) 2022-03-01 17:50:50 +00:00
search_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
session_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
similar_topics_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
site_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
sitemap_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
static_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
steps_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
stylesheets_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
svg_sprite_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
tag_groups_controller_spec.rb DEV: Automatically require 'rails_helper' in all specs (#16077) 2022-03-01 17:50:50 +00:00
tags_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
theme_javascripts_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
topics_controller_spec.rb FIX: Destroy all posts when hard deleting topic (#17359) 2022-08-10 12:11:50 +03:00
uploads_controller_multisite_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
uploads_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
user_actions_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
user_api_keys_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
user_avatars_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
user_badges_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
user_status_controller_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
users_controller_spec.rb FIX: Remove last_unread_post excerpt logic for bookmarks (#17979) 2022-08-19 09:35:25 +10:00
users_email_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
webhooks_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
wizard_controller_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00