discourse/lib/theme_store
David Taylor 9fea43e46a
DEV: Remove use of `cd` in the app (#8337)
`FileUtils.cd` and `Dir.chdir` cause the working directory to change for the entire process. We run sidekiq jobs, hijacked requests and deferred jobs in threads, which can make working directory changes have unintended side-effects.

- Add a rubocop rule to warn about usage of Dir.chdir and FileUtils.cd
- Added rubocop:disable for scripts used outside the app
- Refactored code using cd to use alternative methods
- Temporarily skipped the rubocop check for lib/backup_restore. This will require more complex refactoring, so I will create a separate PR for review
2019-11-13 09:57:39 +00:00
..
git_importer.rb DEV: Remove use of `cd` in the app (#8337) 2019-11-13 09:57:39 +00:00
zip_exporter.rb DEV: Remove use of `cd` in the app (#8337) 2019-11-13 09:57:39 +00:00
zip_importer.rb DEV: Remove use of `cd` in the app (#8337) 2019-11-13 09:57:39 +00:00