mirror of
https://github.com/discourse/discourse.git
synced 2025-02-07 03:48:23 +00:00
ea5c3a3bdc
In AdminDashboardData we have a bunch of problem checks implemented as methods on that class. This PR absolves it of the responsibility by promoting each of those checks to a first class ProblemCheck. This way each of them can have their own priority and arbitrary functionality can be isolated in its own class. Think "extract class" refactoring over and over. Since they were all moved we can also get rid of the @@problem_syms class variable which was basically the old version of the registry now replaced by ProblemCheck.realtime. In addition AdminDashboardData::Problem value object has been entirely replaced with the new ProblemCheck::Problem (with compatible API). Lastly, I added some RSpec matchers to simplify testing of problem checks and provide helpful error messages when assertions fail.
42 lines
1.2 KiB
Ruby
42 lines
1.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe ProblemCheck::MissingMailgunApiKey do
|
|
subject(:check) { described_class.new }
|
|
|
|
describe ".call" do
|
|
before do
|
|
SiteSetting.stubs(reply_by_email_enabled: replies_enabled)
|
|
ActionMailer::Base.smtp_settings.stubs(dig: mailgun_address)
|
|
SiteSetting.stubs(mailgun_api_key: api_key)
|
|
end
|
|
|
|
context "when replies are disabled" do
|
|
let(:replies_enabled) { false }
|
|
let(:mailgun_address) { anything }
|
|
let(:api_key) { anything }
|
|
|
|
it { expect(check).to be_chill_about_it }
|
|
end
|
|
|
|
context "when not using Mailgun for replies" do
|
|
let(:replies_enabled) { false }
|
|
let(:mailgun_address) { nil }
|
|
let(:api_key) { anything }
|
|
|
|
it { expect(check).to be_chill_about_it }
|
|
end
|
|
|
|
context "when using Mailgun without an API key" do
|
|
let(:replies_enabled) { true }
|
|
let(:mailgun_address) { "foo" }
|
|
let(:api_key) { nil }
|
|
|
|
it do
|
|
expect(check).to have_a_problem.with_priority("low").with_message(
|
|
"The server is configured to send emails via Mailgun but you haven't provided an API key used to verify the webhook messages.",
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|