mirror of
https://github.com/discourse/discourse.git
synced 2025-02-07 20:08:26 +00:00
eb987460f2
* DEV: Make emoji elements focusable Since emoji elements are of type `<img>` it requires a `tablindex="0"` in order to be focusable. * WIP: Handle emoji focus/selection via arrow keys Near completion, however, need a few fixes/improvements and overall code cleanup * WIP: Testing * DEV: Fixes and cleanup * DEV: Follow conventions * DEV: Improve up/down traversal when recents present * DEV: Emoji markup in tests should include `tabindex` * DEV: Add `tabindex` to topic tests * DEV: Variable name as `searchInput` instead of `searchBar` * DEV: Use appropriate method name (`_setNumEmojiPerRow`) * DEV: Add comments and avoid nested if * WIP: Adding test * Fix first test * DEV: Add assertions for arrow keys and escape key * Some fixes for up/down navigation This does not fix everything, when going from one section to another, there are issues * Fix a small regression * FIX: Ability to focus on search results Fixes regression * Refactor calculating next up/down emoji * Debugging test failure * Skip stubborn CI test, add others Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>