Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
discourse/plugins/chat
History
Joffrey JAFFEUX dcaa719363
FIX: correctly handle subscriptions (#24270) 
Subscriptions manager have been a pain since the beginning, one of the problem is that thread and channels behave mostly the same but with various small difference which I expect to increase over time.

Trying to use subclasses for this case has proven to be a mistake, this commit now uses a class for each case (channel, thread) which for now contains a lot of duplication, which might be reduced in the future but has the merit to make reasoning about each case very simple.

This refactor is fixing a bug introduced in 90efdd7f9d which was causing the wrong channel to be unsubscribed, this shouldn't be possible anymore. We had tests for this which were disabled due to flakeyness, I will consider re-enabling them in the future.

Other notes:
- notices had been added to the subscriptions manager service, they have been moved into their own dedicated service: `ChatChannelNoticesManager`
- the `(each model)` trick used in `<ChatChannel />` since 90efdd7f9d to ensure atomicity has been applied to `<ChatThread />` too
 		2023-11-07 16:37:42 +01:00
..
app DEV: improves reliability of delete/restore/update specs (#24265) 2023-11-07 11:34:35 +01:00
assets FIX: correctly handle subscriptions (#24270) 2023-11-07 16:37:42 +01:00
config FEATURE: chat redesign - back button to exit threads (#24189) 2023-11-07 16:01:09 +08:00
db FEATURE: implements user based sidebar mode (#23078) 2023-08-18 20:33:07 +02:00
lib PERF: cook message in background (#24227) 2023-11-06 15:45:30 +01:00
public
…
spec DEV: improves reliability of delete/restore/update specs (#24265) 2023-11-07 11:34:35 +01:00
test/javascripts FIX: correctly handle subscriptions (#24270) 2023-11-07 16:37:42 +01:00
README.md DEV: Chat service object initial implementation (#19814) 2023-02-13 13:09:57 +01:00
plugin.rb DEV: Add meta_topic_id plugin metadata (#23838) 2023-10-10 10:16:13 +10:00

README.md

This plugin is still in active development and may change frequently

Documentation

The Discourse Chat plugin adds chat functionality to your Discourse so it can natively support both long-form and short-form communication needs of your online community.

For user documentation, see Discourse Chat.

For developer documentation, see Discourse Documentation.