discourse/plugins
Andrei Prigorshnev e6299a310f
FIX: Further optimize mentioning groups in chat messages (#24122)
A follow-up to faac6773. This PR eliminates one more heavy join by forcing 
Active Record to do two queries instead.

Also, along the way, I made this change:
```
# this generates two quries to the groups table
def groups_to_mention
  @groups_to_mention = mentionable_groups - groups_with_too_many_members
end

# so I changed it to (this makes only one query to the groups table):
def groups_to_mention
  @groups_to_mention ||= mentionable_groups.where("user_count <= ?", SiteSetting.max_users_notified_per_group_mention)
end
```
This one is kind of a premature optimization, because we don't have evidence that 
this extra query is a problem, but it seems cleaner this way.

Commits history on this PR may help better understand the change.
2023-10-31 18:17:37 +04:00
..
chat FIX: Further optimize mentioning groups in chat messages (#24122) 2023-10-31 18:17:37 +04:00
checklist DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
discourse-details DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
discourse-lazy-videos FIX: Add `rel=0` to youtube lazy videos url (#24173) 2023-10-31 08:04:23 -03:00
discourse-local-dates DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
discourse-narrative-bot DEV: Change anonymous_posting_min_trust_level to a group-based setting (#24072) 2023-10-25 11:45:10 +10:00
discourse-presence DEV: Sort imports 2023-10-10 21:46:54 +01:00
footnote DEV: Remove deprecated queue_jobs site setting (#24127) 2023-10-27 11:05:02 +08:00
poll DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
spoiler-alert Update translations (#24078) 2023-10-24 15:53:34 +02:00
styleguide FIX: Correct import path in styleguide (#24092) 2023-10-25 12:13:38 +01:00