Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue #4567 - Applying fixes from PR #4570 review 

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
This commit is contained in:
Joakim Erdfelt 2020-02-20 10:31:59 -06:00
parent 5df8b05327
commit 16230e6e1c
No known key found for this signature in database
GPG Key ID: 2D0E1FB8FE4B68B4
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
jetty-util/src/main/java/org/eclipse/jetty/util/log/StdErrLog.java
View File

@ -121,10 +121,12 @@ public class StdErrLog extends AbstractLogger
__threadNamePadding = pad; __threadNamePadding = pad;
} }
@SuppressWarnings("UnusedAssignment")
private int _level = LEVEL_INFO; private int _level = LEVEL_INFO;
// Level that this Logger was configured as (remembered in special case of .setDebugEnabled()) // Level that this Logger was configured as (remembered in special case of .setDebugEnabled())
private int _configuredLevel; private int _configuredLevel;
private PrintStream _stderr = System.err; private PrintStream _stderr = System.err;
@SuppressWarnings("UnusedAssignment")
private boolean _source = SOURCE; private boolean _source = SOURCE;
// Print the long form names, otherwise use abbreviated // Print the long form names, otherwise use abbreviated
private boolean _printLongNames = LONG_CLASSNAMES; private boolean _printLongNames = LONG_CLASSNAMES;
@ -216,7 +218,7 @@ public class StdErrLog extends AbstractLogger
{ {
// allow stacktrace display to be controlled by properties as well // allow stacktrace display to be controlled by properties as well
String stacks = getLoggingProperty(Log.PROPS, _name, "STACKS"); String stacks = getLoggingProperty(Log.PROPS, _name, "STACKS");
_hideStacks = stacks == null ? false : !Boolean.parseBoolean(stacks); _hideStacks = stacks != null && !Boolean.parseBoolean(stacks);
} }
catch (AccessControlException ignore) catch (AccessControlException ignore)
{ {
@ -235,6 +237,7 @@ public class StdErrLog extends AbstractLogger
this._printLongNames = printLongNames; this._printLongNames = printLongNames;
} }
@SuppressWarnings("unused")
public boolean isPrintLongNames() public boolean isPrintLongNames()
{ {
return this._printLongNames; return this._printLongNames;
@ -461,6 +464,7 @@ public class StdErrLog extends AbstractLogger
msg = ""; msg = "";
for (int i = 0; i < msgArgsLen; i++) for (int i = 0; i < msgArgsLen; i++)
{ {
//noinspection StringConcatenationInLoop
msg += "{} "; msg += "{} ";
} }
} }
@ -492,7 +496,7 @@ public class StdErrLog extends AbstractLogger
{ {
if (isHideStacks()) if (isHideStacks())
{ {
builder.append(": " + cause); builder.append(": ").append(cause);
} }
else else
{ {
@ -599,9 +603,8 @@ public class StdErrLog extends AbstractLogger
{ {
Throwable source = new Throwable(); Throwable source = new Throwable();
StackTraceElement[] frames = source.getStackTrace(); StackTraceElement[] frames = source.getStackTrace();
for (int i = 0; i < frames.length; i++) for (final StackTraceElement frame : frames)
{ {
final StackTraceElement frame = frames[i];
String clazz = frame.getClassName(); String clazz = frame.getClassName();
if (clazz.equals(StdErrLog.class.getName()) || clazz.equals(Log.class.getName())) if (clazz.equals(StdErrLog.class.getName()) || clazz.equals(Log.class.getName()))
{ {