Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6030 from eclipse/jetty-10.0.x-6028-root-getcontextpath 

Issue #6028 - Request.getContextPath() for root context should be empty string (Jetty 10)
This commit is contained in:
Joakim Erdfelt 2021-03-10 06:23:04 -06:00 committed by GitHub
parent 06ea681032 2710f22e53
commit 1df86522d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
jetty-servlet/src/test/java/org/eclipse/jetty/servlet/ServletContextHandlerTest.java
View File

@ -59,6 +59,7 @@ import javax.servlet.http.HttpSessionEvent;
import javax.servlet.http.HttpSessionIdListener;
import javax.servlet.http.HttpSessionListener;
import org.eclipse.jetty.http.HttpTester;
import org.eclipse.jetty.logging.StacklessLogging;
import org.eclipse.jetty.security.ConstraintSecurityHandler;
import org.eclipse.jetty.security.RoleInfo;
@ -84,6 +85,8 @@ import org.hamcrest.Matchers;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@ -691,6 +694,36 @@ public class ServletContextHandlerTest
_server.start();
}
@ParameterizedTest
@ValueSource(strings = {"/", ""})
public void testGetContextPathRoot(String inputContextPath) throws Exception
{
ServletContextHandler contextHandler = new ServletContextHandler();
contextHandler.setContextPath(inputContextPath);
contextHandler.addServlet(new ServletHolder(new HttpServlet()
{
@Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException
{
resp.setContentType("text/plain");
resp.setCharacterEncoding("utf-8");
resp.getWriter().printf("getContextPath()=[%s]", req.getContextPath());
}
}), "/dump");
_server.setHandler(contextHandler);
_server.start();
StringBuilder rawRequest = new StringBuilder();
rawRequest.append("GET /dump HTTP/1.1\r\n");
rawRequest.append("Host: local\r\n");
rawRequest.append("Connection: close\r\n");
rawRequest.append("\r\n");
String rawResponse = _connector.getResponse(rawRequest.toString());
HttpTester.Response response = HttpTester.parseResponse(rawResponse);
assertEquals(200, response.getStatus(), "response status");
assertEquals("getContextPath()=[]", response.getContent(), "response content");
}
@Test
public void testGetSetSessionTimeout() throws Exception
{