Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue #2267 Added extra asserts to o.e.j.s.session.CreationTest

This commit is contained in:
Jan Bartel 2018-03-06 10:17:11 +11:00
parent 076f3a8ab2
commit 1ecf774912
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/test-sessions/test-sessions-common/src/main/java/org/eclipse/jetty/server/session/TestSessionDataStore.java
View File

@ -19,7 +19,6 @@
package org.eclipse.jetty.server.session; package org.eclipse.jetty.server.session;
import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.HashSet; import java.util.HashSet;
import java.util.Map; import java.util.Map;
@ -102,8 +101,6 @@ public class TestSessionDataStore extends AbstractSessionDataStore
set.add(d.getId()); set.add(d.getId());
} }
return set; return set;
//return Collections.emptySet();
} }
} }

4
tests/test-sessions/test-sessions-common/src/test/java/org/eclipse/jetty/server/session/CreationTest.java
View File

@ -265,7 +265,7 @@ public class CreationTest
assertEquals(HttpServletResponse.SC_OK,response.getStatus()); assertEquals(HttpServletResponse.SC_OK,response.getStatus());
//ensure work has finished on the server side //ensure work has finished on the server side
_synchronizer.await(); _synchronizer.await(2*inactivePeriod, TimeUnit.SECONDS);
//check that the sessions exist persisted //check that the sessions exist persisted
assertTrue(contextHandler.getSessionHandler().getSessionCache().getSessionDataStore().exists(_servlet._id)); assertTrue(contextHandler.getSessionHandler().getSessionCache().getSessionDataStore().exists(_servlet._id));
@ -370,6 +370,8 @@ public class CreationTest
{ {
session = request.getSession(false); session = request.getSession(false);
assertNotNull(session); assertNotNull(session);
assertEquals(_id, session.getId());
assertNotNull(session.getAttribute("value"));
assertNull(session.getAttribute("B")); //check we don't see stuff from other context assertNull(session.getAttribute("B")); //check we don't see stuff from other context
} }