Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

jetty-9 optimised the selector change submission

This commit is contained in:
Greg Wilkins 2012-10-18 15:34:10 +11:00
parent 7a95722d66
commit 27e8efec94
1 changed files with 40 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
jetty-io/src/main/java/org/eclipse/jetty/io/SelectorManager.java
View File

@ -305,8 +305,9 @@ public abstract class SelectorManager extends AbstractLifeCycle implements Dumpa
private final Queue<Runnable> _changes = new ConcurrentLinkedQueue<>();
private final int _id;
private Selector _selector;
private Thread _thread;
private volatile Thread _thread;
private boolean _needsWakeup = true;
private boolean _runningChanges = false;
public ManagedSelector(int id)
{
@ -340,18 +341,48 @@ public abstract class SelectorManager extends AbstractLifeCycle implements Dumpa
*/
public void submit(Runnable change)
{
_changes.offer(change);
LOG.debug("Queued change {}", change);
boolean wakeup = _needsWakeup;
if (wakeup)
wakeup();
// if we have been called by the selector thread we can directly run the change
if (_thread==Thread.currentThread())
{
// If we are already iterating over the changes, just add this change to the list.
// No race here because it is this thread that is iterating over the changes.
if (_runningChanges)
_changes.offer(change);
else
{
// Otherwise we run the queued changes
runChanges();
// and then directly run the passed change
runChange(change);
}
}
else
{
// otherwise we have to queue the change and wakeup the selector
_changes.offer(change);
LOG.debug("Queued change {}", change);
boolean wakeup = _needsWakeup;
if (wakeup)
wakeup();
}
}
private void runChanges()
{
Runnable change;
while ((change = _changes.poll()) != null)
runChange(change);
try
{
if (_runningChanges)
throw new IllegalStateException();
_runningChanges=true;
Runnable change;
while ((change = _changes.poll()) != null)
runChange(change);
}
finally
{
_runningChanges=false;
}
}
protected void runChange(Runnable change)