From 2e57fb6fad51ed754321b8915c67674d8566569a Mon Sep 17 00:00:00 2001 From: Simone Bordet Date: Thu, 26 Jun 2014 10:45:00 +0200 Subject: [PATCH] Removed unnecessary volatile declaration. Calls to reset() are always followed by iterate() that provides a memory barrier by changing its state, which is an AtomicReference. --- .../org/eclipse/jetty/server/HttpConnection.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/HttpConnection.java b/jetty-server/src/main/java/org/eclipse/jetty/server/HttpConnection.java index 79f57934f95..3010934dfd5 100644 --- a/jetty-server/src/main/java/org/eclipse/jetty/server/HttpConnection.java +++ b/jetty-server/src/main/java/org/eclipse/jetty/server/HttpConnection.java @@ -557,14 +557,14 @@ public class HttpConnection extends AbstractConnection implements Runnable, Http private class SendCallback extends IteratingCallback { - ByteBuffer _content; - boolean _lastContent; - ResponseInfo _info; - ByteBuffer _header; - volatile Callback _callback; // TODO is this memory barrier needed? - boolean _shutdownOut; + private ResponseInfo _info; + private ByteBuffer _content; + private boolean _lastContent; + private Callback _callback; + private ByteBuffer _header; + private boolean _shutdownOut; - SendCallback() + private SendCallback() { super(true); }