From 839846d9a6e56b3557bb2aa3593d8e4591760ffd Mon Sep 17 00:00:00 2001 From: Simone Bordet Date: Tue, 3 Dec 2019 13:01:28 +0100 Subject: [PATCH] Fixes #4392 - Suppress logging of QuietException in HttpChannelState.asyncError(). Signed-off-by: Simone Bordet --- .../org/eclipse/jetty/server/HttpChannelState.java | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannelState.java b/jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannelState.java index bf302759120..74e72098f64 100644 --- a/jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannelState.java +++ b/jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannelState.java @@ -28,6 +28,7 @@ import javax.servlet.UnavailableException; import org.eclipse.jetty.http.BadMessageException; import org.eclipse.jetty.http.HttpStatus; +import org.eclipse.jetty.io.QuietException; import org.eclipse.jetty.server.handler.ContextHandler; import org.eclipse.jetty.server.handler.ContextHandler.Context; import org.eclipse.jetty.server.handler.ErrorHandler; @@ -406,8 +407,6 @@ public class HttpChannelState */ protected Action unhandle() { - boolean readInterested = false; - synchronized (this) { if (LOG.isDebugEnabled()) @@ -736,8 +735,10 @@ public class HttpChannelState } else { - LOG.warn(failure.toString()); - LOG.debug(failure); + if (!(failure instanceof QuietException)) + LOG.warn(failure.toString()); + if (LOG.isDebugEnabled()) + LOG.debug(failure); } } @@ -1340,7 +1341,7 @@ public class HttpChannelState * but that a handling thread may need to produce (fill/parse) * it. Typically called by the async read success callback. * - * @return true if more content may be available + * @return {@code true} if more content may be available */ public boolean onReadPossible() { @@ -1372,7 +1373,7 @@ public class HttpChannelState * Called to signal that a read has read -1. * Will wake if the read was called while in ASYNC_WAIT state * - * @return true if woken + * @return {@code true} if woken */ public boolean onReadEof() {