Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue #1642 - avoid casting to get to (base) Request

This commit is contained in:
Joakim Erdfelt 2017-06-22 12:05:43 -07:00
parent b0e5681451
commit 3aa42d989b
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/RuleContainer.java
View File

@ -181,24 +181,27 @@ public class RuleContainer extends Rule
request.setAttribute(_originalQueryStringAttribute,query); request.setAttribute(_originalQueryStringAttribute,query);
} }
// Ugly hack, we should just pass baseRequest into the API from RewriteHandler itself.
Request baseRequest = Request.getBaseRequest(request);
if (_rewriteRequestURI) if (_rewriteRequestURI)
{ {
String encoded=URIUtil.encodePath(applied); String encoded=URIUtil.encodePath(applied);
if (rule instanceof Rule.ApplyURI) if (rule instanceof Rule.ApplyURI)
((Rule.ApplyURI)rule).applyURI((Request)request,((Request)request).getRequestURI(), encoded); ((Rule.ApplyURI)rule).applyURI(baseRequest, baseRequest.getRequestURI(), encoded);
else else
((Request)request).setURIPathQuery(encoded); baseRequest.setURIPathQuery(encoded);
} }
if (_rewritePathInfo) if (_rewritePathInfo)
((Request)request).setPathInfo(applied); baseRequest.setPathInfo(applied);
target=applied; target=applied;
if (rule.isHandling()) if (rule.isHandling())
{ {
LOG.debug("handling {}",rule); LOG.debug("handling {}",rule);
Request.getBaseRequest(request).setHandled(true); baseRequest.setHandled(true);
} }
if (rule.isTerminating()) if (rule.isTerminating())