PR #11402 - changes for review
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
This commit is contained in:
parent
0ece73b769
commit
436f4f8507
|
@ -220,9 +220,6 @@ public class WebSocketConnection extends AbstractConnection implements Connectio
|
|||
BufferUtil.flipToFlush(buffer, 0);
|
||||
}
|
||||
|
||||
/**
|
||||
* Physical connection Open.
|
||||
*/
|
||||
@Override
|
||||
public void onOpen()
|
||||
{
|
||||
|
@ -236,11 +233,6 @@ public class WebSocketConnection extends AbstractConnection implements Connectio
|
|||
fillAndParse();
|
||||
}
|
||||
|
||||
/**
|
||||
* Physical connection disconnect.
|
||||
* <p>
|
||||
* Not related to WebSocket close handshake.
|
||||
*/
|
||||
@Override
|
||||
public void onClose(Throwable cause)
|
||||
{
|
||||
|
@ -273,11 +265,6 @@ public class WebSocketConnection extends AbstractConnection implements Connectio
|
|||
return true;
|
||||
}
|
||||
|
||||
/**
|
||||
* Event for no activity on connection (read or write)
|
||||
*
|
||||
* @return true to signal that the endpoint must be closed, false to keep the endpoint open
|
||||
*/
|
||||
@Override
|
||||
protected boolean onReadTimeout(TimeoutException timeout)
|
||||
{
|
||||
|
|
|
@ -109,7 +109,6 @@ public class ExplicitDemandTest
|
|||
if (frame.getOpCode() == OpCode.TEXT)
|
||||
textMessages.add(BufferUtil.toString(frame.getPayload()));
|
||||
callback.succeed();
|
||||
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -265,7 +264,7 @@ public class ExplicitDemandTest
|
|||
Session session = connect.get(5, TimeUnit.SECONDS);
|
||||
session.sendText("test-text", Callback.NOOP);
|
||||
|
||||
// We cannot receive messages in onOpen even if we have demanded.
|
||||
// We cannot receive messages while in onOpen, even if we have demanded.
|
||||
assertNull(onOpenSocket.textMessages.poll(1, TimeUnit.SECONDS));
|
||||
|
||||
// Once we leave onOpen we receive the message.
|
||||
|
|
Loading…
Reference in New Issue