Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes #3311 - Ability to serve HTTP and HTTPS from the same port. 

Fixed handling of upgradeTo() in case of null buffers.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
This commit is contained in:
Simone Bordet 2019-01-31 17:15:07 +01:00
parent ccda1ee5f6
commit 5061a5ca30
3 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
jetty-io/src/main/java/org/eclipse/jetty/io/AbstractEndPoint.java
View File

@ -427,15 +427,16 @@ public abstract class AbstractEndPoint extends IdleTimeout implements EndPoint
if (LOG.isDebugEnabled()) if (LOG.isDebugEnabled())
LOG.debug("{} upgrading from {} to {}", this, old_connection, newConnection); LOG.debug("{} upgrading from {} to {}", this, old_connection, newConnection);
ByteBuffer prefilled = (old_connection instanceof Connection.UpgradeFrom) ByteBuffer buffer = (old_connection instanceof Connection.UpgradeFrom) ?
?((Connection.UpgradeFrom)old_connection).onUpgradeFrom():null; ((Connection.UpgradeFrom)old_connection).onUpgradeFrom() :
null;
old_connection.onClose(); old_connection.onClose();
old_connection.getEndPoint().setConnection(newConnection); old_connection.getEndPoint().setConnection(newConnection);
if (newConnection instanceof Connection.UpgradeTo) if (newConnection instanceof Connection.UpgradeTo)
((Connection.UpgradeTo)newConnection).onUpgradeTo(prefilled); ((Connection.UpgradeTo)newConnection).onUpgradeTo(buffer);
else if (BufferUtil.hasContent(prefilled)) else if (BufferUtil.hasContent(buffer))
throw new IllegalStateException(); throw new IllegalStateException("Cannot upgrade: " + newConnection + " does not implement " + Connection.UpgradeTo.class.getName());
newConnection.onOpen(); newConnection.onOpen();
} }

7
jetty-io/src/main/java/org/eclipse/jetty/io/ssl/SslConnection.java
View File

@ -269,8 +269,11 @@ public class SslConnection extends AbstractConnection implements Connection.Upgr
@Override @Override
public void onUpgradeTo(ByteBuffer buffer) public void onUpgradeTo(ByteBuffer buffer)
{ {
acquireEncryptedInput(); if (BufferUtil.hasContent(buffer))
BufferUtil.append(_encryptedInput, buffer); {
acquireEncryptedInput();
BufferUtil.append(_encryptedInput, buffer);
}
} }
@Override @Override

3
jetty-server/src/main/java/org/eclipse/jetty/server/HttpConnection.java
View File

@ -199,7 +199,8 @@ public class HttpConnection extends AbstractConnection implements Runnable, Http
@Override @Override
public void onUpgradeTo(ByteBuffer buffer) public void onUpgradeTo(ByteBuffer buffer)
{ {
BufferUtil.append(getRequestBuffer(), buffer); if (BufferUtil.hasContent(buffer))
BufferUtil.append(getRequestBuffer(), buffer);
} }
@Override @Override