Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue #1546 - more cookie fixes

This commit is contained in:
Greg Wilkins 2017-05-15 23:34:28 +02:00
parent fc6ca37c77
commit 5141085fed
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
jetty-server/src/main/java/org/eclipse/jetty/server/CookieCutter.java
View File

@ -154,6 +154,7 @@ public class CookieCutter
if (i==last) if (i==last)
{ {
value = unquoted.toString(); value = unquoted.toString();
unquoted.setLength(0);
} }
else else
{ {

14
jetty-server/src/test/java/org/eclipse/jetty/server/RequestTest.java
View File

@ -1326,7 +1326,7 @@ public class RequestTest
"POST / HTTP/1.1\r\n"+ "POST / HTTP/1.1\r\n"+
"Host: whatever\r\n"+ "Host: whatever\r\n"+
"Cookie: name0=value0; name1 = value1 ; name2 = \"\\\"value2\\\"\" \n" + "Cookie: name0=value0; name1 = value1 ; name2 = \"\\\"value2\\\"\" \n" +
"Cookie: $Version=2; name3=value3=value3;$path=/path;$domain=acme.com;$port=8080; name4=; name5 = ; name6\n" + "Cookie: $Version=2; name3=value3=value3;$path=/path;$domain=acme.com;$port=8080; name4=\"\"; name5 = x ; name6\n" +
"Cookie: name7=value7;\n" + "Cookie: name7=value7;\n" +
"Connection: close\r\n"+ "Connection: close\r\n"+
"\r\n"); "\r\n");
@ -1343,14 +1343,14 @@ public class RequestTest
assertEquals("/path", cookies.get(3).getPath()); assertEquals("/path", cookies.get(3).getPath());
assertEquals("acme.com", cookies.get(3).getDomain()); assertEquals("acme.com", cookies.get(3).getDomain());
assertEquals("$port=8080", cookies.get(3).getComment()); assertEquals("$port=8080", cookies.get(3).getComment());
// assertEquals("name4", cookies.get(4).getName()); assertEquals("name4", cookies.get(4).getName());
// assertEquals("", cookies.get(4).getValue()); assertEquals("", cookies.get(4).getValue());
// assertEquals("name5", cookies.get(5).getName()); assertEquals("name5", cookies.get(5).getName());
// assertEquals("", cookies.get(5).getValue()); assertEquals("x", cookies.get(5).getValue());
// assertEquals("name6", cookies.get(6).getName()); // assertEquals("name6", cookies.get(6).getName());
// assertEquals("", cookies.get(6).getValue()); // assertEquals("", cookies.get(6).getValue());
assertEquals("name7", cookies.get(4).getName()); assertEquals("name7", cookies.get(6).getName());
assertEquals("value7", cookies.get(4).getValue()); assertEquals("value7", cookies.get(6).getValue());
cookies.clear(); cookies.clear();
response=_connector.getResponse( response=_connector.getResponse(