Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Address build/test failure against bad entities. (#10742) 

Bad entities in test case can lead to:

* external URL references
* required HTTP GET requests
* not testing redirectEntity / resolveEntity
  (the whole point of the test)

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
This commit is contained in:
Joakim Erdfelt 2023-10-16 20:48:28 -05:00 committed by GitHub
parent f0060d9523
commit 536a38aa8e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
jetty-xml/src/test/java/org/eclipse/jetty/xml/XmlParserTest.java
View File

@ -18,6 +18,7 @@ import javax.xml.parsers.SAXParser;
import javax.xml.parsers.SAXParserFactory;
import org.junit.jupiter.api.Test;
import org.xml.sax.InputSource;
import org.xml.sax.SAXException;
import org.xml.sax.XMLReader;
@ -31,12 +32,21 @@ public class XmlParserTest
@Test
public void testXmlParser() throws Exception
{
XmlParser parser = new XmlParser();
XmlParser parser = new XmlParser()
{
@Override
protected InputSource resolveEntity(String pid, String sid)
{
InputSource inputSource = super.resolveEntity(pid, sid);
assertNotNull(inputSource, "You are using entities in your XML that don't match your redirectEntity mappings: pid=" + pid + ", sid=" + sid);
return inputSource;
}
};
URL configURL = XmlConfiguration.class.getResource("configure_10_0.dtd");
parser.redirectEntity("configure_10_0.dtd", configURL);
parser.redirectEntity("http://jetty.eclipse.org/configure.dtd", configURL);
parser.redirectEntity("-//Mort Bay Consulting//DTD Configure//EN", configURL);
parser.redirectEntity("https://www.eclipse.org/jetty/configure_10_0.dtd", configURL);
parser.redirectEntity("-//Jetty//Configure//EN", configURL);
URL url = XmlParserTest.class.getClassLoader().getResource("org/eclipse/jetty/xml/configureWithAttr.xml");
XmlParser.Node testDoc = parser.parse(url.toString());