From 3f172067c4e43accc64422d027df2bac4c5a0055 Mon Sep 17 00:00:00 2001
From: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Date: Fri, 20 Jan 2012 11:12:26 -0700
Subject: [PATCH 01/10] Fixing tests so that when run on a CI within jetty
 itself,

---
 jetty-start/pom.xml                                |  4 ++--
 .../java/org/eclipse/jetty/start/MainTest.java     | 14 +++++---------
 2 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/jetty-start/pom.xml b/jetty-start/pom.xml
index 9fcfa2c2cc8..7d622d115e6 100644
--- a/jetty-start/pom.xml
+++ b/jetty-start/pom.xml
@@ -34,8 +34,8 @@
   </properties>
   <dependencies>
     <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
+      <groupId>org.eclipse.jetty.toolchain</groupId>
+      <artifactId>jetty-test-helper</artifactId>
       <scope>test</scope>
     </dependency>
   </dependencies>
diff --git a/jetty-start/src/test/java/org/eclipse/jetty/start/MainTest.java b/jetty-start/src/test/java/org/eclipse/jetty/start/MainTest.java
index 8e2f1f071bb..63143c7c377 100644
--- a/jetty-start/src/test/java/org/eclipse/jetty/start/MainTest.java
+++ b/jetty-start/src/test/java/org/eclipse/jetty/start/MainTest.java
@@ -13,12 +13,13 @@
 
 package org.eclipse.jetty.start;
 
-import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.*;
 
+import java.io.File;
 import java.io.IOException;
-import java.net.URL;
 import java.util.List;
 
+import org.eclipse.jetty.toolchain.test.MavenTestingUtils;
 import org.junit.Before;
 import org.junit.Test;
 
@@ -34,18 +35,13 @@ public class MainTest
     @Before
     public void setUp() throws Exception
     {
-        System.setProperty("jetty.home",this.getClass().getResource("/jetty.home").getFile());
+        File testJettyHome = MavenTestingUtils.getTestResourceDir("jetty.home");
+        System.setProperty("jetty.home",testJettyHome.getAbsolutePath());
     }
 
-    /**
-     * Test method for {@link org.eclipse.jetty.start.StartIniParser#loadStartIni(java.lang.String)}.
-     * @throws IOException 
-     */
     @Test
     public void testLoadStartIni() throws IOException
     {
-        URL startIni = this.getClass().getResource("/jetty.home/");
-        System.setProperty("jetty.home",startIni.getFile());
         Main main = new Main();
         List<String> args = main.parseStartIniFiles();
         assertEquals("Expected 5 uncommented lines in start.ini",9,args.size());

From 3df95d45c27c924c1f0e76c4c16a3f796ddf2470 Mon Sep 17 00:00:00 2001
From: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Date: Fri, 20 Jan 2012 11:27:38 -0700
Subject: [PATCH 02/10] Making --dry-run work with paths that have spaces

---
 .../java/org/eclipse/jetty/start/Main.java    | 19 +++++++++++--------
 .../jetty/test/monitor/ProgramConfigTest.java |  8 +-------
 2 files changed, 12 insertions(+), 15 deletions(-)

diff --git a/jetty-start/src/main/java/org/eclipse/jetty/start/Main.java b/jetty-start/src/main/java/org/eclipse/jetty/start/Main.java
index 69112f8f319..34715f9a7bd 100644
--- a/jetty-start/src/main/java/org/eclipse/jetty/start/Main.java
+++ b/jetty-start/src/main/java/org/eclipse/jetty/start/Main.java
@@ -663,17 +663,19 @@ public class Main
     {
         StringBuilder cmd = new StringBuilder();
         cmd.append(findJavaBin());
-        for (String x : _jvmArgs)
-            cmd.append(' ').append(x);
-        cmd.append(" -Djetty.home=").append(_jettyHome);
+        for (String x : _jvmArgs) {
+            cmd.append(" \"").append(x).append("\"");
+        }
+        cmd.append(" \"-Djetty.home=").append(_jettyHome).append("\"");
         for (String p : _sysProps)
         {
-            cmd.append("   -D").append(p);
+            cmd.append("  \"-D").append(p);
             String v = System.getProperty(p);
             if (v != null && v.length() > 0)
                 cmd.append('=').append(v);
+            cmd.append("\"");
         }
-        cmd.append("   -cp ").append(classpath.toString());
+        cmd.append("   -cp \"").append(classpath.toString()).append("\"");
         cmd.append("   ").append(_config.getMainClassname());
 
         // Check if we need to pass properties as a file
@@ -681,15 +683,16 @@ public class Main
         if (properties.size() > 0)
         {
             File prop_file = File.createTempFile("start",".properties");
-            if (!_dryRun)
+            if (!_dryRun) {
                 prop_file.deleteOnExit();
+            }
             properties.store(new FileOutputStream(prop_file),"start.jar properties");
-            cmd.append(" ").append(prop_file.getAbsolutePath());
+            cmd.append(" \"").append(prop_file.getAbsolutePath()).append("\"");
         }
 
         for (String xml : xmls)
         {
-            cmd.append(' ').append(xml);
+            cmd.append(" \"").append(xml).append("\"");
         }
 
         return cmd.toString();
diff --git a/tests/test-integration/src/test/java/org/eclipse/jetty/test/monitor/ProgramConfigTest.java b/tests/test-integration/src/test/java/org/eclipse/jetty/test/monitor/ProgramConfigTest.java
index 20c170f0cef..5d658b28f2a 100644
--- a/tests/test-integration/src/test/java/org/eclipse/jetty/test/monitor/ProgramConfigTest.java
+++ b/tests/test-integration/src/test/java/org/eclipse/jetty/test/monitor/ProgramConfigTest.java
@@ -13,15 +13,11 @@
 
 package org.eclipse.jetty.test.monitor;
 
-import static org.junit.Assert.assertTrue;
-
 import java.io.IOException;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicLong;
 
-import javax.management.MBeanServerConnection;
-
 import org.eclipse.jetty.client.ContentExchange;
 import org.eclipse.jetty.client.HttpClient;
 import org.eclipse.jetty.http.HttpMethods;
@@ -35,7 +31,6 @@ import org.eclipse.jetty.monitor.jmx.MonitorAction;
 import org.eclipse.jetty.monitor.triggers.GreaterThanAttrEventTrigger;
 import org.eclipse.jetty.monitor.triggers.LessThanOrEqualToAttrEventTrigger;
 import org.eclipse.jetty.monitor.triggers.OrEventTrigger;
-import org.eclipse.jetty.toolchain.jmx.JmxServiceConnection;
 import org.eclipse.jetty.toolchain.test.JettyDistro;
 import org.eclipse.jetty.util.log.Log;
 import org.eclipse.jetty.util.log.Logger;
@@ -98,7 +93,7 @@ public class ProgramConfigTest
                 @Override
                 public void execute(EventTrigger trigger, EventState<?> state, long timestamp)
                 {
-                    System.out.println(counter.incrementAndGet());
+                    counter.incrementAndGet();
                 }
             };
         JMXMonitor.addMonitorActions(action);
@@ -121,7 +116,6 @@ public class ProgramConfigTest
          }
         gate.await();
         JMXMonitor.removeMonitorActions(action);
-        assertTrue(true);
     }
 
     protected static void runTest(String requestUrl, long count)

From 5c08b066224505403f10c69acc85ad5416fa4a96 Mon Sep 17 00:00:00 2001
From: Greg Wilkins <gregw@webtide.com>
Date: Mon, 23 Jan 2012 10:19:08 +1100
Subject: [PATCH 03/10] improved test

---
 .../org/eclipse/jetty/util/DateCacheTest.java | 27 ++++++++++++++-----
 1 file changed, 21 insertions(+), 6 deletions(-)

diff --git a/jetty-util/src/test/java/org/eclipse/jetty/util/DateCacheTest.java b/jetty-util/src/test/java/org/eclipse/jetty/util/DateCacheTest.java
index 15284fd2493..76a061dbe1c 100644
--- a/jetty-util/src/test/java/org/eclipse/jetty/util/DateCacheTest.java
+++ b/jetty-util/src/test/java/org/eclipse/jetty/util/DateCacheTest.java
@@ -15,6 +15,7 @@ package org.eclipse.jetty.util;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
 
 import java.util.Locale;
 import java.util.TimeZone;
@@ -69,12 +70,26 @@ public class DateCacheTest
 
             // Test string is cached
             dc = new DateCache();
-            String s1=dc.format(System.currentTimeMillis());
-            dc.format(1);
-            String s2=dc.format(System.currentTimeMillis());
-            dc.format(System.currentTimeMillis()+10*60*60);
-            String s3=dc.format(System.currentTimeMillis());
-            assertTrue(s1==s2 || s2==s3);
+            long now = 1000L*(System.currentTimeMillis()%1000L)+123;
+            // format a time for now
+            String s1=dc.format(now);
+            
+            // format a  time in the past (this should not reset cached date)
+            dc.format(now-2000);
+            
+            // format a time a little later than now 
+            String s2=dc.format(now+10);
+            
+            // format a time  in future (this should reset cached data)
+            dc.format(now+2000);
+            
+            // format time a little later than now
+            String s3=dc.format(now+20);
+            
+            assertEquals(s1,s2);
+            assertEquals(s2,s3);
+            assertTrue(s1==s2);
+            assertFalse(s2==s3);
     }
 
 }

From bc5ac3622aa39b6e60b96ab24b0fb11c09535172 Mon Sep 17 00:00:00 2001
From: Greg Wilkins <gregw@webtide.com>
Date: Mon, 23 Jan 2012 13:13:28 +1100
Subject: [PATCH 04/10] 369349 replace quotes with a space escape method

---
 .../java/org/eclipse/jetty/start/Main.java    | 27 ++++++++++---------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/jetty-start/src/main/java/org/eclipse/jetty/start/Main.java b/jetty-start/src/main/java/org/eclipse/jetty/start/Main.java
index 34715f9a7bd..a221c34eb60 100644
--- a/jetty-start/src/main/java/org/eclipse/jetty/start/Main.java
+++ b/jetty-start/src/main/java/org/eclipse/jetty/start/Main.java
@@ -664,39 +664,40 @@ public class Main
         StringBuilder cmd = new StringBuilder();
         cmd.append(findJavaBin());
         for (String x : _jvmArgs) {
-            cmd.append(" \"").append(x).append("\"");
+            cmd.append(x);
         }
-        cmd.append(" \"-Djetty.home=").append(_jettyHome).append("\"");
+        cmd.append(" -Djetty.home=").append(escapeSpaces(_jettyHome));
         for (String p : _sysProps)
         {
-            cmd.append("  \"-D").append(p);
+            cmd.append("  -D").append(p);
             String v = System.getProperty(p);
             if (v != null && v.length() > 0)
-                cmd.append('=').append(v);
-            cmd.append("\"");
+                cmd.append("=").append(escapeSpaces(v));
         }
-        cmd.append("   -cp \"").append(classpath.toString()).append("\"");
-        cmd.append("   ").append(_config.getMainClassname());
+        cmd.append(" -cp ").append(classpath.toString());
+        cmd.append("  ").append(_config.getMainClassname());
 
         // Check if we need to pass properties as a file
         Properties properties = Config.getProperties();
         if (properties.size() > 0)
         {
             File prop_file = File.createTempFile("start",".properties");
-            if (!_dryRun) {
+            if (!_dryRun)
                 prop_file.deleteOnExit();
-            }
             properties.store(new FileOutputStream(prop_file),"start.jar properties");
-            cmd.append(" \"").append(prop_file.getAbsolutePath()).append("\"");
+            cmd.append(" ").append(escapeSpaces(prop_file.getAbsolutePath()));
         }
 
         for (String xml : xmls)
-        {
-            cmd.append(" \"").append(xml).append("\"");
-        }
+            cmd.append(" ").append(escapeSpaces(xml));
 
         return cmd.toString();
     }
+    
+    private static String escapeSpaces(String s)
+    {
+        return s.replace(" ","\\ ");
+    }
 
     private String findJavaBin()
     {

From ae5ddb2930ac2e247047e0c51f83a8b94f94353f Mon Sep 17 00:00:00 2001
From: Greg Wilkins <gregw@webtide.com>
Date: Mon, 23 Jan 2012 14:31:25 +1100
Subject: [PATCH 05/10] 369216 turned off the shared resource cache

---
 jetty-webapp/src/main/config/etc/webdefault.xml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/jetty-webapp/src/main/config/etc/webdefault.xml b/jetty-webapp/src/main/config/etc/webdefault.xml
index 99ee5feda99..213138b35fe 100644
--- a/jetty-webapp/src/main/config/etc/webdefault.xml
+++ b/jetty-webapp/src/main/config/etc/webdefault.xml
@@ -157,10 +157,12 @@
       <param-name>useFileMappedBuffer</param-name>
       <param-value>true</param-value>
     </init-param>
+    <!--
     <init-param>
       <param-name>resourceCache</param-name>
       <param-value>resourceCache</param-value>
     </init-param>
+    -->
     <!--
     <init-param>
       <param-name>cacheControl</param-name>

From 067e3f17cbcf18228b2073bc6c963148086d2bac Mon Sep 17 00:00:00 2001
From: Greg Wilkins <gregw@webtide.com>
Date: Mon, 23 Jan 2012 16:58:29 +1100
Subject: [PATCH 06/10] avoid NPE with jdk 7u4ea8 changed behaviour of
 SslContext init

---
 .../jetty/server/HttpServerTestFixture.java   | 14 --------
 .../jetty/server/ssl/SSLEngineTest.java       | 32 ++++--------------
 .../ssl/SelectChannelServerSslTest.java       |  2 +-
 .../jetty/server/ssl/SslRenegotiateTest.java  | 18 +---------
 .../org/eclipse/jetty/util/log/StdErrLog.java | 10 ++++--
 .../jetty/util/ssl/SslContextFactory.java     | 33 ++++++++++---------
 .../test/support/rawhttp/HttpsSocketImpl.java | 23 ++-----------
 7 files changed, 34 insertions(+), 98 deletions(-)

diff --git a/jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestFixture.java b/jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestFixture.java
index 09e1970c3e9..607c271abe7 100644
--- a/jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestFixture.java
+++ b/jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestFixture.java
@@ -188,20 +188,6 @@ public class HttpServerTestFixture
         }
     }
 
-    // Create a trust manager that does not validate certificate chains
-    public final static TrustManager[] __trustAllCerts = new TrustManager[] { 
-        new X509TrustManager(){     
-            public java.security.cert.X509Certificate[] getAcceptedIssuers() { 
-                return null;
-            } 
-            public void checkClientTrusted( 
-                java.security.cert.X509Certificate[] certs, String authType) {
-                } 
-            public void checkServerTrusted( 
-                java.security.cert.X509Certificate[] certs, String authType) {
-            }
-        } 
-    };
     
     public final static HostnameVerifier __hostnameverifier = new HostnameVerifier()
     {
diff --git a/jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SSLEngineTest.java b/jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SSLEngineTest.java
index c0d39e2bf22..2fcb497d05f 100644
--- a/jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SSLEngineTest.java
+++ b/jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SSLEngineTest.java
@@ -20,7 +20,8 @@ package org.eclipse.jetty.server.ssl;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertThat;
+import static org.hamcrest.Matchers.greaterThan;
 
 import java.io.BufferedReader;
 import java.io.IOException;
@@ -37,8 +38,6 @@ import javax.net.ssl.HostnameVerifier;
 import javax.net.ssl.HttpsURLConnection;
 import javax.net.ssl.SSLContext;
 import javax.net.ssl.SSLSession;
-import javax.net.ssl.TrustManager;
-import javax.net.ssl.X509TrustManager;
 import javax.servlet.ServletException;
 import javax.servlet.ServletOutputStream;
 import javax.servlet.http.HttpServletRequest;
@@ -81,25 +80,6 @@ public class SSLEngineTest
 
     private static final int BODY_SIZE=300;
 
-    private static final TrustManager[] s_dummyTrustManagers=new TrustManager[]
-    {
-        new X509TrustManager()
-        {
-            public java.security.cert.X509Certificate[] getAcceptedIssuers()
-            {
-                return null;
-            }
-
-            public void checkClientTrusted(java.security.cert.X509Certificate[] certs, String authType)
-            {
-            }
-
-            public void checkServerTrusted(java.security.cert.X509Certificate[] certs, String authType)
-            {
-            }
-        }
-    };
-
     private static Server server;
     private static SslSelectChannelConnector connector;
 
@@ -134,7 +114,7 @@ public class SSLEngineTest
     public void testBigResponse() throws Exception
     {
         SSLContext ctx=SSLContext.getInstance("TLS");
-        ctx.init(null,s_dummyTrustManagers,new java.security.SecureRandom());
+        ctx.init(null,SslContextFactory.TRUST_ALL_CERTS,new java.security.SecureRandom());
 
         int port=connector.getLocalPort();
 
@@ -152,7 +132,7 @@ public class SSLEngineTest
 
         String response = IO.toString(client.getInputStream());
 
-        assertTrue(response.length()>102400);
+        assertThat(response.length(),greaterThan(102400));
     }
 
     @Test
@@ -164,7 +144,7 @@ public class SSLEngineTest
         Socket[] client=new Socket[numConns];
 
         SSLContext ctx=SSLContext.getInstance("SSLv3");
-        ctx.init(null,s_dummyTrustManagers,new java.security.SecureRandom());
+        ctx.init(null,SslContextFactory.TRUST_ALL_CERTS,new java.security.SecureRandom());
 
         int port=connector.getLocalPort();
 
@@ -231,7 +211,7 @@ public class SSLEngineTest
         server.start();
 
         SSLContext context = SSLContext.getInstance("SSL");
-        context.init(null,s_dummyTrustManagers,new java.security.SecureRandom());
+        context.init(null,SslContextFactory.TRUST_ALL_CERTS,new java.security.SecureRandom());
         HttpsURLConnection.setDefaultSSLSocketFactory(context.getSocketFactory());
 
         URL url = new URL("https://localhost:"+connector.getLocalPort()+"/test");
diff --git a/jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SelectChannelServerSslTest.java b/jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SelectChannelServerSslTest.java
index a7424b99497..2c219cc0f89 100644
--- a/jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SelectChannelServerSslTest.java
+++ b/jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SelectChannelServerSslTest.java
@@ -73,7 +73,7 @@ public class SelectChannelServerSslTest extends HttpServerTestBase
         {
             HttpsURLConnection.setDefaultHostnameVerifier(__hostnameverifier);
             SSLContext sc = SSLContext.getInstance("TLS"); 
-            sc.init(null, __trustAllCerts, new java.security.SecureRandom()); 
+            sc.init(null, SslContextFactory.TRUST_ALL_CERTS, new java.security.SecureRandom()); 
             HttpsURLConnection.setDefaultSSLSocketFactory(sc.getSocketFactory());
         }
         catch(Exception e)
diff --git a/jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SslRenegotiateTest.java b/jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SslRenegotiateTest.java
index 69a96818d45..a38967f164c 100644
--- a/jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SslRenegotiateTest.java
+++ b/jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SslRenegotiateTest.java
@@ -37,22 +37,6 @@ public class SslRenegotiateTest
 {
     private static final Logger LOG = Log.getLogger(SslRenegotiateTest.class);
 
-    private static final TrustManager[] trustAllCerts = new TrustManager[] { new X509TrustManager()
-    {
-        public java.security.cert.X509Certificate[] getAcceptedIssuers()
-        {
-            return null;
-        }
-
-        public void checkClientTrusted( java.security.cert.X509Certificate[] certs, String authType )
-        {
-        }
-
-        public void checkServerTrusted( java.security.cert.X509Certificate[] certs, String authType )
-        {
-        }
-    } };
-
     private ByteBuffer _outAppB;
     private ByteBuffer _outPacketB;
     private ByteBuffer _inAppB;
@@ -110,7 +94,7 @@ public class SslRenegotiateTest
             _socket.configureBlocking(true);
 
             SSLContext context=SSLContext.getInstance("SSL");
-            context.init( null, trustAllCerts, new java.security.SecureRandom() );
+            context.init( null, SslContextFactory.TRUST_ALL_CERTS, new java.security.SecureRandom() );
 
             _engine = context.createSSLEngine();
             _engine.setUseClientMode(true);
diff --git a/jetty-util/src/main/java/org/eclipse/jetty/util/log/StdErrLog.java b/jetty-util/src/main/java/org/eclipse/jetty/util/log/StdErrLog.java
index 4e628333566..10ff80a4e91 100644
--- a/jetty-util/src/main/java/org/eclipse/jetty/util/log/StdErrLog.java
+++ b/jetty-util/src/main/java/org/eclipse/jetty/util/log/StdErrLog.java
@@ -37,7 +37,7 @@ public class StdErrLog extends AbstractLogger
 {
     private static final String EOL = System.getProperty("line.separator");
     private static DateCache _dateCache;
-    private static Properties __props = Log.__props;
+    private static final Properties __props = new Properties();
 
     private final static boolean __source = Boolean.parseBoolean(Log.__props.getProperty("org.eclipse.jetty.util.log.SOURCE",
             Log.__props.getProperty("org.eclipse.jetty.util.log.stderr.SOURCE","false")));
@@ -45,6 +45,8 @@ public class StdErrLog extends AbstractLogger
 
     static
     {
+        __props.putAll(Log.__props);
+        
         String deprecatedProperties[] =
         { "DEBUG", "org.eclipse.jetty.util.log.DEBUG", "org.eclipse.jetty.util.log.stderr.DEBUG" };
 
@@ -97,7 +99,8 @@ public class StdErrLog extends AbstractLogger
 
     public StdErrLog(String name, Properties props)
     {
-        __props = props;
+        if (props!=null)
+            __props.putAll(props);
         this._name = name == null?"":name;
         this._abbrevname = condensePackageString(this._name);
         this._level = getLoggingLevel(props,this._name);
@@ -603,7 +606,8 @@ public class StdErrLog extends AbstractLogger
 
     public static void setProperties(Properties props)
     {
-        __props = props;
+        __props.clear();
+        __props.putAll(props);
     }
 
     public void ignore(Throwable ignored)
diff --git a/jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslContextFactory.java b/jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslContextFactory.java
index 94c0d93cf65..9ad2cb0dd49 100644
--- a/jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslContextFactory.java
+++ b/jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslContextFactory.java
@@ -71,6 +71,22 @@ import org.eclipse.jetty.util.security.Password;
  */
 public class SslContextFactory extends AbstractLifeCycle
 {
+    public final static TrustManager[] TRUST_ALL_CERTS = new X509TrustManager[]{new X509TrustManager()
+    {
+        public java.security.cert.X509Certificate[] getAcceptedIssuers()
+        {
+            return new java.security.cert.X509Certificate[]{};
+        }
+
+        public void checkClientTrusted(java.security.cert.X509Certificate[] certs, String authType)
+        {
+        }
+
+        public void checkServerTrusted(java.security.cert.X509Certificate[] certs, String authType)
+        {
+        }
+    }};
+    
     private static final Logger LOG = Log.getLogger(SslContextFactory.class);
 
     public static final String DEFAULT_KEYMANAGERFACTORY_ALGORITHM =
@@ -229,22 +245,7 @@ public class SslContextFactory extends AbstractLifeCycle
                 {
                     LOG.debug("No keystore or trust store configured.  ACCEPTING UNTRUSTED CERTIFICATES!!!!!");
                     // Create a trust manager that does not validate certificate chains
-                    TrustManager trustAllCerts = new X509TrustManager()
-                    {
-                        public java.security.cert.X509Certificate[] getAcceptedIssuers()
-                        {
-                            return null;
-                        }
-
-                        public void checkClientTrusted(java.security.cert.X509Certificate[] certs, String authType)
-                        {
-                        }
-
-                        public void checkServerTrusted(java.security.cert.X509Certificate[] certs, String authType)
-                        {
-                        }
-                    };
-                    trust_managers = new TrustManager[] { trustAllCerts };
+                    trust_managers = TRUST_ALL_CERTS;
                 }
 
                 SecureRandom secureRandom = (_secureRandomAlgorithm == null)?null:SecureRandom.getInstance(_secureRandomAlgorithm);
diff --git a/tests/test-integration/src/test/java/org/eclipse/jetty/test/support/rawhttp/HttpsSocketImpl.java b/tests/test-integration/src/test/java/org/eclipse/jetty/test/support/rawhttp/HttpsSocketImpl.java
index 332aa4fed39..705314dd10d 100644
--- a/tests/test-integration/src/test/java/org/eclipse/jetty/test/support/rawhttp/HttpsSocketImpl.java
+++ b/tests/test-integration/src/test/java/org/eclipse/jetty/test/support/rawhttp/HttpsSocketImpl.java
@@ -32,6 +32,7 @@ import javax.net.ssl.X509TrustManager;
 
 import org.eclipse.jetty.util.log.Log;
 import org.eclipse.jetty.util.log.Logger;
+import org.eclipse.jetty.util.ssl.SslContextFactory;
 
 /**
  * An HTTPS Socket Impl
@@ -45,26 +46,6 @@ public class HttpsSocketImpl implements HttpSocket
 
     public HttpsSocketImpl() throws Exception
     {
-        // Create loose SSL context.
-        // Create a trust manager that does not validate certificate
-        // chains
-        TrustManager[] trustAllCerts = new TrustManager[]
-        { new X509TrustManager()
-        {
-            public java.security.cert.X509Certificate[] getAcceptedIssuers()
-            {
-                return null;
-            }
-
-            public void checkClientTrusted(java.security.cert.X509Certificate[] certs, String authType)
-            {
-            }
-
-            public void checkServerTrusted(java.security.cert.X509Certificate[] certs, String authType)
-            {
-            }
-        } };
-
         @SuppressWarnings("unused")
         HostnameVerifier hostnameVerifier = new HostnameVerifier()
         {
@@ -80,7 +61,7 @@ public class HttpsSocketImpl implements HttpSocket
         {
             // TODO real trust manager
             this.sslContext = SSLContext.getInstance("TLS");
-            sslContext.init(null,trustAllCerts,new java.security.SecureRandom());
+            sslContext.init(null,SslContextFactory.TRUST_ALL_CERTS,new java.security.SecureRandom());
         }
         catch (Exception e)
         {

From f3735fab7b5be3c08e83356f8135c0a7f93d9e18 Mon Sep 17 00:00:00 2001
From: Greg Wilkins <gregw@webtide.com>
Date: Tue, 24 Jan 2012 18:27:59 +1100
Subject: [PATCH 07/10] 368992 avoid update key while flushing during a write

---
 .../eclipse/jetty/io/nio/SelectChannelEndPoint.java    | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/nio/SelectChannelEndPoint.java b/jetty-io/src/main/java/org/eclipse/jetty/io/nio/SelectChannelEndPoint.java
index ffbcc163e12..9428a483a00 100644
--- a/jetty-io/src/main/java/org/eclipse/jetty/io/nio/SelectChannelEndPoint.java
+++ b/jetty-io/src/main/java/org/eclipse/jetty/io/nio/SelectChannelEndPoint.java
@@ -323,9 +323,8 @@ public class SelectChannelEndPoint extends ChannelEndPoint implements AsyncEndPo
         {
             synchronized (this)
             {
-                _writable=false;
-                if (!_dispatched)
-                    updateKey();
+                if (_dispatched)
+                    _writable=false;
             }
         }
         else if (l>0)
@@ -349,9 +348,8 @@ public class SelectChannelEndPoint extends ChannelEndPoint implements AsyncEndPo
         {
             synchronized (this)
             {
-                _writable=false;
-                if (!_dispatched)
-                    updateKey();
+                if (_dispatched)
+                    _writable=false;
             }
         }
         else if (l>0)

From caa325c3ba017abb8a6eb9823742558b7435e582 Mon Sep 17 00:00:00 2001
From: Simone Bordet <simone.bordet@gmail.com>
Date: Tue, 24 Jan 2012 21:21:43 +0100
Subject: [PATCH 08/10] Better check for WebSocket upgrades, since Connection
 headers may be of the form Connection: keep-alive, Upgrade.

---
 .../eclipse/jetty/servlets/CrossOriginFilter.java   | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CrossOriginFilter.java b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CrossOriginFilter.java
index 67c6e7c5fbd..e4242cc7e86 100644
--- a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CrossOriginFilter.java
+++ b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CrossOriginFilter.java
@@ -17,6 +17,7 @@ package org.eclipse.jetty.servlets;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -215,10 +216,16 @@ public class CrossOriginFilter implements Filter
     {
         // WebSocket clients such as Chrome 5 implement a version of the WebSocket
         // protocol that does not accept extra response headers on the upgrade response
-        if ("Upgrade".equalsIgnoreCase(request.getHeader("Connection")) &&
-            "WebSocket".equalsIgnoreCase(request.getHeader("Upgrade")))
+        for (String connection : Collections.<String>list(request.getHeaders("Connection")))
         {
-            return false;
+            if ("Upgrade".equalsIgnoreCase(connection))
+            {
+                for (String upgrade : Collections.<String>list(request.getHeaders("Upgrade")))
+                {
+                    if ("WebSocket".equalsIgnoreCase(upgrade))
+                        return false;
+                }
+            }
         }
         return true;
     }

From ee9e195b4938cb3b05d02c6739285b36ed5d40c3 Mon Sep 17 00:00:00 2001
From: Greg Wilkins <gregw@webtide.com>
Date: Wed, 25 Jan 2012 15:40:24 +1100
Subject: [PATCH 09/10] 369602: ignore NotUtf8Exception for decodeToUtf8

---
 .../org/eclipse/jetty/util/UrlEncoded.java    | 94 ++++++++++---------
 .../eclipse/jetty/util/Utf8Appendable.java    |  2 +-
 .../eclipse/jetty/util/URLEncodedTest.java    | 18 +++-
 3 files changed, 69 insertions(+), 45 deletions(-)

diff --git a/jetty-util/src/main/java/org/eclipse/jetty/util/UrlEncoded.java b/jetty-util/src/main/java/org/eclipse/jetty/util/UrlEncoded.java
index 06741c0a130..87b2f2e4a28 100644
--- a/jetty-util/src/main/java/org/eclipse/jetty/util/UrlEncoded.java
+++ b/jetty-util/src/main/java/org/eclipse/jetty/util/UrlEncoded.java
@@ -462,52 +462,60 @@ public class UrlEncoded extends MultiMap implements Cloneable
             int totalLength=0;
             while ((b=in.read())>=0)
             {
-                switch ((char) b)
+                try
                 {
-                    case '&':
-                        value = buffer.length()==0?"":buffer.toString();
-                        buffer.reset();
-                        if (key != null)
-                        {
-                            map.add(key,value);
-                        }
-                        else if (value!=null&&value.length()>0)
-                        {
-                            map.add(value,"");
-                        }
-                        key = null;
-                        value=null;
-                        if (maxKeys>0 && map.size()>maxKeys)
-                        {
-                            LOG.warn("maxFormKeys limit exceeded keys>{}",maxKeys);
-                            return;
-                        }
-                        break;
-                        
-                    case '=':
-                        if (key!=null)
-                        {
+                    switch ((char) b)
+                    {
+                        case '&':
+                            value = buffer.length()==0?"":buffer.toString();
+                            buffer.reset();
+                            if (key != null)
+                            {
+                                map.add(key,value);
+                            }
+                            else if (value!=null&&value.length()>0)
+                            {
+                                map.add(value,"");
+                            }
+                            key = null;
+                            value=null;
+                            if (maxKeys>0 && map.size()>maxKeys)
+                            {
+                                LOG.warn("maxFormKeys limit exceeded keys>{}",maxKeys);
+                                return;
+                            }
+                            break;
+
+                        case '=':
+                            if (key!=null)
+                            {
+                                buffer.append((byte)b);
+                                break;
+                            }
+                            key = buffer.toString();
+                            buffer.reset();
+                            break;
+
+                        case '+':
+                            buffer.append((byte)' ');
+                            break;
+
+                        case '%':
+                            int dh=in.read();
+                            int dl=in.read();
+                            if (dh<0||dl<0)
+                                break;
+                            buffer.append((byte)((TypeUtil.convertHexDigit((byte)dh)<<4) + TypeUtil.convertHexDigit((byte)dl)));
+                            break;
+                        default:
                             buffer.append((byte)b);
                             break;
-                        }
-                        key = buffer.toString();
-                        buffer.reset();
-                        break;
-                        
-                    case '+':
-                        buffer.append((byte)' ');
-                        break;
-                        
-                    case '%':
-                        int dh=in.read();
-                        int dl=in.read();
-                        if (dh<0||dl<0)
-                            break;
-                        buffer.append((byte)((TypeUtil.convertHexDigit((byte)dh)<<4) + TypeUtil.convertHexDigit((byte)dl)));
-                        break;
-                    default:
-                        buffer.append((byte)b);
-                    break;
+                    }
+                }
+                catch(NotUtf8Exception e)
+                {
+                    LOG.warn(e.toString());
+                    LOG.debug(e);
                 }
                 if (maxLength>=0 && (++totalLength > maxLength))
                     throw new IllegalStateException("Form too large");
diff --git a/jetty-util/src/main/java/org/eclipse/jetty/util/Utf8Appendable.java b/jetty-util/src/main/java/org/eclipse/jetty/util/Utf8Appendable.java
index 8fe840c1b88..de02cc4e3f4 100644
--- a/jetty-util/src/main/java/org/eclipse/jetty/util/Utf8Appendable.java
+++ b/jetty-util/src/main/java/org/eclipse/jetty/util/Utf8Appendable.java
@@ -40,7 +40,7 @@ import java.io.IOException;
  **/
 public abstract class Utf8Appendable
 {
-    private final char REPLACEMENT = '\ufffd';
+    public static final char REPLACEMENT = '\ufffd';
     private static final int UTF8_ACCEPT = 0;
     private static final int UTF8_REJECT = 12;
 
diff --git a/jetty-util/src/test/java/org/eclipse/jetty/util/URLEncodedTest.java b/jetty-util/src/test/java/org/eclipse/jetty/util/URLEncodedTest.java
index 42bba2b05bc..1678338df77 100644
--- a/jetty-util/src/test/java/org/eclipse/jetty/util/URLEncodedTest.java
+++ b/jetty-util/src/test/java/org/eclipse/jetty/util/URLEncodedTest.java
@@ -220,7 +220,6 @@ public class URLEncodedTest
         */ 
     }
     
-
     /* -------------------------------------------------------------- */
     @Test
     public void testUtf8()
@@ -236,4 +235,21 @@ public class URLEncodedTest
         String expected = new String(TypeUtil.fromHexString(hex),"utf-8");
         assertEquals(expected,url_encoded.get("text"));
     }
+    
+    /* -------------------------------------------------------------- */
+    @Test
+    public void testNotUtf8() throws Exception
+    {   
+        String query="name=X%c0%afZ";
+        
+        MultiMap<String> map = new MultiMap<String>();
+        
+        UrlEncoded.decodeUtf8To(query.getBytes(StringUtil.__ISO_8859_1),0,query.length(),map);
+        assertEquals("X"+Utf8Appendable.REPLACEMENT+Utf8Appendable.REPLACEMENT+"Z",map.getValue("name",0));
+
+        map.clear();
+
+        UrlEncoded.decodeUtf8To(new ByteArrayInputStream(query.getBytes(StringUtil.__ISO_8859_1)),map,100,2);
+        assertEquals("X"+Utf8Appendable.REPLACEMENT+Utf8Appendable.REPLACEMENT+"Z",map.getValue("name",0));
+    }
 }

From f0a064b624e5307b649d0543a1dd403ff88dfa95 Mon Sep 17 00:00:00 2001
From: Simone Bordet <simone.bordet@gmail.com>
Date: Wed, 25 Jan 2012 15:18:50 +0100
Subject: [PATCH 10/10] Fixed compilation problem.

---
 .../org/eclipse/jetty/servlets/CrossOriginFilter.java     | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CrossOriginFilter.java b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CrossOriginFilter.java
index e4242cc7e86..bb57608c4b4 100644
--- a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CrossOriginFilter.java
+++ b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CrossOriginFilter.java
@@ -17,7 +17,7 @@ package org.eclipse.jetty.servlets;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.Collections;
+import java.util.Enumeration;
 import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -216,12 +216,14 @@ public class CrossOriginFilter implements Filter
     {
         // WebSocket clients such as Chrome 5 implement a version of the WebSocket
         // protocol that does not accept extra response headers on the upgrade response
-        for (String connection : Collections.<String>list(request.getHeaders("Connection")))
+        for (Enumeration connections = request.getHeaders("Connection"); connections.hasMoreElements();)
         {
+            String connection = (String)connections.nextElement();
             if ("Upgrade".equalsIgnoreCase(connection))
             {
-                for (String upgrade : Collections.<String>list(request.getHeaders("Upgrade")))
+                for (Enumeration upgrades = request.getHeaders("Upgrade"); upgrades.hasMoreElements();)
                 {
+                    String upgrade = (String)upgrades.nextElement();
                     if ("WebSocket".equalsIgnoreCase(upgrade))
                         return false;
                 }