From 5d8780cb4e55ad3d6064d25de26e9aa29caf919d Mon Sep 17 00:00:00 2001 From: Greg Wilkins Date: Mon, 28 Jul 2014 15:27:40 +1000 Subject: [PATCH] Record some TODOs --- .../jetty/http2/server/HTTP2ServerConnectionFactory.java | 2 ++ .../org/eclipse/jetty/http2/server/HttpChannelOverHTTP2.java | 2 +- .../src/main/java/org/eclipse/jetty/server/Request.java | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/jetty-http2/http2-server/src/main/java/org/eclipse/jetty/http2/server/HTTP2ServerConnectionFactory.java b/jetty-http2/http2-server/src/main/java/org/eclipse/jetty/http2/server/HTTP2ServerConnectionFactory.java index 29abe5fe40a..22a44885926 100644 --- a/jetty-http2/http2-server/src/main/java/org/eclipse/jetty/http2/server/HTTP2ServerConnectionFactory.java +++ b/jetty-http2/http2-server/src/main/java/org/eclipse/jetty/http2/server/HTTP2ServerConnectionFactory.java @@ -95,6 +95,8 @@ public class HTTP2ServerConnectionFactory extends AbstractHTTP2ServerConnectionF HttpTransportOverHTTP2 transport = new HttpTransportOverHTTP2((IStream)stream, frame); HttpInputOverHTTP2 input = new HttpInputOverHTTP2(); + + // TODO pool HttpChannels per connection - maybe associate with thread? HttpChannelOverHTTP2 channel = new HttpChannelOverHTTP2(connector, httpConfiguration, endPoint, transport, input, stream); stream.setAttribute(CHANNEL_ATTRIBUTE, channel); diff --git a/jetty-http2/http2-server/src/main/java/org/eclipse/jetty/http2/server/HttpChannelOverHTTP2.java b/jetty-http2/http2-server/src/main/java/org/eclipse/jetty/http2/server/HttpChannelOverHTTP2.java index 900736f7f38..2e0f6122c01 100644 --- a/jetty-http2/http2-server/src/main/java/org/eclipse/jetty/http2/server/HttpChannelOverHTTP2.java +++ b/jetty-http2/http2-server/src/main/java/org/eclipse/jetty/http2/server/HttpChannelOverHTTP2.java @@ -45,7 +45,7 @@ public class HttpChannelOverHTTP2 extends HttpChannel private static final HttpField ACCEPT_ENCODING_GZIP = new HttpField(HttpHeader.ACCEPT_ENCODING,"gzip"); private static final HttpField SERVER_VERSION=new HttpField(HttpHeader.SERVER,HttpConfiguration.SERVER_VERSION); private static final HttpField POWERED_BY=new HttpField(HttpHeader.X_POWERED_BY,HttpConfiguration.SERVER_VERSION); - private final Stream stream; + private final Stream stream; // TODO recycle channel for new Stream? public HttpChannelOverHTTP2(Connector connector, HttpConfiguration configuration, EndPoint endPoint, HttpTransport transport, HttpInput input, Stream stream) { diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/Request.java b/jetty-server/src/main/java/org/eclipse/jetty/server/Request.java index 43bc0f2dc1e..4b1c23d4929 100644 --- a/jetty-server/src/main/java/org/eclipse/jetty/server/Request.java +++ b/jetty-server/src/main/java/org/eclipse/jetty/server/Request.java @@ -149,7 +149,7 @@ public class Request implements HttpServletRequest private boolean _handled = false; private boolean _paramsExtracted; private boolean _requestedSessionIdFromCookie = false; - private volatile Attributes _attributes; + private Attributes _attributes; private Authentication _authentication; private String _characterEncoding; private ContextHandler.Context _context;