Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add comments to session implemention code

This commit is contained in:
Jan Bartel 2016-02-23 13:46:38 +01:00
parent c52c8304d8
commit 750b74ad49
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
jetty-server/src/main/java/org/eclipse/jetty/server/session/AbstractSessionIdManager.java
View File

@ -351,7 +351,15 @@ public abstract class AbstractSessionIdManager extends AbstractLifeCycle impleme
if (LOG.isDebugEnabled())
LOG.debug("Expiring {}",id);
//take the id out of the list of known sessionids for this node
//TODO handle cases:
//1. infinispan session id manager may not be able to remove id because it has timed out in infinispan but yet
//we want to remove a session object from the session store (session data store probably ok because it has same timeout as session id mgr entries)
//2. a session id manager may not know all session ids (ie subset in memory only) and therefore won't remove
//it, but it should be removed from the session data store (could it be in session store?)
//3. old sessions that no node is handling, eg after all restarted, but need to be removed from
//session data store, AND have listeners called on them.
//BUT want to avoid loading into memory sessions that this node is not managing (eg have 3 nodes all running session mgrs,
//all 3 find the expired session and load it into memory and expire it
if (removeId(id))
{
//tell all contexts that may have a session object with this id to

4
jetty-server/src/main/java/org/eclipse/jetty/server/session/JDBCSessionDataStore.java
View File

@ -867,11 +867,11 @@ public class JDBCSessionDataStore extends AbstractSessionDataStore
connection.setAutoCommit(true);
/*
* 1. Select sessions for our node and context that have expired
* 1. Select sessions for our context that have expired
*/
long upperBound = now;
if (LOG.isDebugEnabled())
LOG.debug ("{}- Pass 1: Searching for sessions for node {} and context {} expired before {}", _context.getWorkerName(), _context.getCanonicalContextPath(), upperBound);
LOG.debug ("{}- Pass 1: Searching for sessions for context {} expired before {}", _context.getWorkerName(), _context.getCanonicalContextPath(), upperBound);
try (PreparedStatement statement = _sessionTableSchema.getMyExpiredSessionsStatement(connection, _context.getCanonicalContextPath(), _context.getVhost(), upperBound))
{