From 78a775396eb9524152f3392afabccffda7c79201 Mon Sep 17 00:00:00 2001
From: Greg Wilkins <gregw@webtide.com>
Date: Tue, 13 Nov 2018 16:52:04 +0100
Subject: [PATCH] Issue #3103 delay setting transport.setHttpClient until late
 in doStart Do not add DumpableCollection as a bean

Signed-off-by: Greg Wilkins <gregw@webtide.com>
---
 .../main/java/org/eclipse/jetty/client/HttpClient.java | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java b/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java
index 5fb4b861360..0ffe40925db 100644
--- a/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java
+++ b/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java
@@ -18,6 +18,7 @@
 
 package org.eclipse.jetty.client;
 
+import java.io.IOException;
 import java.net.CookieManager;
 import java.net.CookiePolicy;
 import java.net.CookieStore;
@@ -180,7 +181,6 @@ public class HttpClient extends ContainerLifeCycle
     public HttpClient(HttpClientTransport transport, SslContextFactory sslContextFactory)
     {
         this.transport = transport;
-        transport.setHttpClient(this);
         addBean(transport);
 
         if (sslContextFactory == null)
@@ -192,7 +192,12 @@ public class HttpClient extends ContainerLifeCycle
         addBean(sslContextFactory);
         addBean(handlers);
         addBean(decoderFactories);
-        addBean(new DumpableCollection("requestListeners", requestListeners));
+    }
+
+    @Override
+    public void dump(Appendable out, String indent) throws IOException
+    {
+        dumpObjects(out, indent, new DumpableCollection("requestListeners", requestListeners));
     }
 
     public HttpClientTransport getTransport()
@@ -241,6 +246,7 @@ public class HttpClient extends ContainerLifeCycle
         cookieManager = newCookieManager();
         cookieStore = cookieManager.getCookieStore();
 
+        transport.setHttpClient(this);
         super.doStart();
     }