From 849d51c07dd0c8fcb688aff3a069b6ad29e4897c Mon Sep 17 00:00:00 2001 From: Greg Wilkins Date: Fri, 22 Jul 2016 09:52:52 +1000 Subject: [PATCH] Issue #752 - Implement support for HTTP2 SETTINGS_MAX_HEADER_LIST_SIZE. Reverted to warning if a small SETTINGS_MAX_HEADER_LIST_SIZE. is received. Setting it on the httpConfig effects all connections, not just the one the setting was received from. --- .../jetty/http2/server/HTTP2ServerConnectionFactory.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jetty-http2/http2-server/src/main/java/org/eclipse/jetty/http2/server/HTTP2ServerConnectionFactory.java b/jetty-http2/http2-server/src/main/java/org/eclipse/jetty/http2/server/HTTP2ServerConnectionFactory.java index b2c6be75869..69f8c7fcd1b 100644 --- a/jetty-http2/http2-server/src/main/java/org/eclipse/jetty/http2/server/HTTP2ServerConnectionFactory.java +++ b/jetty-http2/http2-server/src/main/java/org/eclipse/jetty/http2/server/HTTP2ServerConnectionFactory.java @@ -107,7 +107,7 @@ public class HTTP2ServerConnectionFactory extends AbstractHTTP2ServerConnectionF HttpConfiguration httpConfig = getHttpConfiguration(); Integer mhls = frame.getSettings().get(SettingsFrame.MAX_HEADER_LIST_SIZE); if (mhls != null && mhls < httpConfig.getResponseHeaderSize()) - httpConfig.setResponseHeaderSize(mhls); + LOG.warn("MAX_HEADER_LIST_SIZE<{} for {}",getHttpConfiguration().getResponseHeaderSize(),session); } @Override