Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue #5605 - Adding more comments 

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
This commit is contained in:
Joakim Erdfelt 2020-11-19 10:24:36 -06:00
parent a6d432e9e3
commit 901a17d197
No known key found for this signature in database
GPG Key ID: 2D0E1FB8FE4B68B4
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tests/test-integration/src/test/java/org/eclipse/jetty/test/GzipWithSendErrorTest.java
View File

@ -220,8 +220,15 @@ public class GzipWithSendErrorTest
compressedRequest = out.toByteArray();
}
// We want to write a request with request body content size / length
// that will exceed the various buffers in the network, the client, the server,
// etc.
int sizeActuallySent = compressedRequest.length / 2;
ByteBuffer start = ByteBuffer.wrap(compressedRequest, 0, sizeActuallySent);
// Using deferred content to allow us to write SOME of the request body content
// but not all of it (yet)
// We override the getLength to ensure that Content-Length is used.
DeferredContentProvider contentProvider = new DeferredContentProvider(start)
{
@Override
@ -250,6 +257,7 @@ public class GzipWithSendErrorTest
Response response = clientResponseRef.get();
assertEquals(400, response.getStatus(), "Response status on /fail");
// We expect the server to set `Connection: close`, as the request body content isn't fully sent (yet)
assertEquals("close", response.getHeaders().get(HttpHeader.CONNECTION), "Response Connection header");
// Await for server side to complete the request
@ -270,7 +278,7 @@ public class GzipWithSendErrorTest
assertThat("Request Connection BytesIn should have some minimal data", inputBytesIn.get(), greaterThanOrEqualTo(1024L));
assertThat("Request Connection BytesIn read should not have read all of the data", inputBytesIn.get(), lessThanOrEqualTo((long)sizeActuallySent));
// Now provide rest
// Now use the deferred content to complete writing of the request body content
contentProvider.offer(ByteBuffer.wrap(compressedRequest, sizeActuallySent, compressedRequest.length - sizeActuallySent));
contentProvider.close();
@ -334,8 +342,15 @@ public class GzipWithSendErrorTest
compressedRequest = out.toByteArray();
}
// We want to write a request with request body content size / length
// that will exceed the various buffers in the network, the client, the server,
// etc.
int sizeActuallySent = compressedRequest.length / 2;
ByteBuffer start = ByteBuffer.wrap(compressedRequest, 0, sizeActuallySent);
// Using deferred content to allow us to write SOME of the request body content
// but not all of it (yet)
DeferredContentProvider contentProvider = new DeferredContentProvider(start);
AtomicReference<Response> clientResponseRef = new AtomicReference<>();
CountDownLatch clientResponseSuccessLatch = new CountDownLatch(1);
@ -359,6 +374,7 @@ public class GzipWithSendErrorTest
Response response = clientResponseRef.get();
assertEquals(400, response.getStatus(), "Response status on /fail");
// We expect the server to set `Connection: close`, as the request body content isn't fully sent (yet)
assertEquals("close", response.getHeaders().get(HttpHeader.CONNECTION), "Response Connection header");
// Await for server side to complete the request
@ -381,7 +397,7 @@ public class GzipWithSendErrorTest
assertThat("Request Connection BytesIn should have some minimal data", inputBytesIn.get(), greaterThanOrEqualTo(1024L));
assertThat("Request Connection BytesIn read should not have read all of the data", inputBytesIn.get(), lessThanOrEqualTo((long)sizeActuallySent));
// Now provide rest
// Now use the deferred content to complete writing of the request body content
contentProvider.offer(ByteBuffer.wrap(compressedRequest, sizeActuallySent, compressedRequest.length - sizeActuallySent));
contentProvider.close();