Eclipse/jetty.project
1
0
Fork 0
mirror of https://github.com/jetty/jetty.project.git synced 2025-03-03 20:39:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Issue #4860 - Improving testPreventNullField testcase

Browse Source 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
This commit is contained in:
Joakim Erdfelt 2020-05-11 10:05:56 -05:00
parent 2c7c98f469
commit 90da10dac5
No known key found for this signature in database
GPG Key ID: 2D0E1FB8FE4B68B4
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
jetty-http/src/test/java/org/eclipse/jetty/http/HttpFieldsTest.java
View File

@ -700,20 +700,28 @@ public class HttpFieldsTest
public void testPreventNullField()
{
// Attempt various ways that may have put a null field in the array that
// previously caused a NPE in put. If this test doesn't throw then it passes.
// previously caused a NPE in put.
HttpFields fields = new HttpFields();
fields.add((HttpField)null);
fields.put(null);
fields.add((HttpField)null); // should not result in field being added
assertThat(fields.size(), is(0));
fields.put(null); // should not result in field being added
assertThat(fields.size(), is(0));
fields.put("something", "else");
assertThat(fields.size(), is(1));
ListIterator<HttpField> iter = fields.listIterator();
iter.next();
iter.set(null);
assertThat(fields.size(), is(0));
iter.add(null);
assertThat(fields.size(), is(0));
fields.put("something", "other");
assertThat(fields.size(), is(1));
iter = fields.listIterator();
iter.next();
iter.remove();
assertThat(fields.size(), is(0));
fields.put("something", "other");
assertThat(fields.size(), is(1));
fields.clear();
}