Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Trying to get more information about 400 response parse flaky test

This commit is contained in:
Joakim Erdfelt 2024-08-26 08:53:54 -05:00
parent 1d4a77472a
commit 94ea3694a2
No known key found for this signature in database
GPG Key ID: 2D0E1FB8FE4B68B4
1 changed files with 26 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/LargeHeaderTest.java
View File

@ -29,6 +29,7 @@ import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger; import java.util.concurrent.atomic.AtomicInteger;
import org.eclipse.jetty.http.BadMessageException;
import org.eclipse.jetty.http.HttpHeader; import org.eclipse.jetty.http.HttpHeader;
import org.eclipse.jetty.http.HttpTester; import org.eclipse.jetty.http.HttpTester;
import org.eclipse.jetty.http.MimeTypes; import org.eclipse.jetty.http.MimeTypes;
@ -36,6 +37,7 @@ import org.eclipse.jetty.util.BufferUtil;
import org.eclipse.jetty.util.Callback; import org.eclipse.jetty.util.Callback;
import org.eclipse.jetty.util.IO; import org.eclipse.jetty.util.IO;
import org.eclipse.jetty.util.NanoTime; import org.eclipse.jetty.util.NanoTime;
import org.eclipse.jetty.util.StringUtil;
import org.eclipse.jetty.util.component.LifeCycle; import org.eclipse.jetty.util.component.LifeCycle;
import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
@ -202,31 +204,39 @@ public class LargeHeaderTest
// String rawResponse = readResponse(client, count, input); // String rawResponse = readResponse(client, count, input);
String rawResponse = IO.toString(input, UTF_8); String rawResponse = IO.toString(input, UTF_8);
if (rawResponse.isEmpty()) if (StringUtil.isBlank(rawResponse))
{ {
LOG.warn("X-Count: {} - Empty Raw Response", count); LOG.warn("X-Count: {} - Empty Raw Response", count);
countEmpty.incrementAndGet(); countEmpty.incrementAndGet();
return null; return null;
} }
HttpTester.Response response = HttpTester.parseResponse(rawResponse); try
if (response == null)
{ {
LOG.warn("X-Count: {} - Null HttpTester.Response", count); HttpTester.Response response = HttpTester.parseResponse(rawResponse);
countEmpty.incrementAndGet(); if (response == null)
{
LOG.warn("X-Count: {} - Null HttpTester.Response", count);
countEmpty.incrementAndGet();
}
else if (response.getStatus() == 500)
{
// expected result
count500.incrementAndGet();
long contentLength = response.getLongField(HttpHeader.CONTENT_LENGTH);
String responseBody = response.getContent();
assertThat((long)responseBody.length(), is(contentLength));
}
else
{
LOG.warn("X-Count: {} - Unexpected Status Code: {}", count, response.getStatus());
countOther.incrementAndGet();
}
} }
else if (response.getStatus() == 500) catch (BadMessageException bme)
{ {
// expected result System.err.printf("%n---[Response:%d]----%n%s%n----%n", rawResponse.length(), rawResponse);
count500.incrementAndGet(); LOG.warn("Failed Response Parse", bme);
long contentLength = response.getLongField(HttpHeader.CONTENT_LENGTH);
String responseBody = response.getContent();
assertThat((long)responseBody.length(), is(contentLength));
}
else
{
LOG.warn("X-Count: {} - Unexpected Status Code: {}", count, response.getStatus());
countOther.incrementAndGet();
} }
} }
catch (Throwable t) catch (Throwable t)