From 98e85ecb41c2d85821b6a70e925abb95e4284cf0 Mon Sep 17 00:00:00 2001
From: Greg Wilkins <gregw@intalio.com>
Date: Tue, 8 May 2012 15:46:41 +0200
Subject: [PATCH] jetty-9 EndPoint.close does not throw

---
 .../eclipse/jetty/io/AbstractAsyncConnection.java  | 10 +---------
 .../org/eclipse/jetty/io/ByteArrayEndPoint.java    |  2 +-
 .../java/org/eclipse/jetty/io/ChannelEndPoint.java | 14 +++++++++++---
 .../main/java/org/eclipse/jetty/io/EndPoint.java   |  2 +-
 .../eclipse/jetty/io/SelectChannelEndPoint.java    |  7 +++----
 .../java/org/eclipse/jetty/io/SelectorManager.java |  9 +--------
 .../java/org/eclipse/jetty/io/SslConnection.java   |  2 +-
 7 files changed, 19 insertions(+), 27 deletions(-)

diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/AbstractAsyncConnection.java b/jetty-io/src/main/java/org/eclipse/jetty/io/AbstractAsyncConnection.java
index 54f3338a43b..14fc0c810ea 100644
--- a/jetty-io/src/main/java/org/eclipse/jetty/io/AbstractAsyncConnection.java
+++ b/jetty-io/src/main/java/org/eclipse/jetty/io/AbstractAsyncConnection.java
@@ -42,15 +42,7 @@ public abstract class AbstractAsyncConnection
         catch(IOException e)
         {
             LOG.ignore(e);
-
-            try
-            {
-                _endp.close();
-            }
-            catch(IOException e2)
-            {
-                LOG.ignore(e2);
-            }
+            _endp.close();
         }
     }
         
diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/ByteArrayEndPoint.java b/jetty-io/src/main/java/org/eclipse/jetty/io/ByteArrayEndPoint.java
index 758ac3da3dd..804de0baf84 100644
--- a/jetty-io/src/main/java/org/eclipse/jetty/io/ByteArrayEndPoint.java
+++ b/jetty-io/src/main/java/org/eclipse/jetty/io/ByteArrayEndPoint.java
@@ -220,7 +220,7 @@ public class ByteArrayEndPoint extends AbstractEndPoint
      * @see org.eclipse.io.EndPoint#close()
      */
     @Override
-    public void close() throws IOException
+    public void close()
     {
         _closed=true;
     }
diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/ChannelEndPoint.java b/jetty-io/src/main/java/org/eclipse/jetty/io/ChannelEndPoint.java
index 505cf9ae38f..2703342aefe 100644
--- a/jetty-io/src/main/java/org/eclipse/jetty/io/ChannelEndPoint.java
+++ b/jetty-io/src/main/java/org/eclipse/jetty/io/ChannelEndPoint.java
@@ -121,10 +121,18 @@ public class ChannelEndPoint extends AbstractEndPoint
      * @see org.eclipse.io.EndPoint#close()
      */
     @Override
-    public void close() throws IOException
+    public void close()
     {
-        LOG.debug("close {}",this);
-        _channel.close();
+        try
+        {
+            LOG.debug("close {}",this);
+            _channel.close();
+        }
+        catch(IOException e)
+        {
+            LOG.warn(e.toString());
+            LOG.debug(e);
+        }
     }
 
     /* (non-Javadoc)
diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/EndPoint.java b/jetty-io/src/main/java/org/eclipse/jetty/io/EndPoint.java
index ea9cd25f701..fba6aa32639 100644
--- a/jetty-io/src/main/java/org/eclipse/jetty/io/EndPoint.java
+++ b/jetty-io/src/main/java/org/eclipse/jetty/io/EndPoint.java
@@ -79,7 +79,7 @@ public interface EndPoint
     /**
      * Close any backing stream associated with the endpoint
      */
-    void close() throws IOException;
+    void close();
 
     /**
      * Fill the passed buffer with data from this endpoint.  The bytes are appended to any 
diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/SelectChannelEndPoint.java b/jetty-io/src/main/java/org/eclipse/jetty/io/SelectChannelEndPoint.java
index 335134f9ad4..35b31771236 100644
--- a/jetty-io/src/main/java/org/eclipse/jetty/io/SelectChannelEndPoint.java
+++ b/jetty-io/src/main/java/org/eclipse/jetty/io/SelectChannelEndPoint.java
@@ -438,7 +438,7 @@ public class SelectChannelEndPoint extends ChannelEndPoint implements AsyncEndPo
      * @see org.eclipse.io.nio.ChannelEndPoint#close()
      */
     @Override
-    public void close() throws IOException
+    public void close()
     {
         _lock.lock();
         try
@@ -447,11 +447,10 @@ public class SelectChannelEndPoint extends ChannelEndPoint implements AsyncEndPo
             {
                 super.close();
             }
-            catch (IOException e)
+            finally
             {
-                LOG.ignore(e);
+                updateKey();
             }
-            updateKey();
         }
         finally
         {
diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/SelectorManager.java b/jetty-io/src/main/java/org/eclipse/jetty/io/SelectorManager.java
index 2d6e42feaae..97338789154 100644
--- a/jetty-io/src/main/java/org/eclipse/jetty/io/SelectorManager.java
+++ b/jetty-io/src/main/java/org/eclipse/jetty/io/SelectorManager.java
@@ -880,14 +880,7 @@ public abstract class SelectorManager extends AbstractLifeCycle implements Dumpa
                     if (att instanceof EndPoint)
                     {
                         EndPoint endpoint = (EndPoint)att;
-                        try
-                        {
-                            endpoint.close();
-                        }
-                        catch(IOException e)
-                        {
-                            LOG.ignore(e);
-                        }
+                        endpoint.close();
                     }
                 }
 
diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/SslConnection.java b/jetty-io/src/main/java/org/eclipse/jetty/io/SslConnection.java
index 057effd5060..e691ba1a2de 100644
--- a/jetty-io/src/main/java/org/eclipse/jetty/io/SslConnection.java
+++ b/jetty-io/src/main/java/org/eclipse/jetty/io/SslConnection.java
@@ -613,7 +613,7 @@ public class SslConnection extends AbstractAsyncConnection
         }
 
         @Override
-        public void close() throws IOException
+        public void close()
         {
             LOG.debug("{} ssl endp.close",_session);
             _endp.close();