Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes #1072 - InetAccessHandler needs InetAddress & Path based restrictions like IPAccessHandler did. 

Introduced isAllowed(InetAddress, HttpServletRequest) so that it
would be possible to make access decisions also based on request
information such as context, path, headers, etc.
This commit is contained in:
Simone Bordet 2016-11-07 16:20:15 +01:00
parent fe1aed24c0
commit 998c5729ec
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
jetty-server/src/main/java/org/eclipse/jetty/server/handler/InetAccessHandler.java
View File

@ -107,7 +107,7 @@ public class InetAccessHandler extends HandlerWrapper
if (endp != null)
{
InetSocketAddress address = endp.getRemoteAddress();
if (address != null && !isAllowed(address.getAddress()))
if (address != null && !isAllowed(address.getAddress(), request))
{
response.sendError(HttpStatus.FORBIDDEN_403);
baseRequest.setHandled(true);
@ -120,11 +120,21 @@ public class InetAccessHandler extends HandlerWrapper
}
/**
* Check sif specified address is allowed by current IPAccess rules.
* Checks if specified address and request are allowed by current InetAddress rules.
*
* @param address the inetAddress to check
* @return true if inetAddress is allowed
* @param request the request to check
* @return true if inetAddress and request are allowed
*/
protected boolean isAllowed(InetAddress address, HttpServletRequest request)
{
return isAllowed(address);
}
/**
* @deprecated use {@link #isAllowed(InetAddress, HttpServletRequest)} instead
*/
@Deprecated
protected boolean isAllowed(InetAddress address)
{
boolean allowed = _set.test(address);