Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix #11290 empty field (#11291) 

Fixed cacheable empty field for #11290
This commit is contained in:
Greg Wilkins 2024-01-19 09:21:43 +11:00 committed by GitHub
parent 8cc7abe412
commit a2d86c7f67
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java
View File

@ -2128,7 +2128,7 @@ public class HttpParser
public boolean cacheable(HttpHeader header, String valueString)
{
return isEnabled() && header != null && valueString.length() <= _size;
return isEnabled() && header != null && valueString != null && valueString.length() <= _size;
}
private void prepare()

21
jetty-core/jetty-http/src/test/java/org/eclipse/jetty/http/HttpParserTest.java
View File

@ -557,12 +557,23 @@ public class HttpParserTest
ByteBuffer buffer = BufferUtil.toBuffer(
"GET / HTTP/1.0" + eoln +
"Host: localhost" + eoln +
"Name0: " + eoln +
"Name0: " + eoln +
"Name1:" + eoln +
"Authorization: " + eoln +
"Authorization:" + eoln +
eoln);
HttpParser.RequestHandler handler = new Handler();
HttpParser.RequestHandler handler = new Handler()
{
@Override
public void badMessage(HttpException failure)
{
((Throwable)failure).printStackTrace();
super.badMessage(failure);
}
};
HttpParser parser = new HttpParser(handler);
parser.setHeaderCacheSize(1024);
parseAll(parser, buffer);
assertTrue(_headerCompleted);
@ -576,7 +587,11 @@ public class HttpParserTest
assertEquals("", _val[1]);
assertEquals("Name1", _hdr[2]);
assertEquals("", _val[2]);
assertEquals(2, _headers);
assertEquals("Authorization", _hdr[3]);
assertEquals("", _val[3]);
assertEquals("Authorization", _hdr[4]);
assertEquals("", _val[4]);
assertEquals(4, _headers);
}
@ParameterizedTest