Fix for #308860 (Update test suite to JUnit4 - Module jetty-rewrite).

git-svn-id: svn+ssh://dev.eclipse.org/svnroot/rt/org.eclipse.jetty/jetty/trunk@1747 7e9141cc-0065-0410-87d8-b60c137991c4

VERSION.txt

@@ -2,6 +2,7 @@ jetty-7.1.1-SNAPSHOT
  + 304803 Remove TypeUtil Integer and Long caches
  + 308857 Update test suite to JUnit4 - Module jetty-jndi
  + 308856 Update test suite to JUnit4 - Module jetty-jmx
+ + 308860 Update test suite to JUnit4 - Module jetty-rewrite
 
 jetty-7.1.0 5 May 2010
  + 306353 fixed cross context dispatch to root context.

jetty-rewrite/pom.xml

@@ -61,6 +61,7 @@
     <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
+      <version>${junit4-version}</version>
       <scope>test</scope>
     </dependency>
     <dependency>

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/AbstractRuleTestCase.java

@@ -12,8 +12,6 @@
 // ========================================================================
 package org.eclipse.jetty.rewrite.handler;
 
-import junit.framework.TestCase;
-
 import org.eclipse.jetty.io.bio.StringEndPoint;
 import org.eclipse.jetty.server.Connector;
 import org.eclipse.jetty.server.HttpConnection;
@@ -21,56 +19,51 @@ import org.eclipse.jetty.server.LocalConnector;
 import org.eclipse.jetty.server.Request;
 import org.eclipse.jetty.server.Response;
 import org.eclipse.jetty.server.Server;
+import org.junit.After;
 
-public abstract class AbstractRuleTestCase extends TestCase
+public abstract class AbstractRuleTestCase
 {
-    protected Server _server=new Server();
+    protected Server _server = new Server();
     protected LocalConnector _connector;
-    protected StringEndPoint _endpoint=new StringEndPoint();
+    protected StringEndPoint _endpoint = new StringEndPoint();
     protected HttpConnection _connection;
-    
     protected Request _request;
     protected Response _response;
-    
     protected boolean _isSecure = false;
 
-    public void setUp() throws Exception
+    @After
-    {
+    public void stopServer() throws Exception
-        start();
-    }
-    
-    public void tearDown() throws Exception
     {
         stop();
     }
 
-    public void start() throws Exception
+    protected void start(final boolean isSecure) throws Exception
     {
-        _connector = new LocalConnector() {
+        _connector = new LocalConnector()
+        {
             public boolean isConfidential(Request request)
             {
-                return _isSecure;
+                return isSecure;
             }
         };
-        
         _server.setConnectors(new Connector[]{_connector});
         _server.start();
         reset();
     }
 
-    public void stop() throws Exception
+    protected void stop() throws Exception
     {
         _server.stop();
+        _server.join();
         _request = null;
         _response = null;
     }
 
-    public void reset()
+    protected void reset()
     {
-        _connection = new HttpConnection(_connector,_endpoint,_server);
+        _connection = new HttpConnection(_connector, _endpoint, _server);
         _request = new Request(_connection);
         _response = new Response(_connection);
-        
         _request.setRequestURI("/test/");
     }
 }

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/CookiePatternRuleTest.java

@@ -17,24 +17,29 @@ import java.util.Enumeration;
 
 import org.eclipse.jetty.http.HttpFields;
 import org.eclipse.jetty.http.HttpHeaders;
+import org.junit.Before;
+import org.junit.Test;
 
+import static org.junit.Assert.assertEquals;
 
 public class CookiePatternRuleTest extends AbstractRuleTestCase
 {
-    public void setUp() throws Exception
+    @Before
+    public void init() throws Exception
     {
-        super.setUp();
+        start(false);
     }
 
+    @Test
     public void testSingleCookie() throws IOException
     {
         String[][] cookie = {
                 {"cookie", "value"}
         };
-
         assertCookies(cookie);
     }
 
+    @Test
     public void testMultipleCookies() throws IOException
     {
         String[][] cookies = {
@@ -42,16 +47,13 @@ public class CookiePatternRuleTest extends AbstractRuleTestCase
                 {"name", "wolfgangpuck"},
                 {"age", "28"}
         };
-        
         assertCookies(cookies);
     }
 
     private void assertCookies(String[][] cookies) throws IOException
     {
-        for (int i = 0; i < cookies.length; i++)
+        for (String[] cookie : cookies)
         {
-            String[] cookie = cookies[i];
-            
             // set cookie pattern
             CookiePatternRule rule = new CookiePatternRule();
             rule.setPattern("*");

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/ForwardedSchemeHeaderRuleTest.java

@@ -14,70 +14,70 @@
 package org.eclipse.jetty.rewrite.handler;
 
 import org.eclipse.jetty.http.HttpFields;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
 
 public class ForwardedSchemeHeaderRuleTest extends AbstractRuleTestCase
 {
     private ForwardedSchemeHeaderRule _rule;
     private HttpFields _requestHeaderFields;
 
-    public void setUp() throws Exception
+    @Before
+    public void init() throws Exception
     {
-        super.setUp();
+        start(false);
         _rule = new ForwardedSchemeHeaderRule();
         _requestHeaderFields = _connection.getRequestFields();
         _request.setScheme(null);
     }
 
+    @Test
     public void testDefaultScheme() throws Exception
     {
         setRequestHeader("X-Forwarded-Scheme", "https");
         _rule.setHeader("X-Forwarded-Scheme");
         _rule.setHeaderValue("https");
-        
         _rule.matchAndApply("/", _request, _response);
         assertEquals("https", _request.getScheme());
     }
 
+    @Test
     public void testScheme() throws Exception
     {
         setRequestHeader("X-Forwarded-Scheme", "https");
         _rule.setHeader("X-Forwarded-Scheme");
         _rule.setHeaderValue("https");
         _rule.setScheme("https");
-
         _rule.matchAndApply("/", _request, _response);
         assertEquals("https", _request.getScheme());
 
-        
         _rule.setScheme("http");
         _rule.matchAndApply("/", _request, _response);
         assertEquals("http", _request.getScheme());
     }
 
+    @Test
     public void testHeaderValue() throws Exception
     {
         setRequestHeader("Front-End-Https", "on");
         _rule.setHeader("Front-End-Https");
         _rule.setHeaderValue("on");
         _rule.setScheme("https");
-        
         _rule.matchAndApply("/",_request,_response);
         assertEquals("https",_request.getScheme());
+
         _request.setScheme(null);
-        
-        
         // header value doesn't match rule's value
         setRequestHeader("Front-End-Https", "off");
-        
         _rule.matchAndApply("/",_request,_response);
         assertEquals(null,_request.getScheme());
+
         _request.setScheme(null);
-
-        
         // header value can be any value
         setRequestHeader("Front-End-Https", "any");
         _rule.setHeaderValue(null);
-        
         _rule.matchAndApply("/",_request,_response);
         assertEquals("https",_request.getScheme());
     }

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/HeaderPatternRuleTest.java

@@ -15,19 +15,24 @@ package org.eclipse.jetty.rewrite.handler;
 import java.io.IOException;
 import java.util.Enumeration;
 
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
 
 public class HeaderPatternRuleTest extends AbstractRuleTestCase
 {
     private HeaderPatternRule _rule;
 
-    public void setUp() throws Exception
+    @Before
+    public void init() throws Exception
     {
-        super.setUp();
+        start(false);
-
         _rule = new HeaderPatternRule();
         _rule.setPattern("*");
     }
 
+    @Test
     public void testHeaderWithTextValues() throws IOException
     {
         // different keys
@@ -36,10 +41,10 @@ public class HeaderPatternRuleTest extends AbstractRuleTestCase
                 { "hnum#2", "2test2" },
                 { "hnum#3", "test3" }
         };
-
         assertHeaders(headers);
     }
 
+    @Test
     public void testHeaderWithNumberValues() throws IOException
     {
         String headers[][] = {
@@ -53,10 +58,10 @@ public class HeaderPatternRuleTest extends AbstractRuleTestCase
 
                 { "hello1", "200" }
         };
-
         assertHeaders(headers);
     }
 
+    @Test
     public void testHeaderOverwriteValues() throws IOException
     {
         String headers[][] = {
@@ -73,7 +78,6 @@ public class HeaderPatternRuleTest extends AbstractRuleTestCase
                 { "title1", "abba" },
                 { "title1", "abba1" }
         };
-        
         assertHeaders(headers);
 
         Enumeration e = _response.getHeaders("size");
@@ -92,14 +96,14 @@ public class HeaderPatternRuleTest extends AbstractRuleTestCase
 
     private void assertHeaders(String headers[][]) throws IOException
     {
-        for (int i = 0; i < headers.length; i++)
+        for (String[] header : headers)
         {
-            _rule.setName(headers[i][0]);
+            _rule.setName(header[0]);
-            _rule.setValue(headers[i][1]);
+            _rule.setValue(header[1]);
 
             _rule.apply(null, _request, _response);
 
-            assertEquals(headers[i][1], _response.getHeader(headers[i][0]));
+            assertEquals(header[1], _response.getHeader(header[0]));
         }
     }
 }

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/LegacyRuleTest.java

@@ -13,50 +13,49 @@
 
 package org.eclipse.jetty.rewrite.handler;
 
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
 
 public class LegacyRuleTest extends AbstractRuleTestCase
 {
-    private LegacyRule _rule;
+    private String[][] _tests=
-    
-    String[][] _tests=
     {
             {"/foo/bar","/*","/replace/foo/bar"},
             {"/foo/bar","/foo/*","/replace/bar"},
             {"/foo/bar","/foo/bar","/replace"}
     };
+    private LegacyRule _rule;
 
-    public void setUp() throws Exception
+    @Before
+    public void init() throws Exception
     {
-        super.setUp();
+        start(false);
         _rule = new LegacyRule();
     }
 
-    public void tearDown()
+    @After
+    public void destroy()
     {
         _rule = null;
     }
 
+    @Test
     public void testMatchAndApply() throws Exception
     {
-        for (int i=0;i<_tests.length;i++)
+        for (String[] _test : _tests)
         {
-            _rule.addRewriteRule(_tests[i][1], "/replace");
+            _rule.addRewriteRule(_test[1], "/replace");
-            
+            String result = _rule.matchAndApply(_test[0], _request, _response);
-            String result = _rule.matchAndApply(_tests[i][0], _request, _response);
+            assertEquals(_test[1], _test[2], result);
-        
-            assertEquals(_tests[i][1], _tests[i][2], result);
         }
     }
 
+    @Test(expected = IllegalArgumentException.class)
     public void testAddRewrite()
     {
-        try
+        _rule.addRewriteRule("*.txt", "/replace");
-        {
-            _rule.addRewriteRule("*.txt", "/replace");
-            fail();
-        } 
-        catch (IllegalArgumentException e)
-        {
-        }
     }
 }

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/MsieSslRuleTest.java

@@ -16,21 +16,24 @@ package org.eclipse.jetty.rewrite.handler;
 import org.eclipse.jetty.http.HttpFields;
 import org.eclipse.jetty.http.HttpHeaderValues;
 import org.eclipse.jetty.http.HttpHeaders;
+import org.junit.Before;
+import org.junit.Test;
 
+import static org.junit.Assert.assertEquals;
 
 public class MsieSslRuleTest extends AbstractRuleTestCase
 {
     private MsieSslRule _rule;
 
-    public void setUp() throws Exception
+    @Before
+    public void init() throws Exception
     {
         // enable SSL
-        _isSecure = true;
+        start(true);
-        
-        super.setUp();
         _rule = new MsieSslRule();
     }
 
+    @Test
     public void testWin2kWithIE5() throws Exception
     {
         HttpFields fields = _connection.getRequestFields();
@@ -45,14 +48,15 @@ public class MsieSslRuleTest extends AbstractRuleTestCase
         fields.add("User-Agent", "Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0)");
         result = _rule.matchAndApply(_request.getRequestURI(), _request, _response);
         assertEquals(_request.getRequestURI(), result);
-        assertEquals(HttpHeaderValues.CLOSE, _response.getHeader(HttpHeaders.CONNECTION));;
+        assertEquals(HttpHeaderValues.CLOSE, _response.getHeader(HttpHeaders.CONNECTION));
 
         fields.add("User-Agent", "Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 5.0)");
         result = _rule.matchAndApply(_request.getRequestURI(), _request, _response);
         assertEquals(_request.getRequestURI(), result);
-        assertEquals(HttpHeaderValues.CLOSE, _response.getHeader(HttpHeaders.CONNECTION));;
+        assertEquals(HttpHeaderValues.CLOSE, _response.getHeader(HttpHeaders.CONNECTION));
     }
 
+    @Test
     public void testWin2kWithIE6() throws Exception
     {
         HttpFields fields = _connection.getRequestFields();
@@ -64,6 +68,7 @@ public class MsieSslRuleTest extends AbstractRuleTestCase
         assertEquals(HttpHeaderValues.CLOSE, _response.getHeader(HttpHeaders.CONNECTION));
     }
 
+    @Test
     public void testWin2kWithIE7() throws Exception
     {
         HttpFields fields = _connection.getRequestFields();
@@ -75,6 +80,7 @@ public class MsieSslRuleTest extends AbstractRuleTestCase
         assertEquals(null, _response.getHeader(HttpHeaders.CONNECTION));
     }
 
+    @Test
     public void testWin2kSP1WithIE5() throws Exception
     {
         HttpFields fields = _connection.getRequestFields();
@@ -96,6 +102,7 @@ public class MsieSslRuleTest extends AbstractRuleTestCase
         assertEquals(HttpHeaderValues.CLOSE, _response.getHeader(HttpHeaders.CONNECTION));
     }
 
+    @Test
     public void testWin2kSP1WithIE6() throws Exception
     {
         HttpFields fields = _connection.getRequestFields();
@@ -107,6 +114,7 @@ public class MsieSslRuleTest extends AbstractRuleTestCase
         assertEquals(HttpHeaderValues.CLOSE, _response.getHeader(HttpHeaders.CONNECTION));
     }
 
+    @Test
     public void testWin2kSP1WithIE7() throws Exception
     {
         HttpFields fields = _connection.getRequestFields();
@@ -118,6 +126,7 @@ public class MsieSslRuleTest extends AbstractRuleTestCase
         assertEquals(null, _response.getHeader(HttpHeaders.CONNECTION));
     }
 
+    @Test
     public void testWinXpWithIE5() throws Exception
     {
         HttpFields fields = _connection.getRequestFields();
@@ -139,6 +148,7 @@ public class MsieSslRuleTest extends AbstractRuleTestCase
         assertEquals(HttpHeaderValues.CLOSE, _response.getHeader(HttpHeaders.CONNECTION));
     }
 
+    @Test
     public void testWinXpWithIE6() throws Exception
     {
         HttpFields fields = _connection.getRequestFields();
@@ -150,6 +160,7 @@ public class MsieSslRuleTest extends AbstractRuleTestCase
         assertEquals(null, _response.getHeader(HttpHeaders.CONNECTION));
     }
 
+    @Test
     public void testWinXpWithIE7() throws Exception
     {
         HttpFields fields = _connection.getRequestFields();
@@ -161,6 +172,7 @@ public class MsieSslRuleTest extends AbstractRuleTestCase
         assertEquals(null, _response.getHeader(HttpHeaders.CONNECTION));
     }
 
+    @Test
     public void testWinVistaWithIE5() throws Exception
     {
         HttpFields fields = _connection.getRequestFields();
@@ -182,6 +194,7 @@ public class MsieSslRuleTest extends AbstractRuleTestCase
         assertEquals(HttpHeaderValues.CLOSE, _response.getHeader(HttpHeaders.CONNECTION));
     }
 
+    @Test
     public void testWinVistaWithIE6() throws Exception
     {
         HttpFields fields = _connection.getRequestFields();
@@ -193,6 +206,7 @@ public class MsieSslRuleTest extends AbstractRuleTestCase
         assertEquals(null, _response.getHeader(HttpHeaders.CONNECTION));
     }
 
+    @Test
     public void testWinVistaWithIE7() throws Exception
     {
         HttpFields fields = _connection.getRequestFields();
@@ -204,12 +218,12 @@ public class MsieSslRuleTest extends AbstractRuleTestCase
         assertEquals(null, _response.getHeader(HttpHeaders.CONNECTION));
     }
 
+    @Test
     public void testWithoutSsl() throws Exception
     {
         // disable SSL
-        _isSecure = false;
         super.stop();
-        super.start();
+        super.start(false);
 
         HttpFields fields = _connection.getRequestFields();
         fields.add("User-Agent", "Mozilla/4.0 (compatible; MSIE 5.0; Windows NT 5.0)");

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/PatternRuleTest.java

@@ -13,28 +13,33 @@
 package org.eclipse.jetty.rewrite.handler;
 
 import java.io.IOException;
-
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
-import junit.framework.TestCase;
-
 import org.eclipse.jetty.server.Request;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
 
-public class PatternRuleTest extends TestCase
+import static org.junit.Assert.assertEquals;
+
+public class PatternRuleTest
 {
     private PatternRule _rule;
 
-    public void setUp()
+    @Before
+    public void init()
     {
         _rule = new TestPatternRule();
     }
 
-    public void tearDown()
+    @After
+    public void destroy()
     {
         _rule = null;
     }
 
+    @Test
     public void testTrueMatch() throws IOException
     {
         String[][] matchCases = {
@@ -80,13 +85,13 @@ public class PatternRuleTest extends TestCase
                 {"/abc:/def", "/abc:/def"}
         };
 
-        for (int i = 0; i < matchCases.length; i++)
+        for (String[] matchCase : matchCases)
         {
-            String[] matchCase = matchCases[i];
             assertMatch(true, matchCase);
         }
     }
 
+    @Test
     public void testFalseMatch() throws IOException
     {
         String[][] matchCases = {
@@ -111,9 +116,8 @@ public class PatternRuleTest extends TestCase
                 {"*.jsp", "/abc.do"}
         };
 
-        for (int i = 0; i < matchCases.length; i++)
+        for (String[] matchCase : matchCases)
         {
-            String[] matchCase = matchCases[i];
             assertMatch(false, matchCase);
         }
     }
@@ -134,7 +138,6 @@ public class PatternRuleTest extends TestCase
         assertEquals("pattern: " + matchCase[0] + " uri: " + matchCase[1], flag, result!=null);
     }
 
-    
     private class TestPatternRule extends PatternRule
     {
         @Override

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/RedirectPatternRuleTest.java

@@ -15,32 +15,36 @@ package org.eclipse.jetty.rewrite.handler;
 import java.io.IOException;
 
 import org.eclipse.jetty.http.HttpHeaders;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
 
+import static org.junit.Assert.assertEquals;
 
 public class RedirectPatternRuleTest extends AbstractRuleTestCase
 {
     private RedirectPatternRule _rule;
 
-    public void setUp() throws Exception
+    @Before
+    public void init() throws Exception
     {
-        super.setUp();
+        start(false);
         _rule = new RedirectPatternRule();
         _rule.setPattern("*");
     }
 
-    public void tearDown()
+    @After
+    public void destroy()
     {
         _rule = null;
     }
 
+    @Test
     public void testLocation() throws IOException
     {
         String location = "http://eclipse.com";
-        
         _rule.setLocation(location);
         _rule.apply(null, _request, _response);
-        
         assertEquals(location, _response.getHeader(HttpHeaders.LOCATION));
     }
-    
 }

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/RedirectRegexRuleTest.java

@@ -19,22 +19,30 @@ package org.eclipse.jetty.rewrite.handler;
 import java.io.IOException;
 
 import org.eclipse.jetty.http.HttpHeaders;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
 
 public class RedirectRegexRuleTest extends AbstractRuleTestCase
 {
     private RedirectRegexRule _rule;
 
-    public void setUp() throws Exception
+    @Before
+    public void init() throws Exception
     {
-        super.setUp();
+        start(false);
         _rule = new RedirectRegexRule();
     }
 
-    public void tearDown()
+    @After
+    public void destroy()
     {
         _rule = null;
     }
 
+    @Test
     public void testLocationWithReplacementGroupEmpty() throws IOException
     {
         _rule.setRegex("/my/dir/file/(.*)$");
@@ -45,6 +53,7 @@ public class RedirectRegexRuleTest extends AbstractRuleTestCase
         assertEquals("http://www.mortbay.org/", _response.getHeader(HttpHeaders.LOCATION));
     }
 
+    @Test
     public void testLocationWithReplacmentGroupSimple() throws IOException
     {
         _rule.setRegex("/my/dir/file/(.*)$");
@@ -55,6 +64,7 @@ public class RedirectRegexRuleTest extends AbstractRuleTestCase
         assertEquals("http://www.mortbay.org/image.png", _response.getHeader(HttpHeaders.LOCATION));
     }
 
+    @Test
     public void testLocationWithReplacementGroupDeepWithParams() throws IOException
     {
         _rule.setRegex("/my/dir/file/(.*)$");
@@ -64,5 +74,4 @@ public class RedirectRegexRuleTest extends AbstractRuleTestCase
         _rule.matchAndApply("/my/dir/file/api/rest/foo?id=100&sort=date", _request, _response);
         assertEquals("http://www.mortbay.org/api/rest/foo?id=100&sort=date", _response.getHeader(HttpHeaders.LOCATION));
     }
-    
 }

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/RegexRuleTest.java

@@ -15,29 +15,33 @@ package org.eclipse.jetty.rewrite.handler;
 
 import java.io.IOException;
 import java.util.regex.Matcher;
-
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
-import junit.framework.TestCase;
-
 import org.eclipse.jetty.server.Request;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
 
-public class RegexRuleTest extends TestCase
+import static org.junit.Assert.assertEquals;
+
+public class RegexRuleTest
 {
     private RegexRule _rule;
 
-    public void setUp()
+    @Before
+    public void init()
     {
         _rule = new TestRegexRule();
-        
     }
 
-    public void tearDown()
+    @After
+    public void destroy()
     {
         _rule = null;
     }
 
+    @Test
     public void testTrueMatch() throws IOException
     {
         String[][] matchCases = {
@@ -63,22 +67,21 @@ public class RegexRuleTest extends TestCase
                 {"/abc/.*.jsp", "/abc/def/hello.jsp"}
         };
 
-        for (int i = 0; i < matchCases.length; i++)
+        for (String[] matchCase : matchCases)
         {
-            String[] matchCase = matchCases[i];
             assertMatch(true, matchCase);
         }
     }
 
+    @Test
     public void testFalseMatch() throws IOException
     {
         String[][] matchCases = {
                 {"/abc/.*.jsp", "/hello.jsp"}
         };
 
-        for (int i = 0; i < matchCases.length; i++)
+        for (String[] matchCase : matchCases)
         {
-            String[] matchCase = matchCases[i];
             assertMatch(false, matchCase);
         }
     }

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/ResponsePatternRuleTest.java

@@ -14,17 +14,24 @@ package org.eclipse.jetty.rewrite.handler;
 
 import java.io.IOException;
 
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
 public class ResponsePatternRuleTest extends AbstractRuleTestCase
 {
     private ResponsePatternRule _rule;
 
-    public void setUp() throws Exception
+    @Before
+    public void init() throws Exception
     {
-        super.setUp();
+        start(false);
         _rule = new ResponsePatternRule();
         _rule.setPattern("/test");
     }
 
+    @Test
     public void testStatusCodeNoReason() throws IOException
     {
         for (int i = 1; i < 400; i++)
@@ -36,6 +43,7 @@ public class ResponsePatternRuleTest extends AbstractRuleTestCase
         }
     }
 
+    @Test
     public void testStatusCodeWithReason() throws IOException
     {
         for (int i = 1; i < 400; i++)
@@ -49,6 +57,7 @@ public class ResponsePatternRuleTest extends AbstractRuleTestCase
         }
     }
 
+    @Test
     public void testErrorStatusNoReason() throws IOException
     {
         for (int i = 400; i < 600; i++)
@@ -62,6 +71,7 @@ public class ResponsePatternRuleTest extends AbstractRuleTestCase
         }
     }
 
+    @Test
     public void testErrorStatusWithReason() throws IOException
     {
         for (int i = 400; i < 600; i++)

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/RewriteHandlerTest.java

@@ -13,24 +13,27 @@
 package org.eclipse.jetty.rewrite.handler;
 
 import java.io.IOException;
-
 import javax.servlet.ServletException;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
 import org.eclipse.jetty.server.Request;
 import org.eclipse.jetty.server.handler.AbstractHandler;
+import org.junit.Before;
+import org.junit.Test;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 
 public class RewriteHandlerTest extends AbstractRuleTestCase
 {
-    RewriteHandler _handler;
+    private RewriteHandler _handler;
-    RewritePatternRule _rule1;
+    private RewritePatternRule _rule1;
-    RewritePatternRule _rule2;
+    private RewritePatternRule _rule2;
-    RewritePatternRule _rule3;
+    private RewritePatternRule _rule3;
 
-    
+    @Before
-    public void setUp() throws Exception
+    public void init() throws Exception
     {
         _handler=new RewriteHandler();
         _server.setHandler(_handler);
@@ -58,10 +61,10 @@ public class RewriteHandlerTest extends AbstractRuleTestCase
 
         _handler.setRules(new Rule[]{_rule1,_rule2,_rule3});
 
-        super.setUp();
+        start(false);
     }
 
-    
+    @Test
     public void test() throws Exception
     {
         _response.setStatus(200);
@@ -78,7 +81,6 @@ public class RewriteHandlerTest extends AbstractRuleTestCase
         assertEquals("/foo/bar",_request.getAttribute("info"));
         assertEquals(null,_request.getAttribute("before"));
 
-
         _response.setStatus(200);
         _request.setHandled(false);
         _handler.setOriginalPathAttribute(null);
@@ -91,7 +93,6 @@ public class RewriteHandlerTest extends AbstractRuleTestCase
         assertEquals("/aaa/bar",_request.getAttribute("info"));
         assertEquals(null,_request.getAttribute("before"));
 
-
         _response.setStatus(200);
         _request.setHandled(false);
         _handler.setOriginalPathAttribute("before");
@@ -106,7 +107,6 @@ public class RewriteHandlerTest extends AbstractRuleTestCase
         assertEquals("/ddd/bar",_request.getAttribute("info"));
         assertEquals("/aaa/bar",_request.getAttribute("before"));
 
-
         _response.setStatus(200);
         _request.setHandled(false);
         _rule2.setTerminating(true);
@@ -135,8 +135,5 @@ public class RewriteHandlerTest extends AbstractRuleTestCase
         assertEquals(null,_request.getAttribute("info"));
         assertEquals("/aaa/bar",_request.getAttribute("before"));
         assertTrue(_request.isHandled());
-        
-        
-        
     }
 }

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/RewritePatternRuleTest.java

@@ -14,12 +14,14 @@ package org.eclipse.jetty.rewrite.handler;
 
 import java.io.IOException;
 
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
 
 public class RewritePatternRuleTest extends AbstractRuleTestCase
 {
-    private RewritePatternRule _rule;
+    private String[][] _tests=
-    
-    String[][] _tests=
     {
             {"/foo/bar","/","/replace"},
             {"/foo/bar","/*","/replace/foo/bar"},
@@ -27,25 +29,24 @@ public class RewritePatternRuleTest extends AbstractRuleTestCase
             {"/foo/bar","/foo/bar","/replace"},
             {"/foo/bar.txt","*.txt","/replace"},
     };
+    private RewritePatternRule _rule;
 
-    public void setUp() throws Exception
+    @Before
+    public void init() throws Exception
     {
-        super.setUp();
+        start(false);
         _rule = new RewritePatternRule();
         _rule.setReplacement("/replace");
     }
 
-    
+    @Test
     public void testRequestUriEnabled() throws IOException
     {
-        for (int i=0;i<_tests.length;i++)
+        for (String[] test : _tests)
         {
-            _rule.setPattern(_tests[i][1]);
+            _rule.setPattern(test[1]);
-            
+            String result = _rule.matchAndApply(test[0], _request, _response);
-            String result = _rule.matchAndApply(_tests[i][0], _request, _response);
+            assertEquals(test[1], test[2], result);
-        
-            assertEquals(_tests[i][1],_tests[i][2], result);
         }
     }
-    
 }

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/RewriteRegexRuleTest.java

@@ -14,34 +14,37 @@ package org.eclipse.jetty.rewrite.handler;
 
 import java.io.IOException;
 
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
 public class RewriteRegexRuleTest extends AbstractRuleTestCase
 {
-    private RewriteRegexRule _rule;
+    private String[][] _tests=
-
-    String[][] _tests=
     {
             {"/foo/bar",".*","/replace","/replace"},
             {"/foo/bar","/xxx.*","/replace",null},
             {"/foo/bar","/(.*)/(.*)","/$2/$1/xxx","/bar/foo/xxx"},
     };
+    private RewriteRegexRule _rule;
 
-    public void setUp() throws Exception
+    @Before
+    public void init() throws Exception
     {
-        super.setUp();
+        start(false);
         _rule=new RewriteRegexRule();
     }
 
+    @Test
     public void testRequestUriEnabled() throws IOException
     {
-        for (int i=0;i<_tests.length;i++)
+        for (String[] test : _tests)
         {
-            _rule.setRegex(_tests[i][1]);
+            _rule.setRegex(test[1]);
-            _rule.setReplacement(_tests[i][2]);
+            _rule.setReplacement(test[2]);
-            
+            String result = _rule.matchAndApply(test[0], _request, _response);
-            String result = _rule.matchAndApply(_tests[i][0], _request, _response);
+            assertEquals(test[1], test[3], result);
-        
-            assertEquals(_tests[i][1],_tests[i][3], result);
         }
     }
-
 }

jetty-rewrite/src/test/java/org/eclipse/jetty/rewrite/handler/VirtualHostRuleContainerTest.java

@@ -13,17 +13,20 @@
 
 package org.eclipse.jetty.rewrite.handler;
 
+import org.junit.Before;
+import org.junit.Test;
 
+import static org.junit.Assert.assertEquals;
 
 public class VirtualHostRuleContainerTest extends AbstractRuleTestCase
 {
-    RewriteHandler _handler;
+    private RewriteHandler _handler;
+    private RewritePatternRule _rule;
+    private RewritePatternRule _fooRule;
+    private VirtualHostRuleContainer _fooContainerRule;
 
-    RewritePatternRule _rule;
+    @Before
-    RewritePatternRule _fooRule;
+    public void init() throws Exception
-    VirtualHostRuleContainer _fooContainerRule;
-    
-    public void setUp() throws Exception
     {
         _handler = new RewriteHandler();
         _handler.setRewriteRequestURI(true);
@@ -42,10 +45,11 @@ public class VirtualHostRuleContainerTest extends AbstractRuleTestCase
 
         _server.setHandler(_handler);
 
-        super.setUp();
+        start(false);
         _request.setRequestURI("/cheese/bar");
     }
 
+    @Test
     public void testArbitraryHost() throws Exception
     {
         _request.setServerName("cheese.com");
@@ -54,6 +58,7 @@ public class VirtualHostRuleContainerTest extends AbstractRuleTestCase
         assertEquals("{_rule, _fooContainerRule, Host: cheese.com}: applied _rule", "/rule/bar", _request.getRequestURI());
     }
 
+    @Test
     public void testVirtualHost() throws Exception
     {
         _request.setServerName("foo.com");
@@ -62,6 +67,7 @@ public class VirtualHostRuleContainerTest extends AbstractRuleTestCase
         assertEquals("{_fooContainerRule, Host: foo.com}: applied _fooRule", "/cheese/fooRule", _request.getRequestURI());
     }
 
+    @Test
     public void testCascadingRules() throws Exception
     {
         _request.setServerName("foo.com");
@@ -92,6 +98,7 @@ public class VirtualHostRuleContainerTest extends AbstractRuleTestCase
         assertEquals("{_fooContainerRule, _rule}: (_fooContainerRule is terminating); applied _fooRule, terminated before _rule", "/cheese/fooRule", _request.getRequestURI());
     }
 
+    @Test
     public void testCaseInsensitiveHostname() throws Exception
     {
         _request.setServerName("Foo.com");
@@ -102,6 +109,7 @@ public class VirtualHostRuleContainerTest extends AbstractRuleTestCase
         assertEquals("Foo.com and foo.com are equivalent", "/cheese/fooRule", _request.getRequestURI());
     }
 
+    @Test
     public void testEmptyVirtualHost() throws Exception
     {
         _request.setServerName("cheese.com");
@@ -125,6 +133,7 @@ public class VirtualHostRuleContainerTest extends AbstractRuleTestCase
 
     }
 
+    @Test
     public void testMultipleVirtualHosts() throws Exception
     {
         _request.setServerName("foo.com");
@@ -140,6 +149,7 @@ public class VirtualHostRuleContainerTest extends AbstractRuleTestCase
         assertEquals("{_fooContainerRule: vhosts[cheese.com, foo.com], Host: foo.com}: apply _fooRule", "/cheese/fooRule", _request.getRequestURI());
     }
 
+    @Test
     public void testWildcardVirtualHosts() throws Exception
     {
         checkWildcardHost(true,null,new String[] {"foo.com", ".foo.com", "vhost.foo.com"});
@@ -181,4 +191,3 @@ public class VirtualHostRuleContainerTest extends AbstractRuleTestCase
         _server.handle("/cheese/bar", _request, _request, _response);
     }
 }
-