Eclipse/jetty.project
1
0
Fork 0
mirror of https://github.com/jetty/jetty.project.git synced 2025-03-03 04:19:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

483427 - AsyncContext complete while pending async Reads/Writes

Browse Source 
improved unit test
This commit is contained in:
Greg Wilkins 2015-12-04 10:10:12 +11:00
parent 5afa348aaa
commit ae9dc7922d
1 changed files with 53 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

102
jetty-servlet/src/test/java/org/eclipse/jetty/servlet/AsyncServletIOTest.java
View File

@ -614,6 +614,9 @@ public class AsyncServletIOTest
@Test @Test
public void testCompleteWhilePending() throws Exception public void testCompleteWhilePending() throws Exception
{ {
_servlet4.onDA.set(0);
_servlet4.onWP.set(0);
StringBuilder request = new StringBuilder(512); StringBuilder request = new StringBuilder(512);
request.append("POST /ctx/path4/info HTTP/1.1\r\n") request.append("POST /ctx/path4/info HTTP/1.1\r\n")
.append("Host: localhost\r\n") .append("Host: localhost\r\n")
@ -674,7 +677,7 @@ public class AsyncServletIOTest
} }
catch(IOException e) catch(IOException e)
{ {
// ignored
} }
LOG.debug("last: "+last); LOG.debug("last: "+last);
@ -686,8 +689,8 @@ public class AsyncServletIOTest
assertTrue(_servlet4.completed.await(5, TimeUnit.SECONDS)); assertTrue(_servlet4.completed.await(5, TimeUnit.SECONDS));
Thread.sleep(100); Thread.sleep(100);
assertEquals(2,_servlet4.onDA.get()); assertEquals(0,_servlet4.onDA.get());
assertEquals(2,_servlet4.onWP.get()); assertEquals(0,_servlet4.onWP.get());
} }
@ -708,7 +711,6 @@ public class AsyncServletIOTest
in.setReadListener(new ReadListener() in.setReadListener(new ReadListener()
{ {
@Override @Override
public void onError(Throwable t) public void onError(Throwable t)
{ {
@ -719,59 +721,61 @@ public class AsyncServletIOTest
public void onDataAvailable() throws IOException public void onDataAvailable() throws IOException
{ {
onDA.incrementAndGet(); onDA.incrementAndGet();
if (onDA.get()>2)
return; boolean readF=false;
// Read all available content // Read all available content
while(in.isReady()) while(in.isReady())
if (in.read()<0)
throw new IllegalStateException();
if (onDA.get()==1)
return;
final byte[] buffer = new byte[64*1024];
Arrays.fill(buffer,(byte)'X');
for (int i=199;i<buffer.length;i+=200)
buffer[i]=(byte)'\n';
// Once we read block, let's make ourselves write blocked
out.setWriteListener(new WriteListener()
{ {
@Override int c = in.read();
public void onWritePossible() throws IOException if (c<0)
throw new IllegalStateException();
if (c=='F')
readF=true;
}
if (readF)
{
onDA.set(0);
final byte[] buffer = new byte[64*1024];
Arrays.fill(buffer,(byte)'X');
for (int i=199;i<buffer.length;i+=200)
buffer[i]=(byte)'\n';
// Once we read block, let's make ourselves write blocked
out.setWriteListener(new WriteListener()
{ {
onWP.incrementAndGet(); @Override
if (onWP.get()>2) public void onWritePossible() throws IOException
return;
while (out.isReady())
out.write(buffer);
if (onWP.get()==1)
return;
try
{ {
// As soon as we are write blocked, complete onWP.incrementAndGet();
async.complete();
while (out.isReady())
out.write(buffer);
try
{
// As soon as we are write blocked, complete
onWP.set(0);
async.complete();
}
catch(Exception e)
{
e.printStackTrace();
}
finally
{
completed.countDown();
}
} }
catch(Exception e)
@Override
public void onError(Throwable t)
{ {
e.printStackTrace(); t.printStackTrace();
} }
finally });
{ }
completed.countDown();
}
}
@Override
public void onError(Throwable t)
{
t.printStackTrace();
}
});
} }
@Override @Override