Jetty9 - Cleaned up implementation and removed warning when a bean is non managed and not started.

An example of such beans is the Connection.Statistics implementation.
This commit is contained in:
Simone Bordet 2012-08-06 16:21:07 +02:00
parent 2ce23df344
commit b0041287a6
1 changed files with 162 additions and 180 deletions

View File

@ -1,22 +1,22 @@
// ========================================================================
// Copyright (c) 2006-2012 Mort Bay Consulting Pty. Ltd.
// ------------------------------------------------------------------------
// All rights reserved. This program and the accompanying materials
// are made available under the terms of the Eclipse Public License v1.0
// and Apache License v2.0 which accompanies this distribution.
// The Eclipse Public License is available at
// http://www.eclipse.org/legal/epl-v10.html
// The Apache License v2.0 is available at
// http://www.opensource.org/licenses/apache2.0.php
// You may elect to redistribute this code under either of these licenses.
// ========================================================================
package org.eclipse.jetty.util.component;
//========================================================================
//Copyright (c) 2006-2012 Mort Bay Consulting Pty. Ltd.
//------------------------------------------------------------------------
//All rights reserved. This program and the accompanying materials
//are made available under the terms of the Eclipse Public License v1.0
//and Apache License v2.0 which accompanies this distribution.
//The Eclipse Public License is available at
//http://www.eclipse.org/legal/epl-v10.html
//The Apache License v2.0 is available at
//http://www.opensource.org/licenses/apache2.0.php
//You may elect to redistribute this code under either of these licenses.
//========================================================================
import java.io.IOException;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.concurrent.CopyOnWriteArrayList;
@ -25,110 +25,102 @@ import org.eclipse.jetty.util.log.Logger;
/**
* An AggregateLifeCycle is an {@link LifeCycle} implementation for a collection of contained beans.
* <p>
* Beans can be added the AggregateLifeCycle either as managed beans or as unmanaged beans. A managed bean is started, stopped and destroyed with the aggregate.
* <p/>
* Beans can be added the AggregateLifeCycle either as managed beans or as unmanaged beans. A managed bean is started, stopped and destroyed with the aggregate.
* An unmanaged bean is associated with the aggregate for the purposes of {@link #dump()}, but it's lifecycle must be managed externally.
* <p>
* When a bean is added, if it is a {@link LifeCycle} and it is already started, then it is assumed to be an unmanaged bean.
* Otherwise the methods {@link #addBean(Object, boolean)}, {@link #manage(Object)} and {@link #unmanage(Object)} can be used to
* <p/>
* When a bean is added, if it is a {@link LifeCycle} and it is already started, then it is assumed to be an unmanaged bean.
* Otherwise the methods {@link #addBean(Object, boolean)}, {@link #manage(Object)} and {@link #unmanage(Object)} can be used to
* explicitly control the life cycle relationship.
* <p>
* If adding a bean that is shared between multiple {@link AggregateLifeCycle} instances, then it should be started before being added, so it is unmanaged, or
* <p/>
* If adding a bean that is shared between multiple {@link AggregateLifeCycle} instances, then it should be started before being added, so it is unmanaged, or
* the API must be used to explicitly set it as unmanaged.
* <p>
* <p/>
*/
public class AggregateLifeCycle extends AbstractLifeCycle implements Destroyable, Dumpable
{
private static final Logger LOG = Log.getLogger(AggregateLifeCycle.class);
private final List<Bean> _beans=new CopyOnWriteArrayList<Bean>();
private boolean _started=false;
private final List<Bean> _beans = new CopyOnWriteArrayList<>();
private boolean _started = false;
private class Bean
{
Bean(Object b)
private final Object _bean;
private volatile boolean _managed = true;
private Bean(Object b)
{
_bean=b;
_bean = b;
}
final Object _bean;
volatile boolean _managed=true;
public String toString()
{
return "{"+_bean+","+_managed+"}";
return String.format("{%s,%b}", _bean, _managed);
}
}
/* ------------------------------------------------------------ */
/**
* Start the managed lifecycle beans in the order they were added.
* @see org.eclipse.jetty.util.component.AbstractLifeCycle#doStart()
* Starts the managed lifecycle beans in the order they were added.
*/
@Override
protected void doStart() throws Exception
{
for (Bean b:_beans)
for (Bean b : _beans)
{
if (b._bean instanceof LifeCycle)
{
LifeCycle l=(LifeCycle)b._bean;
LifeCycle l = (LifeCycle)b._bean;
if (!l.isRunning())
{
if (b._managed)
l.start();
else
LOG.warn("!managed !started {}",b);
}
}
if (b._managed && b._bean instanceof LifeCycle)
{
LifeCycle l=(LifeCycle)b._bean;
LifeCycle l = (LifeCycle)b._bean;
if (!l.isRunning())
l.start();
}
}
// indicate that we are started, so that addBean will start other beans added.
_started=true;
_started = true;
super.doStart();
}
/* ------------------------------------------------------------ */
/**
* Stop the joined lifecycle beans in the reverse order they were added.
* @see org.eclipse.jetty.util.component.AbstractLifeCycle#doStart()
* Stops the managed lifecycle beans in the reverse order they were added.
*/
@Override
protected void doStop() throws Exception
{
_started=false;
_started = false;
super.doStop();
List<Bean> reverse = new ArrayList<Bean>(_beans);
List<Bean> reverse = new ArrayList<>(_beans);
Collections.reverse(reverse);
for (Bean b:reverse)
for (Bean b : reverse)
{
if (b._managed && b._bean instanceof LifeCycle)
{
LifeCycle l=(LifeCycle)b._bean;
LifeCycle l = (LifeCycle)b._bean;
if (l.isRunning())
l.stop();
}
}
}
/* ------------------------------------------------------------ */
/**
* Destroy the joined Destroyable beans in the reverse order they were added.
* @see org.eclipse.jetty.util.component.Destroyable#destroy()
* Destroys the managed Destroyable beans in the reverse order they were added.
*/
public void destroy()
{
List<Bean> reverse = new ArrayList<Bean>(_beans);
List<Bean> reverse = new ArrayList<>(_beans);
Collections.reverse(reverse);
for (Bean b:reverse)
for (Bean b : reverse)
{
if (b._bean instanceof Destroyable && b._managed)
{
Destroyable d=(Destroyable)b._bean;
Destroyable d = (Destroyable)b._bean;
d.destroy();
}
}
@ -136,66 +128,67 @@ public class AggregateLifeCycle extends AbstractLifeCycle implements Destroyable
}
/* ------------------------------------------------------------ */
/** Is the bean contained in the aggregate.
* @param bean
* @return True if the aggregate contains the bean
/**
* @param bean the bean to test
* @return whether this aggregate contains the bean
*/
public boolean contains(Object bean)
{
for (Bean b:_beans)
if (b._bean==bean)
for (Bean b : _beans)
if (b._bean == bean)
return true;
return false;
}
/* ------------------------------------------------------------ */
/** Is the bean joined to the aggregate.
* @param bean
* @return True if the aggregate contains the bean and it is joined
/**
* @param bean the bean to test
* @return whether this aggregate contains and manages the bean
*/
public boolean isManaged(Object bean)
{
for (Bean b:_beans)
if (b._bean==bean)
for (Bean b : _beans)
if (b._bean == bean)
return b._managed;
return false;
}
/* ------------------------------------------------------------ */
/**
* Add an associated bean.
* If the bean is a {@link LifeCycle}, then it will be managed if it is not
* already started and umanaged if it is already started. The {@link #addBean(Object, boolean)}
* Adds the given bean, detecting whether to manage it or not.
* If the bean is a {@link LifeCycle}, then it will be managed if it is not
* already started and not managed if it is already started.
* The {@link #addBean(Object, boolean)}
* method should be used if this is not correct, or the {@link #manage(Object)} and {@link #unmanage(Object)}
* methods may be used after an add to change the status.
*
* @param o the bean object to add
* @return true if the bean was added or false if it has already been added.
* @return true if the bean was added, false if it was already present
*/
public boolean addBean(Object o)
{
// beans are joined unless they are started lifecycles
return addBean(o,!((o instanceof LifeCycle)&&((LifeCycle)o).isStarted()));
return addBean(o, !((o instanceof LifeCycle) && ((LifeCycle)o).isStarted()));
}
/* ------------------------------------------------------------ */
/** Add an associated lifecycle.
* @param o The lifecycle to add
* @param managed True if the LifeCycle is to be joined, otherwise it will be disjoint.
* @return true if bean was added, false if already present.
/**
* Adds the given bean, explicitly managing it or not.
*
* @param o The bean object to add
* @param managed whether to managed the lifecycle of the bean
* @return true if the bean was added, false if it was already present
*/
public boolean addBean(Object o, boolean managed)
{
if (contains(o))
return false;
Bean b = new Bean(o);
b._managed=managed;
b._managed = managed;
_beans.add(b);
if (o instanceof LifeCycle)
{
LifeCycle l=(LifeCycle)o;
LifeCycle l = (LifeCycle)o;
// Start the bean if we are started
if (managed && _started)
@ -204,118 +197,111 @@ public class AggregateLifeCycle extends AbstractLifeCycle implements Destroyable
{
l.start();
}
catch(Exception e)
catch (Exception e)
{
throw new RuntimeException (e);
throw new RuntimeException(e);
}
}
}
return true;
}
/* ------------------------------------------------------------ */
/**
* Manage a bean by this aggregate, so that it is started/stopped/destroyed with the
* aggregate lifecycle.
* Manages a bean already contained by this aggregate, so that it is started/stopped/destroyed with this
* aggregate.
*
* @param bean The bean to manage (must already have been added).
*/
public void manage(Object bean)
{
for (Bean b :_beans)
{
for (Bean b : _beans)
{
if (b._bean==bean)
if (b._bean == bean)
{
b._managed=true;
b._managed = true;
return;
}
}
throw new IllegalArgumentException();
throw new IllegalArgumentException("Unknown bean " + bean);
}
/* ------------------------------------------------------------ */
/**
* Unmanage a bean by this aggregate, so that it is not started/stopped/destroyed with the
* aggregate lifecycle.
* @param bean The bean to manage (must already have been added).
* Unmanages a bean already contained by this aggregate, so that it is not started/stopped/destroyed with this
* aggregate.
*
* @param bean The bean to unmanage (must already have been added).
*/
public void unmanage(Object bean)
{
for (Bean b :_beans)
for (Bean b : _beans)
{
if (b._bean==bean)
if (b._bean == bean)
{
b._managed=false;
b._managed = false;
return;
}
}
throw new IllegalArgumentException();
throw new IllegalArgumentException("Unknown bean " + bean);
}
/* ------------------------------------------------------------ */
/** Get dependent beans
* @return List of beans.
/**
* @return the list of beans known to this aggregate
* @see #getBean(Class)
*/
public Collection<Object> getBeans()
{
return getBeans(Object.class);
}
/* ------------------------------------------------------------ */
/** Get dependent beans of a specific class
* @see #addBean(Object)
* @param clazz
* @return List of beans.
/**
* @param clazz the class of the beans
* @return the list of beans of the given class (or subclass)
* @see #getBeans()
*/
public <T> List<T> getBeans(Class<T> clazz)
{
ArrayList<T> beans = new ArrayList<T>();
for (Bean b:_beans)
ArrayList<T> beans = new ArrayList<>();
for (Bean b : _beans)
{
if (clazz.isInstance(b._bean))
beans.add((T)(b._bean));
beans.add(clazz.cast(b._bean));
}
return beans;
}
/* ------------------------------------------------------------ */
/** Get dependent beans of a specific class.
* If more than one bean of the type exist, the first is returned.
* @see #addBean(Object)
* @param clazz
* @return bean or null
/**
* @param clazz the class of the bean
* @return the first bean of a specific class (or subclass), or null if no such bean exist
*/
public <T> T getBean(Class<T> clazz)
{
for (Bean b:_beans)
for (Bean b : _beans)
{
if (clazz.isInstance(b._bean))
return (T)b._bean;
return clazz.cast(b._bean);
}
return null;
}
/* ------------------------------------------------------------ */
/**
* Remove all associated bean.
* Removes all bean, without performing any lifecycle
* @see #destroy()
*/
public void removeBeans ()
public void removeBeans()
{
_beans.clear();
}
/* ------------------------------------------------------------ */
/**
* Remove an associated bean.
* Removes the given bean.
* @return whether the bean was removed
* @see #removeBeans()
*/
public boolean removeBean (Object o)
public boolean removeBean(Object o)
{
Iterator<Bean> i = _beans.iterator();
while(i.hasNext())
for (Bean b : _beans)
{
Bean b=i.next();
if (b._bean==o)
if (b._bean == o)
{
_beans.remove(b);
return true;
@ -324,54 +310,52 @@ public class AggregateLifeCycle extends AbstractLifeCycle implements Destroyable
return false;
}
/* ------------------------------------------------------------ */
/**
* Dumps to {@link System#err}.
* @see #dump()
*/
public void dumpStdErr()
{
try
{
dump(System.err,"");
dump(System.err, "");
}
catch (IOException e)
{
LOG.warn(e);
}
}
/* ------------------------------------------------------------ */
public String dump()
{
return dump(this);
}
/* ------------------------------------------------------------ */
}
public static String dump(Dumpable dumpable)
{
StringBuilder b = new StringBuilder();
try
{
dumpable.dump(b,"");
dumpable.dump(b, "");
}
catch (IOException e)
{
LOG.warn(e);
}
return b.toString();
}
/* ------------------------------------------------------------ */
public void dump(Appendable out) throws IOException
{
dump(out,"");
}
/* ------------------------------------------------------------ */
public void dump(Appendable out) throws IOException
{
dump(out, "");
}
protected void dumpThis(Appendable out) throws IOException
{
out.append(String.valueOf(this)).append(" - ").append(getState()).append("\n");
}
/* ------------------------------------------------------------ */
public static void dumpObject(Appendable out,Object o) throws IOException
public static void dumpObject(Appendable out, Object o) throws IOException
{
try
{
@ -380,20 +364,19 @@ public class AggregateLifeCycle extends AbstractLifeCycle implements Destroyable
else
out.append(String.valueOf(o)).append("\n");
}
catch(Throwable th)
catch (Throwable th)
{
out.append(" => ").append(th.toString()).append('\n');
}
}
/* ------------------------------------------------------------ */
public void dump(Appendable out,String indent) throws IOException
public void dump(Appendable out, String indent) throws IOException
{
dumpThis(out);
int size=_beans.size();
if (size==0)
int size = _beans.size();
if (size == 0)
return;
int i=0;
int i = 0;
for (Bean b : _beans)
{
i++;
@ -402,33 +385,32 @@ public class AggregateLifeCycle extends AbstractLifeCycle implements Destroyable
{
out.append(indent).append(" +- ");
if (b._bean instanceof Dumpable)
((Dumpable)b._bean).dump(out,indent+(i==size?" ":" | "));
else
dumpObject(out,b._bean);
((Dumpable)b._bean).dump(out, indent + (i == size ? " " : " | "));
else
dumpObject(out, b._bean);
}
else
else
{
out.append(indent).append(" +~ ");
dumpObject(out,b._bean);
dumpObject(out, b._bean);
}
}
if (i!=size)
if (i != size)
out.append(indent).append(" |\n");
}
/* ------------------------------------------------------------ */
public static void dump(Appendable out,String indent,Collection<?>... collections) throws IOException
public static void dump(Appendable out, String indent, Collection<?>... collections) throws IOException
{
if (collections.length==0)
if (collections.length == 0)
return;
int size=0;
int size = 0;
for (Collection<?> c : collections)
size+=c.size();
if (size==0)
size += c.size();
if (size == 0)
return;
int i=0;
int i = 0;
for (Collection<?> c : collections)
{
for (Object o : c)
@ -437,13 +419,13 @@ public class AggregateLifeCycle extends AbstractLifeCycle implements Destroyable
out.append(indent).append(" +- ");
if (o instanceof Dumpable)
((Dumpable)o).dump(out,indent+(i==size?" ":" | "));
else
dumpObject(out,o);
((Dumpable)o).dump(out, indent + (i == size ? " " : " | "));
else
dumpObject(out, o);
}
if (i!=size)
out.append(indent).append(" |\n");
if (i != size)
out.append(indent).append(" |\n");
}
}
}