From bacff75b31156101bf26d2730a292a0926b20e0a Mon Sep 17 00:00:00 2001
From: Greg Wilkins <gregw@intalio.com>
Date: Tue, 4 Jun 2013 10:51:49 +1000
Subject: [PATCH] Replace reponse.commit with response.closeOutput

---
 .../java/org/eclipse/jetty/server/HttpChannel.java     |  6 +++---
 .../main/java/org/eclipse/jetty/server/Response.java   | 10 +++-------
 .../src/main/java/org/eclipse/jetty/server/Server.java |  2 +-
 3 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannel.java b/jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannel.java
index e17d8433e3e..cf2241cfdf3 100644
--- a/jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannel.java
+++ b/jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannel.java
@@ -318,9 +318,9 @@ public class HttpChannel<T> implements HttpParser.RequestHandler<T>, Runnable
 
                 if (!_response.isCommitted() && !_request.isHandled())
                     _response.sendError(404);
-
-                // Complete generating the response
-                _response.complete();
+                else
+                    // Complete generating the response
+                    _response.closeOutput();
             }
             catch(EofException e)
             {
diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java b/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java
index 2ba9e047384..6bf81cccca0 100644
--- a/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java
+++ b/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java
@@ -436,7 +436,7 @@ public class Response implements HttpServletResponse
             _mimeType=null;
         }
 
-        complete();
+        closeOutput();
     }
 
     /**
@@ -516,7 +516,7 @@ public class Response implements HttpServletResponse
         resetBuffer();
         setHeader(HttpHeader.LOCATION, location);
         setStatus(HttpServletResponse.SC_MOVED_TEMPORARILY);
-        complete();
+        closeOutput();
     }
 
     @Override
@@ -792,6 +792,7 @@ public class Response implements HttpServletResponse
                 getOutputStream().close();
                 break;
             default:
+                _out.close();
         }
     }
 
@@ -1062,11 +1063,6 @@ public class Response implements HttpServletResponse
         return _reason;
     }
 
-    public void complete()
-    {
-        _out.close();
-    }
-
     public HttpFields getHttpFields()
     {
         return _fields;
diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java b/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java
index 28e6de372f2..cc377f04dba 100644
--- a/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java
+++ b/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java
@@ -459,7 +459,7 @@ public class Server extends HandlerWrapper implements Attributes
         response.setStatus(200);
         response.getHttpFields().put(HttpHeader.ALLOW,"GET,POST,HEAD,OPTIONS");
         response.setContentLength(0);
-        response.complete();
+        response.closeOutput();
     }
 
     /* ------------------------------------------------------------ */