Merge pull request #5494 from eclipse/jetty-9.4.x-5492-java-features-start-properties

Issue #5492 - Adding java.features.* start properties

jetty-alpn/jetty-alpn-server/src/main/config/modules/alpn-impl.mod

@@ -1,7 +0,0 @@
-# DO NOT EDIT - See: https://www.eclipse.org/jetty/documentation/current/startup-modules.html
-
-[description]
-Selects an ALPN (Application Layer Protocol Negotiation) implementation by java version.
-
-[depend]
-alpn-impl/alpn-${java.version.platform}

jetty-alpn/jetty-alpn-server/src/main/config/modules/alpn-impl/alpn-10.mod

@@ -1,4 +0,0 @@
-# DO NOT EDIT - See: https://www.eclipse.org/jetty/documentation/current/startup-modules.html
-
-[depend]
-alpn-impl/alpn-9

jetty-alpn/jetty-alpn-server/src/main/config/modules/alpn-impl/alpn-11.mod

@@ -1,4 +0,0 @@
-# DO NOT EDIT - See: https://www.eclipse.org/jetty/documentation/current/startup-modules.html
-
-[depend]
-alpn-impl/alpn-9

jetty-alpn/jetty-alpn-server/src/main/config/modules/alpn-impl/alpn-12.mod

@@ -1,4 +0,0 @@
-# DO NOT EDIT - See: https://www.eclipse.org/jetty/documentation/current/startup-modules.html
-
-[depend]
-alpn-impl/alpn-11

jetty-alpn/jetty-alpn-server/src/main/config/modules/alpn-impl/alpn-13.mod

@@ -1,4 +0,0 @@
-# DO NOT EDIT - See: https://www.eclipse.org/jetty/documentation/current/startup-modules.html
-
-[depend]
-alpn-impl/alpn-11

jetty-alpn/jetty-alpn-server/src/main/config/modules/alpn-impl/alpn-14.mod

@@ -1,4 +0,0 @@
-# DO NOT EDIT - See: https://www.eclipse.org/jetty/documentation/current/startup-modules.html
-
-[depend]
-alpn-impl/alpn-11

jetty-alpn/jetty-alpn-server/src/main/config/modules/alpn-impl/alpn-15.mod

@@ -1,4 +0,0 @@
-# DO NOT EDIT - See: https://www.eclipse.org/jetty/documentation/current/startup-modules.html
-
-[depend]
-alpn-impl/alpn-11

jetty-alpn/jetty-alpn-server/src/main/config/modules/alpn.mod

@@ -5,7 +5,7 @@ Enables the ALPN (Application Layer Protocol Negotiation) TLS extension.
 
 [depend]
 ssl
-alpn-impl
+alpn-impl/alpn-available-${runtime.feature.alpn}
 
 [lib]
 lib/jetty-alpn-client-${jetty.version}.jar

jetty-start/src/main/java/org/eclipse/jetty/start/StartArgs.java

@@ -1505,10 +1505,14 @@ public class StartArgs
             {
                 JavaVersion ver = JavaVersion.parse(value);
                 properties.setProperty("java.version.platform", Integer.toString(ver.getPlatform()), source);
+
                 // @deprecated - below will be removed in Jetty 10.x
                 properties.setProperty("java.version.major", Integer.toString(ver.getMajor()), "Deprecated");
                 properties.setProperty("java.version.minor", Integer.toString(ver.getMinor()), "Deprecated");
                 properties.setProperty("java.version.micro", Integer.toString(ver.getMicro()), "Deprecated");
+
+                // ALPN feature exists
+                properties.setProperty("runtime.feature.alpn", Boolean.toString(isMethodAvailable(javax.net.ssl.SSLParameters.class, "getApplicationProtocols", null)), source);
             }
             catch (Throwable x)
             {
@@ -1525,6 +1529,19 @@ public class StartArgs
         }
     }
 
+    private boolean isMethodAvailable(Class<?> clazz, String methodName, Class<?>[] params)
+    {
+        try
+        {
+            clazz.getMethod(methodName, params);
+            return true;
+        }
+        catch (NoSuchMethodException e)
+        {
+            return false;
+        }
+    }
+
     public void setRun(boolean run)
     {
         this.run = run;

jetty-start/src/test/java/org/eclipse/jetty/start/ConfigurationAssert.java

@@ -143,6 +143,7 @@ public class ConfigurationAssert
                 "jetty.base.uri".equals(name) ||
                 "user.dir".equals(name) ||
                 prop.source.equals(Props.ORIGIN_SYSPROP) ||
+                name.startsWith("runtime.feature.") ||
                 name.startsWith("java."))
             {
                 // strip these out from assertion, to make assertions easier.

jetty-start/src/test/java/org/eclipse/jetty/start/MainTest.java

@@ -225,8 +225,11 @@ public class MainTest
     {
         Path distPath = MavenTestingUtils.getTestResourceDir("dist-home").toPath().toRealPath();
         Path homePath = MavenTestingUtils.getTargetTestingPath().resolve("dist home with spaces");
+        if (!Files.exists(homePath))
+        {
             IO.copy(distPath.toFile(), homePath.toFile());
             Files.createFile(homePath.resolve("lib/a library.jar"));
+        }
 
         List<String> cmdLineArgs = new ArrayList<>();
         cmdLineArgs.add("user.dir=" + homePath);