SPDY remove unnecessary flush calls

This commit is contained in:
Thomas Becker 2013-09-23 14:35:58 +02:00
parent 4708c907c1
commit bfb90523d6
2 changed files with 0 additions and 8 deletions

View File

@ -533,7 +533,6 @@ public class StandardSession implements ISession, Parser.Listener, Dumpable
streamListener = notifyOnSyn(listener, stream, synInfo); streamListener = notifyOnSyn(listener, stream, synInfo);
} }
stream.setStreamFrameListener(streamListener); stream.setStreamFrameListener(streamListener);
flush();
// The onSyn() listener may have sent a frame that closed the stream // The onSyn() listener may have sent a frame that closed the stream
if (stream.isClosed()) if (stream.isClosed())
removeStream(stream); removeStream(stream);
@ -698,7 +697,6 @@ public class StandardSession implements ISession, Parser.Listener, Dumpable
RstInfo rstInfo = new RstInfo(frame.getStreamId(), StreamStatus.from(frame.getVersion(), frame.getStatusCode())); RstInfo rstInfo = new RstInfo(frame.getStreamId(), StreamStatus.from(frame.getVersion(), frame.getStatusCode()));
notifyOnRst(listener, rstInfo); notifyOnRst(listener, rstInfo);
flush();
if (stream != null) if (stream != null)
removeStream(stream); removeStream(stream);
@ -722,7 +720,6 @@ public class StandardSession implements ISession, Parser.Listener, Dumpable
} }
SettingsInfo settingsInfo = new SettingsInfo(frame.getSettings(), frame.isClearPersisted()); SettingsInfo settingsInfo = new SettingsInfo(frame.getSettings(), frame.isClearPersisted());
notifyOnSettings(listener, settingsInfo); notifyOnSettings(listener, settingsInfo);
flush();
} }
private void onPing(PingFrame frame) private void onPing(PingFrame frame)
@ -732,7 +729,6 @@ public class StandardSession implements ISession, Parser.Listener, Dumpable
{ {
PingResultInfo pingResultInfo = new PingResultInfo(frame.getPingId()); PingResultInfo pingResultInfo = new PingResultInfo(frame.getPingId());
notifyOnPing(listener, pingResultInfo); notifyOnPing(listener, pingResultInfo);
flush();
} }
else else
{ {
@ -747,7 +743,6 @@ public class StandardSession implements ISession, Parser.Listener, Dumpable
//TODO: Find a better name for GoAwayResultInfo //TODO: Find a better name for GoAwayResultInfo
GoAwayResultInfo goAwayResultInfo = new GoAwayResultInfo(frame.getLastStreamId(), SessionStatus.from(frame.getStatusCode())); GoAwayResultInfo goAwayResultInfo = new GoAwayResultInfo(frame.getLastStreamId(), SessionStatus.from(frame.getStatusCode()));
notifyOnGoAway(listener, goAwayResultInfo); notifyOnGoAway(listener, goAwayResultInfo);
flush();
// SPDY does not require to send back a response to a GO_AWAY. // SPDY does not require to send back a response to a GO_AWAY.
// We notified the application of the last good stream id and // We notified the application of the last good stream id and
// tried our best to flush remaining data. // tried our best to flush remaining data.
@ -788,7 +783,6 @@ public class StandardSession implements ISession, Parser.Listener, Dumpable
private void onCredential(CredentialFrame frame) private void onCredential(CredentialFrame frame)
{ {
LOG.warn("{} frame not yet supported", frame.getType()); LOG.warn("{} frame not yet supported", frame.getType());
flush();
} }
protected void close() protected void close()

View File

@ -246,7 +246,6 @@ public class StandardStream extends IdleTimeout implements IStream
throw new IllegalStateException(); throw new IllegalStateException();
} }
} }
session.flush();
} }
@Override @Override
@ -270,7 +269,6 @@ public class StandardStream extends IdleTimeout implements IStream
updateCloseState(dataInfo.isClose(), false); updateCloseState(dataInfo.isClose(), false);
notifyOnData(dataInfo); notifyOnData(dataInfo);
session.flush();
} }
@Override @Override