More classpath mucking about in Sfl4jTestJarsRunner

This commit is contained in:
Joakim Erdfelt 2011-10-28 09:48:59 -07:00
parent 9c9f2bd7c3
commit c02f98b7e6
1 changed files with 41 additions and 55 deletions

View File

@ -24,63 +24,49 @@ public class Slf4jTestJarsRunner extends BlockJUnit4ClassRunner
{ {
private static class Slf4jTestClassLoader extends URLClassLoader private static class Slf4jTestClassLoader extends URLClassLoader
{ {
private ClassLoader parent;
public Slf4jTestClassLoader(URL[] urls, ClassLoader parent) public Slf4jTestClassLoader(URL[] urls, ClassLoader parent)
{ {
super(urls, parent); super(urls,parent);
this.parent = parent;
} }
@Override
protected synchronized Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundException
{
System.err.printf("[slf4j.cl] loadClass(%s)%n", name);
ClassNotFoundException ex= null;
Class<?> c = null;
try
{
c = this.findClass(name);
if ( resolve )
{
resolveClass(c);
}
return c;
}
catch (ClassNotFoundException e)
{
ex= e;
}
if ( c == null )
{
try
{
c = super.loadClass(name,resolve);
}
catch (ClassNotFoundException e)
{
ex= e;
}
}
throw ex;
}
@Override @Override
public Class<?> loadClass(String name) throws ClassNotFoundException public Class<?> loadClass(String name) throws ClassNotFoundException
{ {
System.err.printf("[slf4j.cl] loadClass(%s)%n",name); System.err.printf("[slf4j.cl] loadClass(%s)%n",name);
return super.loadClass(name); Class<?> c = null;
try
{
c = super.loadClass(name);
System.err.println("FOUND in slf4j classloader: " + name);
}
catch (ClassNotFoundException e)
{
System.err.println("Not found in slf4j classloader: " + name);
} }
@Override if (c == null)
protected Class<?> findClass(String name) throws ClassNotFoundException
{ {
System.err.printf("[slf4j.cl] findClass(%s)%n",name); try
return super.findClass(name); {
c = parent.loadClass(name);
System.err.println("FOUND in parent classloader: " + name);
}
catch (ClassNotFoundException e)
{
System.err.println("Not found in parent classloader: " + name);
}
}
if (c != null)
{
System.err.printf("[slf4j.cl] loadClass(%s) -> %s%n",name,c);
return c;
}
throw new ClassNotFoundException(name);
} }
} }
@ -143,7 +129,7 @@ public class Slf4jTestJarsRunner extends BlockJUnit4ClassRunner
System.out.println("Classpath entry: " + url); System.out.println("Classpath entry: " + url);
} }
slf4jClassLoader = new Slf4jTestClassLoader(urls, original); slf4jClassLoader = new Slf4jTestClassLoader(urls,original);
} }
catch (MalformedURLException e) catch (MalformedURLException e)
{ {
@ -161,8 +147,8 @@ public class Slf4jTestJarsRunner extends BlockJUnit4ClassRunner
Class<?> tc = slf4jClassLoader.loadClass(testclass.getName()); Class<?> tc = slf4jClassLoader.loadClass(testclass.getName());
Constructor<?>[] constructors= tc.getConstructors(); Constructor<?>[] constructors = tc.getConstructors();
Assert.assertEquals(1, constructors.length); Assert.assertEquals(1,constructors.length);
Constructor<?> constructor = constructors[0]; Constructor<?> constructor = constructors[0];
return constructor.newInstance(); return constructor.newInstance();