431459 - Jetty WebSocket compression extensions fails to handle big messages properly

+ Setting compression extensions to default unregistered state until
  they can be stablized.

jetty-websocket/javax-websocket-server-impl/src/test/java/org/eclipse/jetty/websocket/jsr356/server/ExtensionStackProcessingTest.java

@@ -22,6 +22,7 @@ import java.net.URI;
 import java.util.Arrays;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
+
 import javax.websocket.ClientEndpointConfig;
 import javax.websocket.ContainerProvider;
 import javax.websocket.Endpoint;
@@ -37,6 +38,7 @@ import javax.websocket.server.ServerEndpointConfig;
 import org.eclipse.jetty.server.Server;
 import org.eclipse.jetty.server.ServerConnector;
 import org.eclipse.jetty.servlet.ServletContextHandler;
+import org.eclipse.jetty.websocket.api.extensions.ExtensionFactory;
 import org.eclipse.jetty.websocket.api.extensions.OutgoingFrames;
 import org.eclipse.jetty.websocket.client.io.WebSocketClientConnection;
 import org.eclipse.jetty.websocket.common.extensions.ExtensionStack;
@@ -45,8 +47,10 @@ import org.eclipse.jetty.websocket.jsr356.JsrExtension;
 import org.eclipse.jetty.websocket.jsr356.JsrSession;
 import org.eclipse.jetty.websocket.jsr356.server.deploy.WebSocketServerContainerInitializer;
 import org.eclipse.jetty.websocket.jsr356.server.samples.echo.BasicEchoEndpoint;
+import org.eclipse.jetty.websocket.server.WebSocketUpgradeFilter;
 import org.junit.After;
 import org.junit.Assert;
+import org.junit.Assume;
 import org.junit.Before;
 import org.junit.Test;
 
@@ -54,6 +58,7 @@ public class ExtensionStackProcessingTest
 {
     private Server server;
     private ServerConnector connector;
+    private ExtensionFactory serverExtensionFactory;
     private WebSocketContainer client;
 
     @Before
@@ -65,6 +70,10 @@ public class ExtensionStackProcessingTest
 
         ServletContextHandler context = new ServletContextHandler(server, "/", true, false);
         ServerContainer container = WebSocketServerContainerInitializer.configureContext(context);
+        
+        WebSocketUpgradeFilter filter = (WebSocketUpgradeFilter)context.getAttribute(WebSocketUpgradeFilter.class.getName());
+        serverExtensionFactory = filter.getFactory().getExtensionFactory();
+        
         ServerEndpointConfig config = ServerEndpointConfig.Builder.create(BasicEchoEndpoint.class, "/").build();
         container.addEndpoint(config);
 
@@ -83,6 +92,8 @@ public class ExtensionStackProcessingTest
     @Test
     public void testDeflateFrameExtension() throws Exception
     {
+        Assume.assumeTrue("Server has deflate-frame extension registered",serverExtensionFactory.isAvailable("deflate-frame"));
+        
         ClientEndpointConfig config = ClientEndpointConfig.Builder.create()
                 .extensions(Arrays.<Extension>asList(new JsrExtension("deflate-frame")))
                 .build();
@@ -129,6 +140,8 @@ public class ExtensionStackProcessingTest
     @Test
     public void testPerMessageDeflateExtension() throws Exception
     {
+        Assume.assumeTrue("Server has permessage-deflate extension registered",serverExtensionFactory.isAvailable("permessage-deflate"));
+        
         ClientEndpointConfig config = ClientEndpointConfig.Builder.create()
                 .extensions(Arrays.<Extension>asList(new JsrExtension("permessage-deflate")))
                 .build();

jetty-websocket/websocket-client/src/main/java/org/eclipse/jetty/websocket/client/WebSocketClient.java

@@ -116,6 +116,12 @@ public class WebSocketClient extends ContainerLifeCycle implements SessionListen
         this.policy = WebSocketPolicy.newClientPolicy();
         this.bufferPool = bufferPool;
         this.extensionRegistry = new WebSocketExtensionFactory(policy,bufferPool);
+        
+        // Bug #431459 - unregistering compression extensions till they are more stable
+        this.extensionRegistry.unregister("deflate-frame");
+        this.extensionRegistry.unregister("permessage-deflate");
+        this.extensionRegistry.unregister("x-webkit-deflate-frame");
+        
         this.masker = new RandomMasker();
         this.eventDriverFactory = new EventDriverFactory(policy);
         this.sessionFactory = new WebSocketSessionFactory(this);

jetty-websocket/websocket-server/src/main/java/org/eclipse/jetty/websocket/server/WebSocketServerFactory.java

@@ -113,6 +113,12 @@ public class WebSocketServerFactory extends ContainerLifeCycle implements WebSoc
         this.eventDriverFactory = new EventDriverFactory(defaultPolicy);
         this.bufferPool = bufferPool;
         this.extensionFactory = new WebSocketExtensionFactory(defaultPolicy, this.bufferPool);
+        
+        // Bug #431459 - unregistering compression extensions till they are more stable
+        this.extensionFactory.unregister("deflate-frame");
+        this.extensionFactory.unregister("permessage-deflate");
+        this.extensionFactory.unregister("x-webkit-deflate-frame");
+        
         this.sessionFactories = new ArrayList<>();
         this.sessionFactories.add(new WebSocketSessionFactory(this));
         this.creator = this;

jetty-websocket/websocket-server/src/test/java/org/eclipse/jetty/websocket/server/PerMessageDeflateExtensionTest.java

@@ -30,6 +30,7 @@ import org.eclipse.jetty.websocket.common.test.HttpResponse;
 import org.eclipse.jetty.websocket.server.helper.EchoServlet;
 import org.junit.AfterClass;
 import org.junit.Assert;
+import org.junit.Assume;
 import org.junit.BeforeClass;
 import org.junit.Test;
 
@@ -69,7 +70,8 @@ public class PerMessageDeflateExtensionTest
             client.sendStandardRequest();
             HttpResponse resp = client.expectUpgradeResponse();
 
-            Assert.assertThat("Response",resp.getExtensionsHeader(),containsString("permessage-deflate"));
+            // Stop test here if server doesn't have permessage-deflate enabled.
+            Assume.assumeThat("Response",resp.getExtensionsHeader(),containsString("permessage-deflate"));
 
             String msg = "Hello";