From c9004ee68c38495c320ed4aeaa55ce9a3c24ec7c Mon Sep 17 00:00:00 2001 From: Lachlan Roberts Date: Wed, 1 Feb 2023 11:27:49 +1100 Subject: [PATCH] restore the resolveGenericRef with Class Signed-off-by: Lachlan Roberts --- .../core/internal/util/ReflectUtils.java | 37 ++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/jetty-core/jetty-websocket/jetty-websocket-core-common/src/main/java/org/eclipse/jetty/websocket/core/internal/util/ReflectUtils.java b/jetty-core/jetty-websocket/jetty-websocket-core-common/src/main/java/org/eclipse/jetty/websocket/core/internal/util/ReflectUtils.java index 702019839f6..4f733e123ff 100644 --- a/jetty-core/jetty-websocket/jetty-websocket-core-common/src/main/java/org/eclipse/jetty/websocket/core/internal/util/ReflectUtils.java +++ b/jetty-core/jetty-websocket/jetty-websocket-core-common/src/main/java/org/eclipse/jetty/websocket/core/internal/util/ReflectUtils.java @@ -207,6 +207,41 @@ public class ReflectUtils } } + private static boolean resolveGenericRef(GenericRef ref, Class clazz, Type type) + { + if (type instanceof Class) + { + if (type == ref.ifaceClass) + { + // is this a straight ref or a TypeVariable? + ref.setGenericFromType(type, 0); + return true; + } + else + { + // Keep digging + return resolveGenericRef(ref, type); + } + } + + if (type instanceof ParameterizedType ptype) + { + Type rawType = ptype.getRawType(); + if (rawType == ref.ifaceClass) + { + // Always get the raw type parameter, let unwrap() solve for what it is + ref.setGenericFromType(ptype.getActualTypeArguments()[0], 0); + return true; + } + else + { + // Keep digging + return resolveGenericRef(ref, rawType); + } + } + return false; + } + private static boolean resolveGenericRef(GenericRef ref, Type type) { if ((type == null) || (type == Object.class)) @@ -221,7 +256,7 @@ public class ReflectUtils Type[] ifaces = clazz.getGenericInterfaces(); for (Type iface : ifaces) { - if (resolveGenericRef(ref, iface)) + if (resolveGenericRef(ref, clazz, iface)) { if (ref.needsUnwrap()) {