diff --git a/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java b/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java index 0788a400680..fb068333dff 100644 --- a/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java +++ b/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java @@ -309,6 +309,9 @@ public class HttpClient extends ContainerLifeCycle * * @param uri the URI to GET * @return the {@link ContentResponse} for the request + * @throws InterruptedException if send threading has been interrupted + * @throws ExecutionException the execution failed + * @throws TimeoutException the send timed out * @see #GET(URI) */ public ContentResponse GET(String uri) throws InterruptedException, ExecutionException, TimeoutException @@ -321,6 +324,9 @@ public class HttpClient extends ContainerLifeCycle * * @param uri the URI to GET * @return the {@link ContentResponse} for the request + * @throws InterruptedException if send threading has been interrupted + * @throws ExecutionException the execution failed + * @throws TimeoutException the send timed out * @see #newRequest(URI) */ public ContentResponse GET(URI uri) throws InterruptedException, ExecutionException, TimeoutException @@ -334,6 +340,9 @@ public class HttpClient extends ContainerLifeCycle * @param uri the URI to POST * @param fields the fields composing the form name/value pairs * @return the {@link ContentResponse} for the request + * @throws InterruptedException if send threading has been interrupted + * @throws ExecutionException the execution failed + * @throws TimeoutException the send timed out */ public ContentResponse FORM(String uri, Fields fields) throws InterruptedException, ExecutionException, TimeoutException { @@ -346,6 +355,9 @@ public class HttpClient extends ContainerLifeCycle * @param uri the URI to POST * @param fields the fields composing the form name/value pairs * @return the {@link ContentResponse} for the request + * @throws InterruptedException if send threading has been interrupted + * @throws ExecutionException the execution failed + * @throws TimeoutException the send timed out */ public ContentResponse FORM(URI uri, Fields fields) throws InterruptedException, ExecutionException, TimeoutException { diff --git a/jetty-client/src/main/java/org/eclipse/jetty/client/HttpContent.java b/jetty-client/src/main/java/org/eclipse/jetty/client/HttpContent.java index c8518f922e5..58b16bb4ad3 100644 --- a/jetty-client/src/main/java/org/eclipse/jetty/client/HttpContent.java +++ b/jetty-client/src/main/java/org/eclipse/jetty/client/HttpContent.java @@ -42,7 +42,7 @@ import org.eclipse.jetty.util.log.Logger; * | | | | | | | | | | * +---+ +---+ +---+ +---+ +---+ * ^ ^ ^ ^ - * | | --> advance() | | + * | | --> advance() | | * | | last | * | | | * before | after diff --git a/jetty-client/src/main/java/org/eclipse/jetty/client/HttpConversation.java b/jetty-client/src/main/java/org/eclipse/jetty/client/HttpConversation.java index 2a5d0ae8af9..327d8aca7e3 100644 --- a/jetty-client/src/main/java/org/eclipse/jetty/client/HttpConversation.java +++ b/jetty-client/src/main/java/org/eclipse/jetty/client/HttpConversation.java @@ -41,42 +41,42 @@ public class HttpConversation extends AttributesMap * This list changes as the conversation proceeds, as follows: *
* The request state machine is updated by {@link HttpSender} as the various steps of sending a request
- * are executed, see {@link RequestState}.
+ * are executed, see RequestState
.
* At any point in time, a user thread may abort the request, which may (if the request has not been
- * completely sent yet) move the request state machine to {@link RequestState#FAILURE}.
+ * completely sent yet) move the request state machine to RequestState#FAILURE
.
* The request state machine guarantees that the request steps are executed (by I/O threads) only if
* the request has not been failed already.
*
diff --git a/jetty-client/src/main/java/org/eclipse/jetty/client/api/Authentication.java b/jetty-client/src/main/java/org/eclipse/jetty/client/api/Authentication.java index ead857b8d36..626070445e8 100644 --- a/jetty-client/src/main/java/org/eclipse/jetty/client/api/Authentication.java +++ b/jetty-client/src/main/java/org/eclipse/jetty/client/api/Authentication.java @@ -49,7 +49,7 @@ public interface Authentication /** * Executes the authentication mechanism for the given request, returning a {@link Result} that can be - * used to actually authenticate the request via {@link Result#apply(Request)}. + * used to actually authenticate the request via {@link org.eclipse.jetty.client.api.Authentication.Result#apply(Request)}. *
* If a request for {@code "/secure"} returns a {@link Result}, then the result may be used for other * requests such as {@code "/secure/foo"} or {@code "/secure/bar"}, unless those resources are protected @@ -117,7 +117,7 @@ public interface Authentication } /** - * {@link Result} holds the information needed to authenticate a {@link Request} via {@link #apply(Request)}. + * {@link Result} holds the information needed to authenticate a {@link Request} via {@link org.eclipse.jetty.client.api.Authentication.Result#apply(org.eclipse.jetty.client.api.Request)}. */ public static interface Result { diff --git a/jetty-client/src/main/java/org/eclipse/jetty/client/api/ContentProvider.java b/jetty-client/src/main/java/org/eclipse/jetty/client/api/ContentProvider.java index 737023ee15d..f661724fd3e 100644 --- a/jetty-client/src/main/java/org/eclipse/jetty/client/api/ContentProvider.java +++ b/jetty-client/src/main/java/org/eclipse/jetty/client/api/ContentProvider.java @@ -30,7 +30,7 @@ import org.eclipse.jetty.client.util.PathContentProvider; *
* Implementations should return an {@link Iterator} over the request content. * If the request content comes from a source that needs to be closed (for - * example, an {@link InputStream}), then the iterator implementation class + * example, an {@link java.io.InputStream}), then the iterator implementation class * must implement {@link Closeable} and will be closed when the request is * completed (either successfully or failed). *
diff --git a/jetty-client/src/main/java/org/eclipse/jetty/client/api/Request.java b/jetty-client/src/main/java/org/eclipse/jetty/client/api/Request.java
index a142c1e5fb4..01f0c2cf387 100644
--- a/jetty-client/src/main/java/org/eclipse/jetty/client/api/Request.java
+++ b/jetty-client/src/main/java/org/eclipse/jetty/client/api/Request.java
@@ -205,6 +205,7 @@ public interface Request
/**
* @param content the content provider of this request
+ * @param contentType the content type
* @return this request object
*/
Request content(ContentProvider content, String contentType);
@@ -285,6 +286,7 @@ public interface Request
/**
* @param listenerClass the class of the listener, or null for all listeners classes
* @return the listeners for request events of the given class
+ * @param
- * The core class is {@link org.eclipse.jetty.client.api.HttpClient}, which acts as a central configuration object (for example
- * for {@link org.eclipse.jetty.client.api.HttpClient#setIdleTimeout(long) idle timeouts}, {@link org.eclipse.jetty.client.api.HttpClient#setMaxConnectionsPerDestination(int)
- * max connections per destination}, etc.) and as a factory for {@link Request} objects.
+ * The core class is {@link org.eclipse.jetty.client.HttpClient}, which acts as a central configuration object (for example
+ * for {@link org.eclipse.jetty.client.HttpClient#setIdleTimeout(long) idle timeouts}, {@link org.eclipse.jetty.client.HttpClient#setMaxConnectionsPerDestination(int)
+ * max connections per destination}, etc.) and as a factory for {@link org.eclipse.jetty.client.api.Request} objects.
*
* The HTTP protocol is based on the request/response paradigm, a unit that in this implementation is called
- * exchange and is represented by {@link org.eclipse.jetty.client.api.HttpExchange}.
+ * exchange and is represented by {@link org.eclipse.jetty.client.HttpExchange}.
* An initial request may trigger a sequence of exchanges with one or more servers, called a conversation
- * and represented by {@link org.eclipse.jetty.client.api.HttpConversation}. A typical example of a conversation is a redirect, where
+ * and represented by {@link org.eclipse.jetty.client.HttpConversation}. A typical example of a conversation is a redirect, where
* upon a request for a resource URI, the server replies with a redirect (for example with the 303 status code)
* to another URI. This conversation is made of a first exchange made of the original request and its 303 response,
* and of a second exchange made of the request for the new URI and its 200 response.
*
- * {@link org.eclipse.jetty.client.api.HttpClient} holds a number of {@link org.eclipse.jetty.client.api.HttpDestination destinations}, which in turn hold a number of
- * pooled {@link org.eclipse.jetty.client.api.HttpConnection connections}.
+ * {@link org.eclipse.jetty.client.HttpClient} holds a number of {@link org.eclipse.jetty.client.api.Destination destinations}, which in turn hold a number of
+ * pooled {@link org.eclipse.jetty.client.api.Connection connections}.
*
* When a request is sent, its exchange is associated to a connection, either taken from an idle queue or created
* anew, and when both the request and response are completed, the exchange is disassociated from the connection.
* Conversations may span multiple connections on different destinations, and therefore are maintained at the
- * {@link org.eclipse.jetty.client.api.HttpClient} level.
+ * {@link org.eclipse.jetty.client.HttpClient} level.
*
* Applications may decide to send the request and wait for the response in a blocking way, using
* {@link org.eclipse.jetty.client.api.Request#send()}.
* Alternatively, application may ask to be notified of response events asynchronously, using
- * {@link org.eclipse.jetty.client.api.Request#send(Response.Listener)}.
+ * {@link org.eclipse.jetty.client.api.Request#send(org.eclipse.jetty.client.api.Response.CompleteListener)}.
*/
package org.eclipse.jetty.client;
+import org.eclipse.jetty.client.api.Response;
+
diff --git a/jetty-client/src/main/java/org/eclipse/jetty/client/util/DeferredContentProvider.java b/jetty-client/src/main/java/org/eclipse/jetty/client/util/DeferredContentProvider.java
index 15091558f1c..be88c9e4c70 100644
--- a/jetty-client/src/main/java/org/eclipse/jetty/client/util/DeferredContentProvider.java
+++ b/jetty-client/src/main/java/org/eclipse/jetty/client/util/DeferredContentProvider.java
@@ -73,7 +73,7 @@ import org.eclipse.jetty.util.Callback;
* .content(content)
* .send(new Response.CompleteListener()
* {
- * @Override
+ * @Override
* public void onComplete(Result result)
* {
* // Your logic here
diff --git a/jetty-client/src/main/java/org/eclipse/jetty/client/util/OutputStreamContentProvider.java b/jetty-client/src/main/java/org/eclipse/jetty/client/util/OutputStreamContentProvider.java
index 2da3e926a32..5af314ff22c 100644
--- a/jetty-client/src/main/java/org/eclipse/jetty/client/util/OutputStreamContentProvider.java
+++ b/jetty-client/src/main/java/org/eclipse/jetty/client/util/OutputStreamContentProvider.java
@@ -61,7 +61,7 @@ import org.eclipse.jetty.util.Callback;
* .content(content)
* .send(new Response.CompleteListener()
* {
- * @Override
+ * @Override
* public void onComplete(Result result)
* {
* // Your logic here
diff --git a/jetty-client/src/test/java/org/eclipse/jetty/client/HostnameVerificationTest.java b/jetty-client/src/test/java/org/eclipse/jetty/client/HostnameVerificationTest.java
index 29c898e2d41..f46a36086e8 100644
--- a/jetty-client/src/test/java/org/eclipse/jetty/client/HostnameVerificationTest.java
+++ b/jetty-client/src/test/java/org/eclipse/jetty/client/HostnameVerificationTest.java
@@ -95,7 +95,7 @@ public class HostnameVerificationTest
* http://www.ietf.org/rfc/rfc2818.txt section 3.1. It uses a certificate with a common name different to localhost
* and sends a request to localhost. This should fail with a SSLHandshakeException.
*
- * @throws Exception
+ * @throws Exception on test failure
*/
@Test
public void simpleGetWithHostnameVerificationEnabledTest() throws Exception
@@ -133,7 +133,8 @@ public class HostnameVerificationTest
* This test has hostname verification disabled and connecting, ssl handshake and sending the request should just
* work fine.
*
- * @throws Exception
+ * @throws Exception on test failure
+ *
*/
@Test
public void simpleGetWithHostnameVerificationDisabledTest() throws Exception
@@ -154,7 +155,7 @@ public class HostnameVerificationTest
* This test has hostname verification disabled by setting trustAll to true and connecting,
* ssl handshake and sending the request should just work fine.
*
- * @throws Exception
+ * @throws Exception on test failure
*/
@Test
public void trustAllDisablesHostnameVerificationTest() throws Exception
diff --git a/jetty-continuation/src/main/java/org/eclipse/jetty/continuation/Continuation.java b/jetty-continuation/src/main/java/org/eclipse/jetty/continuation/Continuation.java
index ad7b9e8a712..a6ff70e949d 100644
--- a/jetty-continuation/src/main/java/org/eclipse/jetty/continuation/Continuation.java
+++ b/jetty-continuation/src/main/java/org/eclipse/jetty/continuation/Continuation.java
@@ -24,10 +24,9 @@ import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;
import javax.servlet.ServletResponseWrapper;
-/* ------------------------------------------------------------ */
/**
* Continuation.
- *
+ *
* A continuation is a mechanism by which a HTTP Request can be suspended and
* restarted after a timeout or an asynchronous event has occurred.
*
@@ -52,7 +51,7 @@ import javax.servlet.ServletResponseWrapper;
*
* There are two distinct style of operation of the continuation API.
* The suspend/resume style is used when a servlet and/or
* filter is used to generate the response after a asynchronous wait that is
* terminated by an asynchronous handler.
@@ -87,7 +86,7 @@ import javax.servlet.ServletResponseWrapper;
* response.getOutputStream().write(process(results));
* }
*
- *
* The suspend/complete style is used when an asynchronous handler is used to
* generate the response:
@@ -152,7 +151,7 @@ public interface Continuation
* @param timeoutMs
* The time in milliseconds to wait before expiring this
* continuation after a call to {@link #suspend()} or {@link #suspend(ServletResponse)}.
- * A timeout of <=0 means the continuation will never expire.
+ * A timeout of <=0 means the continuation will never expire.
*/
void setTimeout(long timeoutMs);
@@ -164,8 +163,8 @@ public interface Continuation
*
* After this method has been called, the lifecycle of the request will be
* extended beyond the return to the container from the
- * {@link Servlet#service(ServletRequest, ServletResponse)} method and
- * {@link Filter#doFilter(ServletRequest, ServletResponse, FilterChain)}
+ * {@link javax.servlet.Servlet#service(ServletRequest, ServletResponse)} method and
+ * {@link javax.servlet.Filter#doFilter(ServletRequest, ServletResponse, FilterChain)}
* calls. When a suspended request is returned to the container after
* a dispatch, then the container will not commit the associated response
* (unless an exception other than {@link ContinuationThrowable} is thrown).
@@ -200,8 +199,8 @@ public interface Continuation
*
* After this method has been called, the lifecycle of the request will be
* extended beyond the return to the container from the
- * {@link Servlet#service(ServletRequest, ServletResponse)} method and
- * {@link Filter#doFilter(ServletRequest, ServletResponse, FilterChain)}
+ * {@link javax.servlet.Servlet#service(ServletRequest, ServletResponse)} method and
+ * {@link javax.servlet.Filter#doFilter(ServletRequest, ServletResponse, FilterChain)}
* calls. When a suspended request is returned to the container after
* a dispatch, then the container will not commit the associated response
* (unless an exception other than {@link ContinuationThrowable} is thrown).
@@ -365,7 +364,7 @@ public interface Continuation
/**
* Add a ContinuationListener.
*
- * @param listener
+ * @param listener the listener
*/
void addContinuationListener(ContinuationListener listener);
diff --git a/jetty-continuation/src/main/java/org/eclipse/jetty/continuation/ContinuationListener.java b/jetty-continuation/src/main/java/org/eclipse/jetty/continuation/ContinuationListener.java
index 1083f74e024..f30d5d3110e 100644
--- a/jetty-continuation/src/main/java/org/eclipse/jetty/continuation/ContinuationListener.java
+++ b/jetty-continuation/src/main/java/org/eclipse/jetty/continuation/ContinuationListener.java
@@ -22,13 +22,11 @@ import java.util.EventListener;
import javax.servlet.ServletRequestListener;
-
-/* ------------------------------------------------------------ */
-/** A Continuation Listener
+/**
+ * A Continuation Listener
*
* A ContinuationListener may be registered with a call to
* {@link Continuation#addContinuationListener(ContinuationListener)}.
- *
*/
public interface ContinuationListener extends EventListener
{
@@ -38,7 +36,7 @@ public interface ContinuationListener extends EventListener
* any calls to {@link ServletRequestListener#requestDestroyed(javax.servlet.ServletRequestEvent)}
* The response may still be written to during the call.
*
- * @param continuation
+ * @param continuation the continuation
*/
public void onComplete(Continuation continuation);
@@ -48,7 +46,7 @@ public interface ContinuationListener extends EventListener
* The response may be written to and the methods
* {@link Continuation#resume()} or {@link Continuation#complete()}
* may be called by a onTimeout implementation,
- * @param continuation
+ * @param continuation the continuation
*/
public void onTimeout(Continuation continuation);
diff --git a/jetty-jmx/src/main/java/org/eclipse/jetty/jmx/ConnectorServer.java b/jetty-jmx/src/main/java/org/eclipse/jetty/jmx/ConnectorServer.java
index 92574784758..303641b8b7d 100644
--- a/jetty-jmx/src/main/java/org/eclipse/jetty/jmx/ConnectorServer.java
+++ b/jetty-jmx/src/main/java/org/eclipse/jetty/jmx/ConnectorServer.java
@@ -57,7 +57,7 @@ public class ConnectorServer extends AbstractLifeCycle
* The actual address of the new connector server, as returned
* by its getAddress method, will not necessarily be exactly the same.
* @param name object name string to be assigned to connector server bean
- * @throws Exception
+ * @throws Exception if unable to setup connector server
*/
public ConnectorServer(JMXServiceURL serviceURL, String name)
throws Exception
@@ -77,7 +77,7 @@ public class ConnectorServer extends AbstractLifeCycle
* be Strings. The appropriate type of each associated value depends on
* the attribute. The contents of environment are not changed by this call.
* @param name object name string to be assigned to connector server bean
- * @throws Exception
+ * @throws Exception if unable to create connector server
*/
public ConnectorServer(JMXServiceURL svcUrl, Map
* A dynamic MBean that can wrap an arbitary Object instance.
* the attributes and methods exposed by this bean are controlled by
* the merge of property bundles discovered by names related to all
* superclasses and all superinterfaces.
- *
+ *
* Attributes and methods exported may be "Object" and must exist on the
* wrapped object, or "MBean" and must exist on a subclass of OBjectMBean
* or "MObject" which exists on the wrapped object, but whose values are
* converted to MBean object names.
- *
*/
public class ObjectMBean implements DynamicMBean
{
@@ -592,7 +592,7 @@ public class ObjectMBean implements DynamicMBean
* getter and setter methods. Descriptions are obtained with a call to findDescription with the
* attribute name.
*
- * @param method
+ * @param method the method to define
* @param attributeAnnotation "description" or "access:description" or "type:access:description" where type is
* one of:
- *
* The following init parameters are used to configure this servlet:
*
* This servlet may be used to concatenate multiple resources into
* a single response. It is intended to be used to load multiple
* javascript or css files, but may be used for any content of the
@@ -42,11 +43,11 @@ import javax.servlet.http.HttpServletResponse;
* relative to the context root. So these script tags:
* Implementation of the
- * cross-origin resource sharing. A typical example is to use this filter to allow cross-domain
+ * Implementation of the
+ * cross-origin resource sharing.
+ *
+ * A typical example is to use this filter to allow cross-domain
* cometd communication using the standard
* long polling transport instead of the JSONP transport (that is less
- * efficient and less reactive to failures). This filter allows the following configuration parameters:
- *
+ * This filter allows the following configuration parameters:
+ *
* If an allowed origin contains one or more * characters (for example
* http://*.domain.com), then "*" characters are converted to ".*", "."
* characters are escaped to "\." and the resulting allowed origin
- * interpreted as a regular expression.
* Allowed origins can therefore be more complex expressions such as
* https?://*.domain.[a-z]{3} that matches http or https, multiple subdomains
- * and any 3 letter top-level domain (.com, .net, .org, etc.). A typical configuration could be:
- *
* This filter is useful for limiting
* exposure to abuse from request flooding, whether malicious, or as a result of
* a misconfigured client.
@@ -81,13 +80,12 @@ import org.eclipse.jetty.util.thread.Scheduler;
* The {@link #extractUserId(ServletRequest request)} function should be
* implemented, in order to uniquely identify authenticated users.
*
- * The following init parameters control the behavior of the filter:
+ * The following init parameters control the behavior of the filter:
+ *
* Suspend/Resume Usage
+ * Suspend/Resume Usage
* Suspend/Complete Usage
+ * Suspend/Complete Usage
*
*
* the access is either "RW" or "RO".
+ * @return the mbean attribute info for the method
*/
public MBeanAttributeInfo defineAttribute(Method method, ManagedAttribute attributeAnnotation)
{
diff --git a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CGI.java b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CGI.java
index 87679c4b848..a88abed5774 100644
--- a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CGI.java
+++ b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CGI.java
@@ -44,11 +44,9 @@ import org.eclipse.jetty.util.UrlEncoded;
import org.eclipse.jetty.util.log.Log;
import org.eclipse.jetty.util.log.Logger;
-//-----------------------------------------------------------------------------
/**
* CGI Servlet.
*
*
- *
*/
public class CGI extends HttpServlet
{
@@ -546,13 +543,18 @@ public class CGI extends HttpServlet
/**
* Set a name/value pair, null values will be treated as an empty String
+ * @param name the name
+ * @param value the value
*/
public void set(String name, String value)
{
envMap.put(name,name + "=" + StringUtil.nonNull(value));
}
- /** Get representation suitable for passing to exec. */
+ /**
+ * Get representation suitable for passing to exec.
+ * @return the env map as an array
+ */
public String[] getEnvArray()
{
return envMap.values().toArray(new String[envMap.size()]);
diff --git a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/ConcatServlet.java b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/ConcatServlet.java
index cea7d0243c6..76ac313b2a9 100644
--- a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/ConcatServlet.java
+++ b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/ConcatServlet.java
@@ -27,8 +27,9 @@ import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
-/* ------------------------------------------------------------ */
-/** Concatenation Servlet
+/**
+ * Concatenation Servlet
+ *
* <script type="text/javascript" src="../js/behaviour.js"></script>
- * <script type="text/javascript" src="../js/ajax.js&/chat/chat.js"></script>
+ * <script type="text/javascript" src="../js/ajax.js&/chat/chat.js"></script>
* <script type="text/javascript" src="../chat/chat.js"></script>
*
can be replaced with the single tag (with the ConcatServlet mapped to /concat):
*
- * <script type="text/javascript" src="../concat?/js/behaviour.js&/js/ajax.js&/chat/chat.js"></script>
+ * <script type="text/javascript" src="../concat?/js/behaviour.js&/js/ajax.js&/chat/chat.js"></script>
*
* The {@link ServletContext#getMimeType(String)} method is used to determine the
* mime type of each resource. If the types of all resources do not match, then a 415
diff --git a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CrossOriginFilter.java b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CrossOriginFilter.java
index 2a2362e7372..f5cf2b0d970 100644
--- a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CrossOriginFilter.java
+++ b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/CrossOriginFilter.java
@@ -40,44 +40,62 @@ import org.eclipse.jetty.util.log.Log;
import org.eclipse.jetty.util.log.Logger;
/**
- *
- *
+ *
+ * origins.
+ *
+ * interpreted as a regular expression.
+ *
* <web-app ...>
* ...
diff --git a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/DoSFilter.java b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/DoSFilter.java
index 634af8c81c1..0b6c6ea45f7 100644
--- a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/DoSFilter.java
+++ b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/DoSFilter.java
@@ -64,7 +64,6 @@ import org.eclipse.jetty.util.thread.Scheduler;
/**
* Denial of Service filter
*
- *
*
- *
* This filter should be configured for {@link DispatcherType#REQUEST} and {@link DispatcherType#ASYNC} and with
* <async-supported>true</async-supported>
.
@@ -787,6 +784,7 @@ public class DoSFilter implements Filter
/**
* Get delay (in milliseconds) that is applied to all requests
* over the rate limit, before they are considered at all.
+ * @return the delay in milliseconds
*/
@ManagedAttribute("delay applied to all requests over the rate limit (in ms)")
public long getDelayMs()
@@ -1112,6 +1110,7 @@ public class DoSFilter implements Filter
}
/**
+ * @param now the time now (in milliseconds)
* @return the current calculated request rate over the last second
*/
public boolean isRateExceeded(long now)
diff --git a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/MultiPartFilter.java b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/MultiPartFilter.java
index 9adb9173dd4..cd1be544b45 100644
--- a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/MultiPartFilter.java
+++ b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/MultiPartFilter.java
@@ -56,7 +56,6 @@ import org.eclipse.jetty.util.log.Log;
import org.eclipse.jetty.util.log.Logger;
-/* ------------------------------------------------------------ */
/**
* Multipart Form Data Filter.
*
@@ -95,6 +94,7 @@ import org.eclipse.jetty.util.log.Logger; * * @deprecated See servlet 3.0 apis like javax.servlet.http.HttpServletRequest.getParts() */ +@Deprecated public class MultiPartFilter implements Filter { private static final Logger LOG = Log.getLogger(MultiPartFilter.class); @@ -243,9 +243,6 @@ public class MultiPartFilter implements Filter MultiMap